Message ID | 20220119151016.9970-1-xuan.ding@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3112BA0352; Wed, 19 Jan 2022 07:36:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7DD440DDB; Wed, 19 Jan 2022 07:36:32 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 7D7964013F for <dev@dpdk.org>; Wed, 19 Jan 2022 07:36:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642574191; x=1674110191; h=from:to:cc:subject:date:message-id; bh=5VrXv3jvqSArPIbmJX42I0A+6hm8fKQqIH77v8/8vN0=; b=Xl9IWMtlhv7JrN/TD4zmkkbZu5JIJktjNskBAMnv2Iyd07HqyZtdHSLQ wdBZ73op1m5prFE16q9NdEtFRUQbVW1Y9uo+y4WSej/H5IwH7wt/5DEZk JTKfydNo0J9Zt4TxuZgz4V0+Nkbi4/FOrrlF6TRfytEtsnsOl3XpdpNGG 9IyLuUm6kcuOSQLTiTnLUe34XDFkzPJGqPYJlw2gwqzZ9x1ueBLaSgRnU 5SrC/byj+pBiFBl7UmMnFaESm1wInCSfuXwDmuadVpllbQmlasl2aVVix bND7u6zaIXl9UsUf2Be3vm6VaCWPlLGudU7kXoPPF+PrfDJsQs/SbUJqX w==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="305727765" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="305727765" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 22:36:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="518056259" Received: from npg-dpdk-xuan-cbdma.sh.intel.com ([10.67.110.228]) by orsmga007.jf.intel.com with ESMTP; 18 Jan 2022 22:36:27 -0800 From: xuan.ding@intel.com To: maxime.coquelin@redhat.com, chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, yuanx.wang@intel.com, Xuan Ding <xuan.ding@intel.com> Subject: [PATCH v2 0/2] vhost: fix async address mapping Date: Wed, 19 Jan 2022 15:10:14 +0000 Message-Id: <20220119151016.9970-1-xuan.ding@intel.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
vhost: fix async address mapping
|
|
Message
Ding, Xuan
Jan. 19, 2022, 3:10 p.m. UTC
From: Xuan Ding <xuan.ding@intel.com>
This patchset fixes the issue of incorrect DMA mapping in PA mode.
Due to the ambiguity of host_phys_addr naming in the guest page
struct, rename it to host_iova.
v2:
* Change the order of patch.
Xuan Ding (2):
vhost: rename field in guest page struct
vhost: fix physical address mapping
lib/vhost/vhost.h | 11 ++--
lib/vhost/vhost_user.c | 130 ++++++++++++++++++++---------------------
lib/vhost/virtio_net.c | 11 ++--
3 files changed, 75 insertions(+), 77 deletions(-)
Comments
On 1/19/22 16:10, xuan.ding@intel.com wrote: > From: Xuan Ding <xuan.ding@intel.com> > > This patchset fixes the issue of incorrect DMA mapping in PA mode. > Due to the ambiguity of host_phys_addr naming in the guest page > struct, rename it to host_iova. > > v2: > * Change the order of patch. I'm not sure why you changed the order of the patches. Now, the second one is the fix, so it will make the backport more difficult. Either both are considered to be fixes. I think it can make sense as the renaming does not introduce risk of regression and will make backporting patches easier in the future. Other solution is to reverse the order again, but I think tagging the renaming as a fix is OK for me here. What do you think? Regards, Maxime > > Xuan Ding (2): > vhost: rename field in guest page struct > vhost: fix physical address mapping > > lib/vhost/vhost.h | 11 ++-- > lib/vhost/vhost_user.c | 130 ++++++++++++++++++++--------------------- > lib/vhost/virtio_net.c | 11 ++-- > 3 files changed, 75 insertions(+), 77 deletions(-) >
On 01/02/2022 08:28, Maxime Coquelin wrote: > > > On 1/19/22 16:10, xuan.ding@intel.com wrote: >> From: Xuan Ding <xuan.ding@intel.com> >> >> This patchset fixes the issue of incorrect DMA mapping in PA mode. >> Due to the ambiguity of host_phys_addr naming in the guest page >> struct, rename it to host_iova. >> >> v2: >> * Change the order of patch. > > I'm not sure why you changed the order of the patches. > Now, the second one is the fix, so it will make the backport more > difficult. Either both are considered to be fixes. I think it can make > sense as the renaming does not introduce risk of regression and will > make backporting patches easier in the future. > > Other solution is to reverse the order again, but I think tagging the > renaming as a fix is OK for me here. > > What do you think? > Either way sounds ok to me, but can you also add stable tag(s). There isn't a stable tag on either patch at present. Thanks. > Regards, > Maxime > >> >> Xuan Ding (2): >> vhost: rename field in guest page struct >> vhost: fix physical address mapping >> >> lib/vhost/vhost.h | 11 ++-- >> lib/vhost/vhost_user.c | 130 ++++++++++++++++++++--------------------- >> lib/vhost/virtio_net.c | 11 ++-- >> 3 files changed, 75 insertions(+), 77 deletions(-) >> >
On 2/1/22 12:29, Kevin Traynor wrote: > On 01/02/2022 08:28, Maxime Coquelin wrote: >> >> >> On 1/19/22 16:10, xuan.ding@intel.com wrote: >>> From: Xuan Ding <xuan.ding@intel.com> >>> >>> This patchset fixes the issue of incorrect DMA mapping in PA mode. >>> Due to the ambiguity of host_phys_addr naming in the guest page >>> struct, rename it to host_iova. >>> >>> v2: >>> * Change the order of patch. >> >> I'm not sure why you changed the order of the patches. >> Now, the second one is the fix, so it will make the backport more >> difficult. Either both are considered to be fixes. I think it can make >> sense as the renaming does not introduce risk of regression and will >> make backporting patches easier in the future. >> >> Other solution is to reverse the order again, but I think tagging the >> renaming as a fix is OK for me here. >> >> What do you think? >> > > Either way sounds ok to me, but can you also add stable tag(s). There > isn't a stable tag on either patch at present. Thanks. OK, will do. Thanks Kevin, Maxime >> Regards, >> Maxime >> >>> >>> Xuan Ding (2): >>> vhost: rename field in guest page struct >>> vhost: fix physical address mapping >>> >>> lib/vhost/vhost.h | 11 ++-- >>> lib/vhost/vhost_user.c | 130 >>> ++++++++++++++++++++--------------------- >>> lib/vhost/virtio_net.c | 11 ++-- >>> 3 files changed, 75 insertions(+), 77 deletions(-) >>> >> >
On 1/19/22 16:10, xuan.ding@intel.com wrote: > From: Xuan Ding <xuan.ding@intel.com> > > This patchset fixes the issue of incorrect DMA mapping in PA mode. > Due to the ambiguity of host_phys_addr naming in the guest page > struct, rename it to host_iova. > > v2: > * Change the order of patch. > > Xuan Ding (2): > vhost: rename field in guest page struct > vhost: fix physical address mapping > > lib/vhost/vhost.h | 11 ++-- > lib/vhost/vhost_user.c | 130 ++++++++++++++++++++--------------------- > lib/vhost/virtio_net.c | 11 ++-- > 3 files changed, 75 insertions(+), 77 deletions(-) > I was willing to apply the series, but it does not apply. Could you please rebase with taking our comments into account? Thanks, Maxime
Hi Maxime & Kevin, > -----Original Message----- > From: Maxime Coquelin <maxime.coquelin@redhat.com> > Sent: 2022年2月4日 18:57 > To: Ding, Xuan <xuan.ding@intel.com>; Xia, Chenbo <chenbo.xia@intel.com> > Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Wang, YuanX > <yuanx.wang@intel.com> > Subject: Re: [PATCH v2 0/2] vhost: fix async address mapping > > > > On 1/19/22 16:10, xuan.ding@intel.com wrote: > > From: Xuan Ding <xuan.ding@intel.com> > > > > This patchset fixes the issue of incorrect DMA mapping in PA mode. > > Due to the ambiguity of host_phys_addr naming in the guest page > > struct, rename it to host_iova. > > > > v2: > > * Change the order of patch. The consideration of changing the order here is to avoid the fix patch using the previous variable name(host_phys_addr), so rename the variable first. > > > > Xuan Ding (2): > > vhost: rename field in guest page struct > > vhost: fix physical address mapping > > > > lib/vhost/vhost.h | 11 ++-- > > lib/vhost/vhost_user.c | 130 ++++++++++++++++++++--------------------- > > lib/vhost/virtio_net.c | 11 ++-- > > 3 files changed, 75 insertions(+), 77 deletions(-) > > > > I was willing to apply the series, but it does not apply. > Could you please rebase with taking our comments into account? Thanks for your comments, I will send a new patch set applied with your comments. Regards, Xuan > > Thanks, > Maxime