[v2] net/ice/base: support E824S and E825 devices
Checks
Commit Message
Add support for E824S and E825 family devices.
Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
---
doc/guides/rel_notes/release_22_03.rst | 4 ++++
drivers/net/ice/base/ice_common.c | 6 ++++++
drivers/net/ice/base/ice_devids.h | 13 +++++++++++++
drivers/net/ice/ice_ethdev.c | 6 ++++++
4 files changed, 29 insertions(+)
Comments
> -----Original Message-----
> From: Zhang, RobinX <robinx.zhang@intel.com>
> Sent: Wednesday, February 16, 2022 3:45 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>
> Subject: [PATCH v2] net/ice/base: support E824S and E825 devices
>
> Add support for E824S and E825 family devices.
>
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
On 2/23/2022 2:42 AM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Zhang, RobinX <robinx.zhang@intel.com>
>> Sent: Wednesday, February 16, 2022 3:45 PM
>> To: dev@dpdk.org
>> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>; Yang, SteveX
>> <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>
>> Subject: [PATCH v2] net/ice/base: support E824S and E825 devices
>>
>> Add support for E824S and E825 family devices.
>>
>> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
>
Hi Qi, Robin,
The apply note is on v2, but v1 seems merged to your tree,
omitting release notes update (which was the request on v1).
I guess you don't want to document it in release notes
since devices are still under test and it will be
documented later when device support is matured, is this
correct?
If so can you please clarify this in the commit log with
a new version of patch?
@@ -118,6 +118,10 @@ New Features
* Added PPPoL2TPv2oUDP FDIR distribute packets based on inner IP
src/dst address and UDP/TCP src/dst port.
+* **Updated the Intel ice driver.**
+
+ * Added new device IDs to support E824S and E825 devices.
+
* **Updated Wangxun ngbe driver.**
* Added support for devices of custom PHY interfaces.
@@ -167,6 +167,12 @@ static enum ice_status ice_set_mac_type(struct ice_hw *hw)
case ICE_DEV_ID_E823C_QSFP:
case ICE_DEV_ID_E823C_SFP:
case ICE_DEV_ID_E823C_SGMII:
+ case ICE_DEV_ID_E824S:
+ case ICE_DEV_ID_E825C_BACKPLANE:
+ case ICE_DEV_ID_E825C_QSFP:
+ case ICE_DEV_ID_E825C_SFP:
+ case ICE_DEV_ID_E825C_1GBE:
+ case ICE_DEV_ID_E825X:
hw->mac_type = ICE_MAC_GENERIC;
break;
default:
@@ -58,5 +58,18 @@
#define ICE_DEV_ID_E822L_10G_BASE_T 0x1899
/* Intel(R) Ethernet Connection E822-L 1GbE */
#define ICE_DEV_ID_E822L_SGMII 0x189A
+/* Intel(R) Ethernet Connection E824-S */
+#define ICE_DEV_ID_E824S 0x0DBD
+/* Intel(R) Ethernet Connection E825-C for backplane */
+#define ICE_DEV_ID_E825C_BACKPLANE 0x579C
+/* Intel(R) Ethernet Connection E825-C for QSFP */
+#define ICE_DEV_ID_E825C_QSFP 0x579D
+/* Intel(R) Ethernet Connection E825-C for SFP */
+#define ICE_DEV_ID_E825C_SFP 0x579E
+/* Intel(R) Ethernet Connection E825-C 1GbE */
+#define ICE_DEV_ID_E825C_1GBE 0x579F
+/* Intel(R) Ethernet Connection E825-X */
+#define ICE_DEV_ID_E825X 0x0DCD
+
#endif /* _ICE_DEVIDS_H_ */
@@ -196,6 +196,12 @@ static const struct rte_pci_id pci_id_ice_map[] = {
{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_SFP) },
{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_10G_BASE_T) },
{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_SGMII) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E824S) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_BACKPLANE) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_QSFP) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_SFP) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_1GBE) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825X) },
{ .vendor_id = 0, /* sentinel */ },
};