diff mbox series

net/cnxk: fix error message setting on failure

Message ID 20220419063438.269086-1-psatheesh@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series net/cnxk: fix error message setting on failure |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/intel-Testing success Testing PASS

Commit Message

Satheesh Paul Antonysamy April 19, 2022, 6:34 a.m. UTC 
  From: Satheesh Paul <psatheesh@marvell.com>

Set the error message with rte_flow_error_set() api
when flow parsing fails.

Fixes: 8c009b4505e ("net/cnxk: support flow API")
Cc: stable@dpdk.org

Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
---
 drivers/net/cnxk/cnxk_flow.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Jerin Jacob May 3, 2022, 6:09 a.m. UTC | #1 
On Tue, Apr 19, 2022 at 12:04 PM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Set the error message with rte_flow_error_set() api
> when flow parsing fails.
>
> Fixes: 8c009b4505e ("net/cnxk: support flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>

Applied to dpdk-next-net-mrvl/for-next-net. Thanks

> ---
>  drivers/net/cnxk/cnxk_flow.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c
> index 8763ca63d6..2b13352312 100644
> --- a/drivers/net/cnxk/cnxk_flow.c
> +++ b/drivers/net/cnxk/cnxk_flow.c
> @@ -297,7 +297,14 @@ cnxk_flow_validate(struct rte_eth_dev *eth_dev,
>                 return rc;
>         }
>
> -       return roc_npc_flow_parse(npc, &in_attr, in_pattern, in_actions, &flow);
> +       rc = roc_npc_flow_parse(npc, &in_attr, in_pattern, in_actions, &flow);
> +
> +       if (rc) {
> +               rte_flow_error_set(error, 0, rc, NULL,
> +                                  "Flow validation failed");
> +               return rc;
> +       }
> +       return 0;
>  }
>
>  struct roc_npc_flow *
> --
> 2.25.4
>
diff mbox series

Patch

diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c
index 8763ca63d6..2b13352312 100644
--- a/drivers/net/cnxk/cnxk_flow.c
+++ b/drivers/net/cnxk/cnxk_flow.c
@@ -297,7 +297,14 @@  cnxk_flow_validate(struct rte_eth_dev *eth_dev,
 		return rc;
 	}
 
-	return roc_npc_flow_parse(npc, &in_attr, in_pattern, in_actions, &flow);
+	rc = roc_npc_flow_parse(npc, &in_attr, in_pattern, in_actions, &flow);
+
+	if (rc) {
+		rte_flow_error_set(error, 0, rc, NULL,
+				   "Flow validation failed");
+		return rc;
+	}
+	return 0;
 }
 
 struct roc_npc_flow *