[2/2] net/bnxt: remove some dead code
Checks
Commit Message
Removed some macros that were defined but not used in this driver.
As a result, rte_smp_xx occurrence is removed from this driver.
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Kathleen Capella <kathleen.capella@arm.com>
---
drivers/net/bnxt/bnxt_cpr.h | 14 --------------
1 file changed, 14 deletions(-)
Comments
> -----Original Message-----
> From: Ruifeng Wang <ruifeng.wang@arm.com>
> Sent: Tuesday, May 10, 2022 2:31 PM
> To: Ajit Khaparde (ajit.khaparde@broadcom.com)
> <ajit.khaparde@broadcom.com>; somnath.kotur@broadcom.com
> Cc: dev@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Kathleen Capella <Kathleen.Capella@arm.com>
> Subject: [PATCH 2/2] net/bnxt: remove some dead code
>
> Removed some macros that were defined but not used in this driver.
> As a result, rte_smp_xx occurrence is removed from this driver.
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Kathleen Capella <kathleen.capella@arm.com>
> ---
> drivers/net/bnxt/bnxt_cpr.h | 14 --------------
> 1 file changed, 14 deletions(-)
>
The CI failures reported by ci/intel-Testing seem to be irrelevant with this patch.
@@ -39,25 +39,11 @@ struct bnxt_db_info;
#define B_CP_DB_DISARM(cpr) (*(uint32_t *)((cpr)->cp_db.doorbell) = \
DB_KEY_CP | DB_IRQ_DIS)
-#define B_CP_DB_IDX_ARM(cpr, cons) \
- (*(uint32_t *)((cpr)->cp_db.doorbell) = (DB_CP_REARM_FLAGS | \
- (cons)))
-
-#define B_CP_DB_IDX_DISARM(cpr, cons) do { \
- rte_smp_wmb(); \
- (*(uint32_t *)((cpr)->cp_db.doorbell) = (DB_CP_FLAGS | \
- (cons)); \
-} while (0)
#define B_CP_DIS_DB(cpr, raw_cons) \
rte_write32_relaxed((DB_CP_FLAGS | \
DB_RING_IDX(&((cpr)->cp_db), raw_cons)), \
((cpr)->cp_db.doorbell))
-#define B_CP_DB(cpr, raw_cons, ring_mask) \
- rte_write32((DB_CP_FLAGS | \
- RING_CMPL((ring_mask), raw_cons)), \
- ((cpr)->cp_db.doorbell))
-
struct bnxt_db_info {
void *doorbell;
union {