framework: fix session output
Checks
Commit Message
* it should flush buffer before getting output
* fix strip space in all session output
* fix some output don't have \r\n before [PEXPECT]
Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
Reported-by: Reshma Pattan <reshma.pattan@intel.com>
---
framework/crb.py | 7 ++++---
framework/ssh_pexpect.py | 15 +++++++--------
2 files changed, 11 insertions(+), 11 deletions(-)
Comments
> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Monday, August 2, 2021 10:52 PM
> To: Pattan, Reshma <reshma.pattan@intel.com>
> Cc: dts@dpdk.org; Tu, Lijuan <Lijuan.Tu@intel.com>
> Subject: [PATCH] framework: fix session output
Hi Lijuan,
I have not seen v2 version of this patch was nener merged to main .
http://patches.dpdk.org/project/dts/patch/1628156514-12397-1-git-send-email-lijuan.tu@intel.com/
Could you please merge it? As we need this fix for power related tests.
Thanks,
Reshma
@@ -94,10 +94,11 @@ class Crb(object):
# sometimes there will be no alt_session like VM dut
if alt_session and self.alt_session:
- return self.alt_session.session.send_expect(cmds, expected,
+ out = self.alt_session.session.send_expect(cmds, expected,
timeout, verify)
-
- return self.session.send_expect(cmds, expected, timeout, verify)
+ else:
+ out = self.session.send_expect(cmds, expected, timeout, verify)
+ return out.strip()
def create_session(self, name=""):
"""
@@ -78,6 +78,8 @@ class SSHPexpect:
self.clean_session()
self.session.PROMPT = expected
self.__sendline(command)
+ # flush buffer before prompt, else buffer may impact output
+ self.__flush()
self.__prompt(command, timeout)
aware_keyintr()
@@ -127,13 +129,13 @@ class SSHPexpect:
ignore_keyintr()
self.session.PROMPT = self.magic_prompt
try:
+ self.__flush()
self.session.prompt(timeout)
except Exception as e:
- pass
+ raise(e)
aware_keyintr()
before = self.get_output_all()
- self.__flush()
return before
@@ -159,15 +161,12 @@ class SSHPexpect:
def get_output_before(self):
if not self.isalive():
raise SSHSessionDeadException(self.host)
- before = self.session.before.rsplit('\r\n', 1)
- if before[0] == "[PEXPECT]":
- before[0] = ""
- return before[0]
+ before = self.session.before.strip('[PEXPECT]')
+ return before
def get_output_all(self):
- output = self.session.before
- output.replace("[PEXPECT]", "")
+ output = self.session.before.strip('[PEXPECT]')
return output
def close(self, force=False):