examples/distributor: fix syntax on single core rx and distributor
Checks
Commit Message
This patch fixes the syntax error when using the single-core
for both rx and distributor functions.
Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
Cc: stable@dpdk.org
Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
---
Cc: david.hunt@intel.com
---
examples/distributor/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
> This patch fixes the syntax error when using the single-core
> for both rx and distributor functions.
>
> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
> Cc: stable@dpdk.org
>
> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
Can we convert compile time macro to dynamic configuration to prevent
build errors like this?
Hi Ferruh,
On 20/06/2022 18:10, Ferruh Yigit wrote:
> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
>> This patch fixes the syntax error when using the single-core
>> for both rx and distributor functions.
>>
>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>
>
> Can we convert compile time macro to dynamic configuration to prevent
> build errors like this?
+1 for the dynamic config. Maybe a "-c" on the command line for "combine
rx and dist threads"?
Tested-by: David Hunt <david.hunt@intel.com>
On 6/21/2022 9:44 AM, Hunt, David wrote:
>
> Hi Ferruh,
>
> On 20/06/2022 18:10, Ferruh Yigit wrote:
>> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
>>> This patch fixes the syntax error when using the single-core
>>> for both rx and distributor functions.
>>>
>>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>>
>> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>>
>>
>> Can we convert compile time macro to dynamic configuration to prevent
>> build errors like this?
>
>
> +1 for the dynamic config. Maybe a "-c" on the command line for "combine
> rx and dist threads"?
>
Hi Dave,
'-c' sounds good,
Can you, or someone you delegate, address this, or should we create a
bugzilla to record?
Or Omer if you are interested in doing this change, please let us know.
>
> Tested-by: David Hunt <david.hunt@intel.com>
>
>
On 21.06.2022 13:26, Ferruh Yigit wrote:
> On 6/21/2022 9:44 AM, Hunt, David wrote:
>>
>> Hi Ferruh,
>>
>> On 20/06/2022 18:10, Ferruh Yigit wrote:
>>> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
>>>> This patch fixes the syntax error when using the single-core
>>>> for both rx and distributor functions.
>>>>
>>>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>>>
>>> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>>>
>>>
>>> Can we convert compile time macro to dynamic configuration to prevent
>>> build errors like this?
>>
>>
>> +1 for the dynamic config. Maybe a "-c" on the command line for
>> "combine
>> rx and dist threads"?
>>
>
> Hi Dave,
>
> '-c' sounds good,
>
> Can you, or someone you delegate, address this, or should we create a
> bugzilla to record?
>
> Or Omer if you are interested in doing this change, please let us know.
Hi Ferruh,
I can do it, if you can review it. Because I am trying to getting
familiar of your coding style.
>
>>
>> Tested-by: David Hunt <david.hunt@intel.com>
>>
>>
On 6/21/2022 12:18 PM, Omer Yamac wrote:
> On 21.06.2022 13:26, Ferruh Yigit wrote:
>> On 6/21/2022 9:44 AM, Hunt, David wrote:
>>>
>>> Hi Ferruh,
>>>
>>> On 20/06/2022 18:10, Ferruh Yigit wrote:
>>>> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
>>>>> This patch fixes the syntax error when using the single-core
>>>>> for both rx and distributor functions.
>>>>>
>>>>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
>>>>> Cc: stable@dpdk.org
>>>>>
>>>>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>>>>
>>>> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>>>>
>>>>
>>>> Can we convert compile time macro to dynamic configuration to prevent
>>>> build errors like this?
>>>
>>>
>>> +1 for the dynamic config. Maybe a "-c" on the command line for "combine
>>> rx and dist threads"?
>>>
>>
>> Hi Dave,
>>
>> '-c' sounds good,
>>
>> Can you, or someone you delegate, address this, or should we create a
>> bugzilla to record?
>>
>> Or Omer if you are interested in doing this change, please let us know.
>
> Hi Ferruh,
> I can do it, if you can review it. Because I am trying to getting
> familiar of your coding style.
>
Cool, thanks. I think main person here who will set the bar for the
acceptance is Dave as maintainer of the component :), but sure we all
can help/review.
>>
>>>
>>> Tested-by: David Hunt <david.hunt@intel.com>
>>>
>>>
21/06/2022 10:44, Hunt, David:
> On 20/06/2022 18:10, Ferruh Yigit wrote:
> > On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
> >> This patch fixes the syntax error when using the single-core
> >> for both rx and distributor functions.
> >>
> >> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> >
> > Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
> >
> > Can we convert compile time macro to dynamic configuration to prevent
> > build errors like this?
>
> +1 for the dynamic config. Maybe a "-c" on the command line for "combine
> rx and dist threads"?
>
> Tested-by: David Hunt <david.hunt@intel.com>
Applied this fix, thanks.
Improvement with dynamic option can come later.
@@ -261,8 +261,8 @@ lcore_rx(struct lcore_params *p)
* packets are then send straight to the tx core.
*/
#if 0
- rte_distributor_process(d, bufs, nb_rx);
- const uint16_t nb_ret = rte_distributor_returned_pktsd,
+ rte_distributor_process(p->d, bufs, nb_rx);
+ const uint16_t nb_ret = rte_distributor_returned_pkts(p->d,
bufs, BURST_SIZE*2);
app_stats.rx.returned_pkts += nb_ret;