[V1,2/2] tests/virtio_user_as_exceptional_path: delete modify dpdk code steps

Message ID 20220624065529.2832947-1-weix.ling@intel.com (mailing list archive)
State Accepted
Headers
Series delete modify dpdk code content and steps |

Checks

Context Check Description
ci/Intel-dts-doc-test success Testing OK
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK

Commit Message

Ling, WeiX June 24, 2022, 6:55 a.m. UTC
  According to the dpdk commit 1945c64674(app/testpmd: perform SW IP
checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost:
perform SW checksum in Tx path), no need to modify DPDK code to test.

Signed-off-by: Wei Ling <weix.ling@intel.com>
---
 ...stSuite_virtio_user_as_exceptional_path.py | 26 -------------------
 1 file changed, 26 deletions(-)
  

Comments

Huang, ChenyuX June 24, 2022, 7:09 a.m. UTC | #1
> -----Original Message-----
> From: Wei Ling <weix.ling@intel.com>
> Sent: Friday, June 24, 2022 2:55 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/virtio_user_as_exceptional_path: delete
> modify dpdk code steps
> 
> According to the dpdk commit 1945c64674(app/testpmd: perform SW IP
> checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost:
> perform SW checksum in Tx path), no need to modify DPDK code to test.
> 
> Signed-off-by: Wei Ling <weix.ling@intel.com>
> ---
Tested-by: Chenyu Huang <chenyux.huang@intel.com>
  
Tu, Lijuan June 29, 2022, 2:17 a.m. UTC | #2
On Fri, 24 Jun 2022 02:55:29 -0400, Wei Ling <weix.ling@intel.com> wrote:
> According to the dpdk commit 1945c64674(app/testpmd: perform SW IP
> checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost:
> perform SW checksum in Tx path), no need to modify DPDK code to test.
> 
> Signed-off-by: Wei Ling <weix.ling@intel.com>


Series applied, thanks
  

Patch

diff --git a/tests/TestSuite_virtio_user_as_exceptional_path.py b/tests/TestSuite_virtio_user_as_exceptional_path.py
index 1f7d8330..c5105d5f 100644
--- a/tests/TestSuite_virtio_user_as_exceptional_path.py
+++ b/tests/TestSuite_virtio_user_as_exceptional_path.py
@@ -44,7 +44,6 @@  class TestVirtioUserAsExceptionalPath(TestCase):
             self.socket_mem = "1024,1024"
         self.pktgen_helper = PacketGeneratorHelper()
         self.peer_pci_setup = False
-        self.prepare_dpdk()
         self.app_testpmd_path = self.dut.apps_name["test-pmd"]
         self.testpmd_name = self.app_testpmd_path.split("/")[-1]
 
@@ -181,30 +180,6 @@  class TestVirtioUserAsExceptionalPath(TestCase):
             "ip netns exec ns1 ethtool -K %s tso on" % self.nic_in_kernel, "#"
         )
 
-    def prepare_dpdk(self):
-        #
-        # Changhe the testpmd checksum fwd code for mac change
-        self.dut.send_expect(
-            "cp ./app/test-pmd/csumonly.c ./app/test-pmd/csumonly_backup.c", "#"
-        )
-        self.dut.send_expect(
-            "sed -i '/ether_addr_copy(&peer_eth/i\#if 0' ./app/test-pmd/csumonly.c", "#"
-        )
-        self.dut.send_expect(
-            "sed -i '/parse_ethernet(eth_hdr, &info/i\#endif' ./app/test-pmd/csumonly.c",
-            "#",
-        )
-        self.dut.build_install_dpdk(self.dut.target)
-        time.sleep(3)
-
-    def unprepare_dpdk(self):
-        # Recovery the DPDK code to original
-        self.dut.send_expect(
-            "cp ./app/test-pmd/csumonly_backup.c ./app/test-pmd/csumonly.c ", "#"
-        )
-        self.dut.send_expect("rm -rf ./app/test-pmd/csumonly_backup.c", "#")
-        self.dut.build_install_dpdk(self.dut.target)
-
     def iperf_result_verify(self, vm_client, direction):
         """
         Get the iperf test result
@@ -375,7 +350,6 @@  class TestVirtioUserAsExceptionalPath(TestCase):
         for i in self.dut_ports:
             port = self.dut.ports_info[i]["port"]
             port.bind_driver(self.def_driver)
-        self.unprepare_dpdk()
         if self.peer_pci_setup:
             self.dut.send_expect(
                 "./usertools/dpdk-devbind.py -u %s" % (self.pci), "# ", 30