diff mbox series

doc: announce name change of stop flush callback

Message ID 20220624090828.2020-1-pbhagavatula@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series doc: announce name change of stop flush callback |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Pavan Nikhilesh Bhagavatula June 24, 2022, 9:08 a.m. UTC 
  From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Stop flush callback is missing `rte_` prefix and might conflict with
application declarations.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jerin Jacob July 11, 2022, 2:50 p.m. UTC | #1 
On Fri, Jun 24, 2022 at 2:40 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Stop flush callback is missing `rte_` prefix and might conflict with
> application declarations.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>

+ @Gage Eads


> ---
>  doc/guides/rel_notes/deprecation.rst | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 4e5b23c53d..a3c4f4ac09 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -125,3 +125,6 @@ Deprecation Notices
>    applications should be updated to use the ``dmadev`` library instead,
>    with the underlying HW-functionality being provided by the ``ioat`` or
>    ``idxd`` dma drivers
> +
> +* eventdev: The function pointer declaration ``eventdev_stop_flush_t`` will be
> +  renamed to ``rte_eventdev_stop_flush_t`` in DPDK 22.11.
> --
> 2.25.1
>
Pavan Nikhilesh Bhagavatula July 12, 2022, 6:12 p.m. UTC | #2 
+Cc
timothy.mcdaniel@intel.com;
hemant.agrawal@nxp.com;
sachin.saxena@oss.nxp.com;
mattias.ronnblom@ericsson.com;
jerinj@marvell.com;
liangma@liangbit.com;
peter.mccarthy@intel.com;
harry.van.haaren@intel.com;
erik.g.carrillo@intel.com;
abhinandan.gujjar@intel.com;
jay.jayatheerthan@intel.com;
mdr@ashroe.eu;
anatoly.burakov@intel.com;

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Monday, July 11, 2022 8:21 PM
> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Gage Eads
> <gage.eads@intel.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Ray Kinsella
> <mdr@ashroe.eu>; dpdk-dev <dev@dpdk.org>
> Subject: [EXT] Re: [PATCH] doc: announce name change of stop flush callback
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Fri, Jun 24, 2022 at 2:40 PM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Stop flush callback is missing `rte_` prefix and might conflict with
> > application declarations.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> 
> + @Gage Eads
> 
> 
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> > index 4e5b23c53d..a3c4f4ac09 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -125,3 +125,6 @@ Deprecation Notices
> >    applications should be updated to use the ``dmadev`` library instead,
> >    with the underlying HW-functionality being provided by the ``ioat`` or
> >    ``idxd`` dma drivers
> > +
> > +* eventdev: The function pointer declaration ``eventdev_stop_flush_t``
> will be
> > +  renamed to ``rte_eventdev_stop_flush_t`` in DPDK 22.11.
> > --
> > 2.25.1
> >
Mattias Rönnblom July 13, 2022, 9:11 a.m. UTC | #3 
On 2022-07-12 20:12, Pavan Nikhilesh Bhagavatula wrote:
> +Cc
> timothy.mcdaniel@intel.com;
> hemant.agrawal@nxp.com;
> sachin.saxena@oss.nxp.com;
> mattias.ronnblom@ericsson.com;
> jerinj@marvell.com;
> liangma@liangbit.com;
> peter.mccarthy@intel.com;
> harry.van.haaren@intel.com;
> erik.g.carrillo@intel.com;
> abhinandan.gujjar@intel.com;
> jay.jayatheerthan@intel.com;
> mdr@ashroe.eu;
> anatoly.burakov@intel.com;
> 
>> -----Original Message-----
>> From: Jerin Jacob <jerinjacobk@gmail.com>
>> Sent: Monday, July 11, 2022 8:21 PM
>> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Gage Eads
>> <gage.eads@intel.com>
>> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Ray Kinsella
>> <mdr@ashroe.eu>; dpdk-dev <dev@dpdk.org>
>> Subject: [EXT] Re: [PATCH] doc: announce name change of stop flush callback
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> On Fri, Jun 24, 2022 at 2:40 PM <pbhagavatula@marvell.com> wrote:
>>>
>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>
>>> Stop flush callback is missing `rte_` prefix and might conflict with
>>> application declarations.
>>>
>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>
>> + @Gage Eads
>>
>>
>>> ---
>>>   doc/guides/rel_notes/deprecation.rst | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> b/doc/guides/rel_notes/deprecation.rst
>>> index 4e5b23c53d..a3c4f4ac09 100644
>>> --- a/doc/guides/rel_notes/deprecation.rst
>>> +++ b/doc/guides/rel_notes/deprecation.rst
>>> @@ -125,3 +125,6 @@ Deprecation Notices
>>>     applications should be updated to use the ``dmadev`` library instead,
>>>     with the underlying HW-functionality being provided by the ``ioat`` or
>>>     ``idxd`` dma drivers
>>> +
>>> +* eventdev: The function pointer declaration ``eventdev_stop_flush_t``
>> will be
>>> +  renamed to ``rte_eventdev_stop_flush_t`` in DPDK 22.11.
>>> --
>>> 2.25.1
>>>

Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Van Haaren, Harry July 14, 2022, 11:21 a.m. UTC | #4 
> -----Original Message-----
> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Sent: Wednesday, July 13, 2022 10:11 AM
> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin Jacob
> <jerinjacobk@gmail.com>; Gage Eads <gage.eads@intel.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Ray Kinsella <mdr@ashroe.eu>;
> dpdk-dev <dev@dpdk.org>; McDaniel, Timothy <timothy.mcdaniel@intel.com>;
> hemant.agrawal@nxp.com; sachin.saxena@oss.nxp.com; liangma@liangbit.com;
> Mccarthy, Peter <peter.mccarthy@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Carrillo, Erik G <erik.g.carrillo@intel.com>; Gujjar,
> Abhinandan S <abhinandan.gujjar@intel.com>; Jayatheerthan, Jay
> <jay.jayatheerthan@intel.com>; Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: Re: [EXT] Re: [PATCH] doc: announce name change of stop flush callback
> 
> On 2022-07-12 20:12, Pavan Nikhilesh Bhagavatula wrote:
> > +Cc
> > timothy.mcdaniel@intel.com;
> > hemant.agrawal@nxp.com;
> > sachin.saxena@oss.nxp.com;
> > mattias.ronnblom@ericsson.com;
> > jerinj@marvell.com;
> > liangma@liangbit.com;
> > peter.mccarthy@intel.com;
> > harry.van.haaren@intel.com;
> > erik.g.carrillo@intel.com;
> > abhinandan.gujjar@intel.com;
> > jay.jayatheerthan@intel.com;
> > mdr@ashroe.eu;
> > anatoly.burakov@intel.com;
> >
> >> -----Original Message-----
> >> From: Jerin Jacob <jerinjacobk@gmail.com>
> >> Sent: Monday, July 11, 2022 8:21 PM
> >> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Gage Eads
> >> <gage.eads@intel.com>
> >> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Ray Kinsella
> >> <mdr@ashroe.eu>; dpdk-dev <dev@dpdk.org>
> >> Subject: [EXT] Re: [PATCH] doc: announce name change of stop flush callback
> >>
> >> External Email
> >>
> >> ----------------------------------------------------------------------
> >> On Fri, Jun 24, 2022 at 2:40 PM <pbhagavatula@marvell.com> wrote:
> >>>
> >>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>>
> >>> Stop flush callback is missing `rte_` prefix and might conflict with
> >>> application declarations.
> >>>
> >>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>
> >> Acked-by: Jerin Jacob <jerinj@marvell.com>
> >>
> >> + @Gage Eads
> >>
> >>
> >>> ---
> >>>   doc/guides/rel_notes/deprecation.rst | 3 +++
> >>>   1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/doc/guides/rel_notes/deprecation.rst
> >> b/doc/guides/rel_notes/deprecation.rst
> >>> index 4e5b23c53d..a3c4f4ac09 100644
> >>> --- a/doc/guides/rel_notes/deprecation.rst
> >>> +++ b/doc/guides/rel_notes/deprecation.rst
> >>> @@ -125,3 +125,6 @@ Deprecation Notices
> >>>     applications should be updated to use the ``dmadev`` library instead,
> >>>     with the underlying HW-functionality being provided by the ``ioat`` or
> >>>     ``idxd`` dma drivers
> >>> +
> >>> +* eventdev: The function pointer declaration ``eventdev_stop_flush_t``
> >> will be
> >>> +  renamed to ``rte_eventdev_stop_flush_t`` in DPDK 22.11.
> >>> --
> >>> 2.25.1
> >>>
> 
> Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>

Makes sense; good tidy up.

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Thomas Monjalon July 17, 2022, 12:25 p.m. UTC | #5 
> > >>> Stop flush callback is missing `rte_` prefix and might conflict with
> > >>> application declarations.
> > >>>
> > >>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >>
> > >> Acked-by: Jerin Jacob <jerinj@marvell.com>
> > 
> > Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> 
> Makes sense; good tidy up.
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 4e5b23c53d..a3c4f4ac09 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -125,3 +125,6 @@  Deprecation Notices
   applications should be updated to use the ``dmadev`` library instead,
   with the underlying HW-functionality being provided by the ``ioat`` or
   ``idxd`` dma drivers
+
+* eventdev: The function pointer declaration ``eventdev_stop_flush_t`` will be
+  renamed to ``rte_eventdev_stop_flush_t`` in DPDK 22.11.