diff mbox series

[V1] tests/dual_vlan: modify case vlan_tpid_config sync with testplan

Message ID 20220810090507.27306-1-linglix.chen@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/dual_vlan: modify case vlan_tpid_config sync with testplan |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-doc-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test fail Testing issues

Commit Message

Lingli Chen Aug. 10, 2022, 9:05 a.m. UTC 
  1.modify case vlan_tpid_config tpid 0x1234 sync with testplan
2.replace qinq with extend: Change the command according to the modification of dpdk commit 2a0b41984c7

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 test_plans/dual_vlan_test_plan.rst | 6 ++----
 tests/TestSuite_dual_vlan.py       | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

Comments

Weiyuan Li Aug. 24, 2022, 8:42 a.m. UTC | #1 
> -----Original Message-----
> From: Lingli Chen <linglix.chen@intel.com>
> Sent: Wednesday, August 10, 2022 5:05 PM
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts][PATCH V1] tests/dual_vlan: modify case vlan_tpid_config sync
> with testplan
> 
> 1.modify case vlan_tpid_config tpid 0x1234 sync with testplan 2.replace qinq
> with extend: Change the command according to the modification of dpdk
> commit 2a0b41984c7
> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>
> ---
Tested-by: Weiyuan Li <weiyuanx.li@intel.com>
Peng, Yuan Aug. 25, 2022, 5:06 a.m. UTC | #2 
Acked-by Peng, Yuan <yuan.peng@intel.com>

-----Original Message-----
From: Lingli Chen <linglix.chen@intel.com> 
Sent: Wednesday, August 10, 2022 5:05 PM
To: dts@dpdk.org
Cc: Chen, LingliX <linglix.chen@intel.com>
Subject: [dts][PATCH V1] tests/dual_vlan: modify case vlan_tpid_config sync with testplan

1.modify case vlan_tpid_config tpid 0x1234 sync with testplan 2.replace qinq with extend: Change the command according to the modification of dpdk commit 2a0b41984c7

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
Tu, Lijuan Sept. 7, 2022, 9:35 a.m. UTC | #3 
On Wed, 10 Aug 2022 05:05:07 -0400, Lingli Chen <linglix.chen@intel.com> wrote:
> 1.modify case vlan_tpid_config tpid 0x1234 sync with testplan
> 2.replace qinq with extend: Change the command according to the modification of dpdk commit 2a0b41984c7
> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Applied, thanks
diff mbox series

Patch

diff --git a/test_plans/dual_vlan_test_plan.rst b/test_plans/dual_vlan_test_plan.rst
index 762147f0..985394a2 100644
--- a/test_plans/dual_vlan_test_plan.rst
+++ b/test_plans/dual_vlan_test_plan.rst
@@ -245,7 +245,7 @@  Test Case: Configure receive port outer VLAN TPID
 
 Enable vlan header QinQ on port ``0`` firstly to support set TPID::
 
-    testpmd> vlan set qinq on 0
+    testpmd> vlan set extend on 0
 
 Check whether the mode is set successfully::
 
@@ -260,9 +260,7 @@  Check whether the mode is set successfully::
     Allmulticast mode: disabled
     Maximum number of MAC addresses: 127
     VLAN offload:
-      strip off
-      filter off
-      qinq(extend) on
+      strip off, filter off, extend on, qinq strip off
 
 Set Tag Protocol ID ``0x1234`` on port ``0``.
 Nic only support inner model, except Intel® Ethernet 700 Series::
diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index 99f47a82..15d6f2b2 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -520,7 +520,7 @@  class TestDualVlan(TestCase):
 
         self.mode_config(filter="on", strip="on", extend="on")
         # nic only support inner model, except Intel® Ethernet 700 Series nic
-        self.dut.send_expect("vlan set inner tpid 1234 %s" % dutRxPortId, "testpmd> ")
+        self.dut.send_expect("vlan set inner tpid 0x1234 %s" % dutRxPortId, "testpmd> ")
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()