diff mbox series

[V2] tests/vf_vlan: case add_pvid_vf restart testpmd after remove vlan according to testplan

Message ID 20220908024719.30163-1-weiyuanx.li@intel.com (mailing list archive)
State Accepted
Headers
Series [V2] tests/vf_vlan: case add_pvid_vf restart testpmd after remove vlan according to testplan |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK

Commit Message

Weiyuan Li Sept. 8, 2022, 2:47 a.m. UTC 
  Case add_pvid_vf modify to restart testpmd after remove vlan according to testplan.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---

v2:
-Patch conflict modification

 tests/TestSuite_vf_vlan.py | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

Comments

Lingli Chen Sept. 15, 2022, 7:30 a.m. UTC | #1 
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Thursday, September 8, 2022 10:47 AM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V2] tests/vf_vlan: case add_pvid_vf restart testpmd after
> remove vlan according to testplan
> 
> Case add_pvid_vf modify to restart testpmd after remove vlan according to
> testplan.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---

Tested-by: Lingli Chen <linglix.chen@intel.com>
Fu, Qi Sept. 20, 2022, 7:34 a.m. UTC | #2 
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Thursday, September 8, 2022 10:47 AM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V2] tests/vf_vlan: case add_pvid_vf restart testpmd after
> remove vlan according to testplan
> 
> Case add_pvid_vf modify to restart testpmd after remove vlan according to
> testplan.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
> 
> v2:
> -Patch conflict modification
> 
>  tests/TestSuite_vf_vlan.py | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> 2.25.1
Acked-by: Fu, Qi <qi.fu@intel.com>
Tu, Lijuan Sept. 20, 2022, 8:04 a.m. UTC | #3 
On Thu,  8 Sep 2022 10:47:19 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote:
> Case add_pvid_vf modify to restart testpmd after remove vlan according to testplan.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Applied, thanks
diff mbox series

Patch

diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index c4904c55..31826db5 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -233,16 +233,18 @@  class TestVfVlan(TestCase):
 
         # remove vlan
         self.vm0_testpmd.execute_cmd("stop")
-        self.vm0_testpmd.execute_cmd("port stop all")
+        self.vm0_testpmd.quit()
         self.dut.send_expect("ip link set %s vf 0 vlan 0" % self.host_intf0, "# ")
         out = self.dut.send_expect("ip link show %s" % self.host_intf0, "# ")
         self.verify("vlan %d" % random_vlan not in out, "Failed to remove pvid on VF0")
 
-        # send packet with vlan
-        self.vm0_testpmd.execute_cmd("port reset 0", "testpmd> ", 120)
-        self.vm0_testpmd.execute_cmd("port start all")
+        # restart testpmd
+        self.vm0_testpmd = PmdOutput(self.vm_dut_0)
+        self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
+        self.vm0_testpmd.execute_cmd("set fwd rxonly")
+        self.vm0_testpmd.execute_cmd("set verbose 1")
         self.vm0_testpmd.execute_cmd("start")
-
+        # send packet with vlan
         out = self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
         if (
             (self.kdriver == "i40e" and self.driver_version < "2.13.10")