Message ID | 20220928131801.64467-1-arkadiuszx.kusztal@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBA22A00C4; Wed, 28 Sep 2022 16:27:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F51D4113D; Wed, 28 Sep 2022 16:27:16 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id B04A2410FA for <dev@dpdk.org>; Wed, 28 Sep 2022 16:27:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664375234; x=1695911234; h=from:to:cc:subject:date:message-id; bh=Bvbm62Nx1sQgFZaggs3L3p/ukM6uHEummePx/HC54uw=; b=WByao17chKlVvvhGAlxY3clK0MOuaUp1Kg0gDpIlKs2yBNbflrDYdLKE zjHZAAREl+q0VSEhz8cJyXtymoE7nh+io8blgp6Uv2CHmQqy1lEtwZAhc uK0gFZ9io9aQi/KEztpoHAs/OAy8V/ePa0q00N6qS2tiJ2uzm2ysLb+k+ HuITzJaQDzNqZorq1DrvAo8PR4exvghGMWrd6ePCzDBHpiqfgcBCuqhkO ZSTzJE9rY5K0BH5i0cWz46MQxRMVcdiBGzhdUrXtMbsxf7U2byyj/5W9f bS1ldAaydjFncE7PsczSWAmOVtVATiDmBnorcpBiLbvhNm9yFhfdfblyi A==; X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="281331387" X-IronPort-AV: E=Sophos;i="5.93,352,1654585200"; d="scan'208";a="281331387" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2022 07:27:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="684425684" X-IronPort-AV: E=Sophos;i="5.93,352,1654585200"; d="scan'208";a="684425684" Received: from silpixa00399302.ir.intel.com ([10.237.214.136]) by fmsmga008.fm.intel.com with ESMTP; 28 Sep 2022 07:27:06 -0700 From: Arek Kusztal <arkadiuszx.kusztal@intel.com> To: dev@dpdk.org Cc: gakhil@marvell.com, kai.ji@intel.com, Arek Kusztal <arkadiuszx.kusztal@intel.com> Subject: [PATCH v2 0/2] cryptodev: add SM3 and SM4 algorithms Date: Wed, 28 Sep 2022 14:17:59 +0100 Message-Id: <20220928131801.64467-1-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.13.6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
cryptodev: add SM3 and SM4 algorithms
|
|
Message
Arkadiusz Kusztal
Sept. 28, 2022, 1:17 p.m. UTC
ShangMi 4 (SM4) is a block cipher used in the Chinese National Standard for Wireless LAN WAPI and also used with Transport Layer Security. ShangMi 3 (SM3) is a cryptographic hash function used in the Chinese National Standard. This patcheset adds both to the Cryptodev. v2: - Fixed incorrect sm3 string - Added full name of the algorithm Arek Kusztal (2): cryptodev: add sm4 encryption algorithm cryptodev: add sm3 hash algorithm doc/guides/cryptodevs/features/default.ini | 4 ++++ doc/guides/rel_notes/release_22_11.rst | 9 +++++++++ lib/cryptodev/rte_crypto_sym.h | 13 +++++++++++-- lib/cryptodev/rte_cryptodev.c | 8 ++++++-- 4 files changed, 30 insertions(+), 4 deletions(-)
Comments
> -----Original Message----- > From: Arek Kusztal <arkadiuszx.kusztal@intel.com> > Sent: Wednesday, September 28, 2022 6:48 PM > To: dev@dpdk.org > Cc: Akhil Goyal <gakhil@marvell.com>; kai.ji@intel.com; Arek Kusztal > <arkadiuszx.kusztal@intel.com> > Subject: [EXT] [PATCH v2 0/2] cryptodev: add SM3 and SM4 algorithms > > External Email > > ---------------------------------------------------------------------- > ShangMi 4 (SM4) is a block cipher used in the Chinese National Standard for > Wireless LAN WAPI and also used with Transport Layer Security. > ShangMi 3 (SM3) is a cryptographic hash function used in the Chinese > National Standard. > > This patcheset adds both to the Cryptodev. > > v2: > - Fixed incorrect sm3 string > - Added full name of the algorithm > > Arek Kusztal (2): > cryptodev: add sm4 encryption algorithm > cryptodev: add sm3 hash algorithm > > doc/guides/cryptodevs/features/default.ini | 4 ++++ > doc/guides/rel_notes/release_22_11.rst | 9 +++++++++ > lib/cryptodev/rte_crypto_sym.h | 13 +++++++++++-- > lib/cryptodev/rte_cryptodev.c | 8 ++++++-- > 4 files changed, 30 insertions(+), 4 deletions(-) > > -- > 2.13.6 Series Acked-by: Anoob Joseph <anoobj@marvell.com>
> ShangMi 4 (SM4) is a block cipher used in the Chinese National Standard for > Wireless LAN WAPI and also used with Transport Layer Security. > ShangMi 3 (SM3) is a cryptographic hash function used in the > Chinese National Standard. > > This patcheset adds both to the Cryptodev. > > v2: > - Fixed incorrect sm3 string > - Added full name of the algorithm > > Arek Kusztal (2): > cryptodev: add sm4 encryption algorithm > cryptodev: add sm3 hash algorithm > > doc/guides/cryptodevs/features/default.ini | 4 ++++ > doc/guides/rel_notes/release_22_11.rst | 9 +++++++++ > lib/cryptodev/rte_crypto_sym.h | 13 +++++++++++-- > lib/cryptodev/rte_cryptodev.c | 8 ++++++-- > 4 files changed, 30 insertions(+), 4 deletions(-) > Hi Arek, Why are the QAT implementation patches removed from this series? We cannot simply add enums which are not being used anywhere. Regards, Akhil
> -----Original Message----- > From: Akhil Goyal <gakhil@marvell.com> > Sent: Thursday, September 29, 2022 9:25 PM > To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org > Cc: Ji, Kai <kai.ji@intel.com> > Subject: RE: [EXT] [PATCH v2 0/2] cryptodev: add SM3 and SM4 algorithms > > > ShangMi 4 (SM4) is a block cipher used in the Chinese National > > Standard for Wireless LAN WAPI and also used with Transport Layer Security. > > ShangMi 3 (SM3) is a cryptographic hash function used in the Chinese > > National Standard. > > > > This patcheset adds both to the Cryptodev. > > > > v2: > > - Fixed incorrect sm3 string > > - Added full name of the algorithm > > > > Arek Kusztal (2): > > cryptodev: add sm4 encryption algorithm > > cryptodev: add sm3 hash algorithm > > > > doc/guides/cryptodevs/features/default.ini | 4 ++++ > > doc/guides/rel_notes/release_22_11.rst | 9 +++++++++ > > lib/cryptodev/rte_crypto_sym.h | 13 +++++++++++-- > > lib/cryptodev/rte_cryptodev.c | 8 ++++++-- > > 4 files changed, 30 insertions(+), 4 deletions(-) > > > Hi Arek, > > Why are the QAT implementation patches removed from this series? > We cannot simply add enums which are not being used anywhere. I wanted to push qat patches and tests to rc2. I this option cannot be accepted I will send v3 with qat patches before rc1 deadline. > > Regards, > Akhil
> > > ShangMi 4 (SM4) is a block cipher used in the Chinese National > > > Standard for Wireless LAN WAPI and also used with Transport Layer Security. > > > ShangMi 3 (SM3) is a cryptographic hash function used in the Chinese > > > National Standard. > > > > > > This patcheset adds both to the Cryptodev. > > > > > > v2: > > > - Fixed incorrect sm3 string > > > - Added full name of the algorithm > > > > > > Arek Kusztal (2): > > > cryptodev: add sm4 encryption algorithm > > > cryptodev: add sm3 hash algorithm > > > > > > doc/guides/cryptodevs/features/default.ini | 4 ++++ > > > doc/guides/rel_notes/release_22_11.rst | 9 +++++++++ > > > lib/cryptodev/rte_crypto_sym.h | 13 +++++++++++-- > > > lib/cryptodev/rte_cryptodev.c | 8 ++++++-- > > > 4 files changed, 30 insertions(+), 4 deletions(-) > > > > > Hi Arek, > > > > Why are the QAT implementation patches removed from this series? > > We cannot simply add enums which are not being used anywhere. > I wanted to push qat patches and tests to rc2. I this option cannot be accepted I > will send v3 with qat patches before rc1 deadline. We can take the QAT patches in RC2. But atleast we should have plans for the implementation to be merged. I will merge the patches today. Please make sure the implementation is applied in RC2. Regards, Akhil
> -----Original Message----- > From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com> > Sent: Friday, September 30, 2022 2:06 PM > To: Akhil Goyal <gakhil@marvell.com>; dev@dpdk.org > Cc: Ji, Kai <kai.ji@intel.com> > Subject: RE: [EXT] [PATCH v2 0/2] cryptodev: add SM3 and SM4 algorithms > > > > > -----Original Message----- > > From: Akhil Goyal <gakhil@marvell.com> > > Sent: Thursday, September 29, 2022 9:25 PM > > To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org > > Cc: Ji, Kai <kai.ji@intel.com> > > Subject: RE: [EXT] [PATCH v2 0/2] cryptodev: add SM3 and SM4 algorithms > > > > > ShangMi 4 (SM4) is a block cipher used in the Chinese National > > > Standard for Wireless LAN WAPI and also used with Transport Layer Security. > > > ShangMi 3 (SM3) is a cryptographic hash function used in the Chinese > > > National Standard. > > > > > > This patcheset adds both to the Cryptodev. > > > > > > v2: > > > - Fixed incorrect sm3 string > > > - Added full name of the algorithm > > > > > > Arek Kusztal (2): > > > cryptodev: add sm4 encryption algorithm > > > cryptodev: add sm3 hash algorithm > > > > > > doc/guides/cryptodevs/features/default.ini | 4 ++++ > > > doc/guides/rel_notes/release_22_11.rst | 9 +++++++++ > > > lib/cryptodev/rte_crypto_sym.h | 13 +++++++++++-- > > > lib/cryptodev/rte_cryptodev.c | 8 ++++++-- > > > 4 files changed, 30 insertions(+), 4 deletions(-) > > > > > Hi Arek, > > > > Why are the QAT implementation patches removed from this series? > > We cannot simply add enums which are not being used anywhere. > I wanted to push qat patches and tests to rc2. I this option cannot be accepted I > will send v3 with qat patches before rc1 deadline. > > This series along with PMD changes applied to dpdk-next-crypto Thanks.