[2/3] net/ixgbe: fix security session destroy
Checks
Commit Message
Replace mempool_put with memset 0, the internal session memory block
is no longer allocated from a mempool
Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
Cc: gakhil@marvell.com
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
drivers/net/ixgbe/ixgbe_ipsec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Comments
> Replace mempool_put with memset 0, the internal session memory block
> is no longer allocated from a mempool
>
> Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
> Cc: gakhil@marvell.com
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Thursday, October 13, 2022 8:24 PM
> To: Nicolau, Radu <radu.nicolau@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [EXT] [PATCH 2/3] net/ixgbe: fix security session destroy
>
> > Replace mempool_put with memset 0, the internal session memory block
> > is no longer allocated from a mempool
> >
> > Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
> > Cc: gakhil@marvell.com
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -429,7 +429,6 @@ ixgbe_crypto_remove_session(void *device,
{
struct rte_eth_dev *eth_dev = device;
struct ixgbe_crypto_session *ic_session = SECURITY_GET_SESS_PRIV(session);
- struct rte_mempool *mempool = rte_mempool_from_obj(ic_session);
if (eth_dev != ic_session->dev) {
PMD_DRV_LOG(ERR, "Session not bound to this device\n");
@@ -441,8 +440,7 @@ ixgbe_crypto_remove_session(void *device,
return -EFAULT;
}
- rte_mempool_put(mempool, (void *)ic_session);
-
+ memset(ic_session, 0, sizeof(struct ixgbe_crypto_session));
return 0;
}