net/idpf: fix memory leak
Checks
Commit Message
From: Beilei Xing <beilei.xing@intel.com>
This patch fixes memory leak during Tx split queue release.
Fixes: 19b58dba9dc3 ("net/idpf: support queue release")
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/idpf/idpf_rxtx.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Comments
Tested-by: Peng, Yuan <yuan.peng@intel.com>
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Wednesday, November 9, 2022 2:29 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Peng, Yuan <yuan.peng@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: [PATCH] net/idpf: fix memory leak
>
> From: Beilei Xing <beilei.xing@intel.com>
>
> This patch fixes memory leak during Tx split queue release.
>
> Fixes: 19b58dba9dc3 ("net/idpf: support queue release")
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> -----Original Message-----
> From: Peng, Yuan <yuan.peng@intel.com>
> Sent: Wednesday, November 9, 2022 3:19 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] net/idpf: fix memory leak
>
> Tested-by: Peng, Yuan <yuan.peng@intel.com>
>
> > -----Original Message-----
> > From: Xing, Beilei <beilei.xing@intel.com>
> > Sent: Wednesday, November 9, 2022 2:29 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; Peng, Yuan <yuan.peng@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>
> > Subject: [PATCH] net/idpf: fix memory leak
> >
> > From: Beilei Xing <beilei.xing@intel.com>
> >
> > This patch fixes memory leak during Tx split queue release.
> >
> > Fixes: 19b58dba9dc3 ("net/idpf: support queue release")
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -213,7 +213,11 @@ idpf_tx_queue_release(void *txq)
if (q == NULL)
return;
- rte_free(q->complq);
+ if (q->complq) {
+ rte_memzone_free(q->complq->mz);
+ rte_free(q->complq);
+ }
+
q->ops->release_mbufs(q);
rte_free(q->sw_ring);
rte_memzone_free(q->mz);