Message ID | 20230213061140.2157499-1-michaelba@nvidia.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DD6441C82; Mon, 13 Feb 2023 07:12:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7165741151; Mon, 13 Feb 2023 07:11:59 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2041.outbound.protection.outlook.com [40.107.94.41]) by mails.dpdk.org (Postfix) with ESMTP id 35C53410F2 for <dev@dpdk.org>; Mon, 13 Feb 2023 07:11:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C7VfKA7TWGjWY93YOhe1Qilzd/BbzRP5lZzOKJuJjkrE8ecyKslkWJIQ5tHgzVHUR0JquPbnoPvAyKhB3O8/gNvLUBKbO5Y2T4kRWxEJ/1Tg13XyYn3ve11HaXvEqNPRd6/1/IpinShvSlcqlNoGrn1xYAISIna3/gKHGcr91Bd8pk84Ai/9J81tw49CuMQGlLbKts38JIvzgWeG+0in01kNNGr8jGIz4CEOhOfd+dXge75CoCqwVXvX/CeuUAJQDwpVwS3tyWUGdInRueXDh6zmQTB3rjN1bTpxevHKnWCvKc/A/qkrqiY01p6535ZMXHYtqz3vYXthEnDxasicfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AU6JMJYAIHdBmxf7vkBkJ/8eiyofu4ULSb84Xmh7SOw=; b=A4mLEGrjwecVaPka8yOQqvo54paiKgHxro7aninvJ7B9bY1nAVK5FKq7+nldmXfLEjmy8ZQUfoXYUHjTr9dtF03hUWdIK1Qa+dG6K/JbVC2kYExXf6motG2sPK2tbMQfnQaGhTEuWY8gH/AURKmxKcZZ8z9b929ZhdzTd/Qa0wm/8GGXza+2zPXgmBPJHQrZRMOyTmdDFalx9hy5ALQbdDoQh1unMswmAknYsUZkzVHiXP48u0qLXRSVBuK4hWES8Xk07DM3DHV+HmUndNGwwSSUCtTLfH+dYkJ6+gmyPEhOY7sxiinBMOtNBDhwqSxZ9iklUW1oZDJxOGncpXukXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AU6JMJYAIHdBmxf7vkBkJ/8eiyofu4ULSb84Xmh7SOw=; b=ShjMH9DpcbMj7VMjketpse8+1arv/Yg6bqmWQW1S03zoblZxlmQ6+kXJQCUr6h98gtMrogi7zXLD5BD2KBp61B9wXYjwk/kxPm8jBRs1Ah6r9OQoWcNt0kjCWXnx756jYiOlNLQsImVvqKiJbS5fS5M28hdRMhtRYJS+I1buOwLnaSAsljGyKIWhHasN0axPs95RbweoprNJ5lPRaRiSaGVA3jm+EATohf8wE7yFoV8XB+aCMgIAGFQ0l3PPVk2D+y2wLE1UoBGz2H+0firyPwwwywSjp6DKaL3ykTESKs/ibsY5z4esaH4SBIg8wWZdlxWEBUeAMIDhuRoW8Gg2Dg== Received: from MW4PR03CA0044.namprd03.prod.outlook.com (2603:10b6:303:8e::19) by CH3PR12MB7570.namprd12.prod.outlook.com (2603:10b6:610:149::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 06:11:48 +0000 Received: from CO1NAM11FT021.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8e:cafe::7c) by MW4PR03CA0044.outlook.office365.com (2603:10b6:303:8e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 06:11:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CO1NAM11FT021.mail.protection.outlook.com (10.13.175.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 06:11:48 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 12 Feb 2023 22:11:46 -0800 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 12 Feb 2023 22:11:46 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36 via Frontend Transport; Sun, 12 Feb 2023 22:11:44 -0800 From: Michael Baum <michaelba@nvidia.com> To: <dev@dpdk.org> CC: Matan Azrad <matan@nvidia.com>, Akhil Goyal <gakhil@marvell.com>, "Ashish Gupta" <ashish.gupta@marvell.com>, Fiona Trahe <fiona.trahe@intel.com>, "Thomas Monjalon" <thomas@monjalon.net> Subject: [PATCH v3 0/4] compressdev: add LZ4 support Date: Mon, 13 Feb 2023 08:11:36 +0200 Message-ID: <20230213061140.2157499-1-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202091332.1037078-1-michaelba@nvidia.com> References: <20230202091332.1037078-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT021:EE_|CH3PR12MB7570:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a27409c-b892-40da-2c52-08db0d8930b6 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8aamokwKMn4CTwbXaQJwGTYjtVn2/jg65h8nicT9sQXVypTBu3IpWkIwKVlcPrrBldwHuac7KCS59nvSRfGpILvFcV5Wy8vzdgj+5fLxzS0cfaJE1U5YElASEt/s/8tgS5pprOTeEjYQONwy79vOXo1UkXT6hbrfgo03gLkM38ZvxFfuZ71rcq6x2jtjhnxJ8uxUx8YaxUIIerbMR6HyYcjQ64Y7a637h8X+AeKq1hLspme3Yc2PI4+9HLyzXDr9AMz7nDBRkgk66OzpQlwwOwWHA4vrcIEVVFmtYmThRK7aBmUPONqcoNhKy7koJ03DO4NZFRDM9HpBsVOFRCYNaqjKVccTHcPd2O4KAytvskRQLndFXv2hTwCYkUBYUPfCgnNtRWCbN1qla6+ch5ZrdgzlPjhtdBd5TF/RuU/PWOrPtlrgH4W0fDjP454X7TqxvSuP/RPdSK9bSo8I7LvxGmIekNatjqmSkqHjrtbpwEcdEpVi2Vd5P1BQK7F8S1/BcU4p6Pxws+epmr6DcUurp+nM2yeMZoV1KyMDPSnPTV5bziSDRfe2ltGVlC4dnWPsaivzKbj+PmELSb5uzMehs1m+bex44lEflj664e/MYw5c0a+6ktpAKBkPXPw+jFR78xSJtsyJVyb1SClAz/mQWJ07O/E4P/XJOOGhbrepAqlLnVZXqzP6o3p0yhEotvaP+C7vecNIiEEVE4yUV18TjBL4qbfkS/4FeWkDXDCtAB51T0tD+DjQCIr2a1iQ/Jd1kOj1Yt/maXXrpX01MpaPKAHxxUIy/O41Hw877lOBReRPrswPKE43NYP459N5vNGW X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199018)(36840700001)(40470700004)(46966006)(40460700003)(186003)(6286002)(6666004)(26005)(1076003)(36756003)(82310400005)(2616005)(336012)(47076005)(426003)(83380400001)(8936002)(5660300002)(8676002)(4326008)(6916009)(70586007)(70206006)(41300700001)(2906002)(966005)(55016003)(40480700001)(7696005)(478600001)(54906003)(316002)(36860700001)(82740400003)(7636003)(356005)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 06:11:48.1045 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a27409c-b892-40da-2c52-08db0d8930b6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT021.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7570 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series | compressdev: add LZ4 support | |
Message
Michael Baum
Feb. 13, 2023, 6:11 a.m. UTC
Add support for LZ4 compression algorithm for both API and app. In addition, enable app to test de/comp only. This option already exists in both app doc and arguments but isn't implemented inside the application. LZ4: https://github.com/lz4/lz4 RFC: https://patchwork.dpdk.org/project/dpdk/patch/20220410182622.8828-1-rzidane@nvidia.com/ v2: - Add macros for all LZ4 flags in the standard. - Rebase. v3: - Rebase. Michael Baum (4): compressdev: add LZ4 algorithm support app/test-compress-perf: allow test single compress operation app/test-compress-perf: add algo option app/test-compress-perf: add LZ4 support app/test-compress-perf/comp_perf_options.h | 9 +- .../comp_perf_options_parse.c | 83 +++++++++++- .../comp_perf_test_common.c | 126 +++++++++++++----- .../comp_perf_test_cyclecount.c | 82 +++++++----- .../comp_perf_test_throughput.c | 75 +++++++---- .../comp_perf_test_verify.c | 75 +++++++---- app/test-compress-perf/main.c | 63 +++++++-- doc/guides/compressdevs/features/default.ini | 7 + doc/guides/rel_notes/release_23_03.rst | 16 +++ doc/guides/tools/comp_perf.rst | 5 + lib/compressdev/rte_comp.c | 12 ++ lib/compressdev/rte_comp.h | 79 ++++++++++- 12 files changed, 488 insertions(+), 144 deletions(-)
Comments
Hi, The patchset only have library change and added performance tests. We shall have at least one PMD to support the added algorithms and unit test updated for the PMD/algorithms. Regards, Fan On 2/13/2023 6:11 AM, Michael Baum wrote: > Add support for LZ4 compression algorithm for both API and app. > > In addition, enable app to test de/comp only. This option already > exists in both app doc and arguments but isn't implemented inside the > application. > > LZ4: https://github.com/lz4/lz4 > RFC: > https://patchwork.dpdk.org/project/dpdk/patch/20220410182622.8828-1-rzidane@nvidia.com/ > > v2: > - Add macros for all LZ4 flags in the standard. > - Rebase. > > v3: > - Rebase. > > Michael Baum (4): > compressdev: add LZ4 algorithm support > app/test-compress-perf: allow test single compress operation > app/test-compress-perf: add algo option > app/test-compress-perf: add LZ4 support > > app/test-compress-perf/comp_perf_options.h | 9 +- > .../comp_perf_options_parse.c | 83 +++++++++++- > .../comp_perf_test_common.c | 126 +++++++++++++----- > .../comp_perf_test_cyclecount.c | 82 +++++++----- > .../comp_perf_test_throughput.c | 75 +++++++---- > .../comp_perf_test_verify.c | 75 +++++++---- > app/test-compress-perf/main.c | 63 +++++++-- > doc/guides/compressdevs/features/default.ini | 7 + > doc/guides/rel_notes/release_23_03.rst | 16 +++ > doc/guides/tools/comp_perf.rst | 5 + > lib/compressdev/rte_comp.c | 12 ++ > lib/compressdev/rte_comp.h | 79 ++++++++++- > 12 files changed, 488 insertions(+), 144 deletions(-) >
On 2/13/2023 17:47 PM, Zhang, Fan wrote: > Hi, > > The patchset only have library change and added performance tests. > > We shall have at least one PMD to support the added algorithms and unit test > updated for the PMD/algorithms. There is another patchset which adds it in MLX5 compress PMD: series-26766 ("compress/mlx5: add LZ4 support") https://patchwork.dpdk.org/project/dpdk/cover/20230202162537.1067595-1-michaelba@nvidia.com/ > > Regards, > > Fan > > On 2/13/2023 6:11 AM, Michael Baum wrote: > > Add support for LZ4 compression algorithm for both API and app. > > > > In addition, enable app to test de/comp only. This option already > > exists in both app doc and arguments but isn't implemented inside the > > application. > > > > LZ4: https://github.com/lz4/lz4 > > RFC: > > https://patchwork.dpdk.org/project/dpdk/patch/20220410182622.8828-1-rz > > idane@nvidia.com/ > > > > v2: > > - Add macros for all LZ4 flags in the standard. > > - Rebase. > > > > v3: > > - Rebase. > > > > Michael Baum (4): > > compressdev: add LZ4 algorithm support > > app/test-compress-perf: allow test single compress operation > > app/test-compress-perf: add algo option > > app/test-compress-perf: add LZ4 support > > > > app/test-compress-perf/comp_perf_options.h | 9 +- > > .../comp_perf_options_parse.c | 83 +++++++++++- > > .../comp_perf_test_common.c | 126 +++++++++++++----- > > .../comp_perf_test_cyclecount.c | 82 +++++++----- > > .../comp_perf_test_throughput.c | 75 +++++++---- > > .../comp_perf_test_verify.c | 75 +++++++---- > > app/test-compress-perf/main.c | 63 +++++++-- > > doc/guides/compressdevs/features/default.ini | 7 + > > doc/guides/rel_notes/release_23_03.rst | 16 +++ > > doc/guides/tools/comp_perf.rst | 5 + > > lib/compressdev/rte_comp.c | 12 ++ > > lib/compressdev/rte_comp.h | 79 ++++++++++- > > 12 files changed, 488 insertions(+), 144 deletions(-) > >