Message ID | cover.1675693844.git.gmuthukrishn@marvell.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24B2B41C12; Mon, 6 Feb 2023 15:46:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5DEA42B7E; Mon, 6 Feb 2023 15:46:15 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 7D04640FAE for <dev@dpdk.org>; Mon, 6 Feb 2023 15:46:14 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31680KFt005847; Mon, 6 Feb 2023 06:46:12 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=0T7l9PF2Q0b0IQ30+krw1yhZKhx/RT0dOe5/3+6Ot3s=; b=jBa5DmOmfgdP+NGYxzsUeqRPigZlcOFVtjmzl+xfQ5JnhaF0kOBivZ9y2LDCMfZrmHo9 4PXs0hfO9CBbTCmrqcWsFYzvQIiTyC/sCp3RDR8cbsa74WccbifBAdQUK3gKXDV6zM9f p3ZnoRLN+jlUXT4FQuLXxYiVaKXT/pN1Vk6IWeIAUv9WphCVncKhxM1J6CLRch6k9/2D 5gEQ4Pvm1Kh5EZvymIk/zwwi4dgPQZmwQNB+GsiK74OCnZ4lriMWEr2GWoGokOZQVY+h 8zyDidXjII6Hg5wdZuUPRm3M6QcN3FWrxYkyOw8KWhcyhCAltQGrKhppA2vob7FhKErB jg== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3nhqrtbkbv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 06 Feb 2023 06:46:12 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 6 Feb 2023 06:46:10 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend Transport; Mon, 6 Feb 2023 06:46:10 -0800 Received: from localhost.localdomain (unknown [10.28.34.38]) by maili.marvell.com (Postfix) with ESMTP id 45A5C3F7043; Mon, 6 Feb 2023 06:46:08 -0800 (PST) From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> To: <dev@dpdk.org> CC: Anoob Joseph <anoobj@marvell.com>, <jerinj@marvell.com>, Akhil Goyal <gakhil@marvell.com>, Brian Dooley <brian.dooley@intel.com>, "Gowrishankar Muthukrishnan" <gmuthukrishn@marvell.com> Subject: [v1, 00/10] fips_validation application improvements Date: Mon, 6 Feb 2023 20:15:52 +0530 Message-ID: <cover.1675693844.git.gmuthukrishn@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: 4kGfkpYGhQrxHeIGCjKMDQqinCXf0ayP X-Proofpoint-ORIG-GUID: 4kGfkpYGhQrxHeIGCjKMDQqinCXf0ayP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-06_07,2023-02-06_03,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
fips_validation application improvements
|
|
Message
Gowrishankar Muthukrishnan
Feb. 6, 2023, 2:45 p.m. UTC
This patch series adds support for SHA3, SHAKE, AES-CCM JSON test vectors and fixes existing algorithms to support NIST test vectors. Gowrishankar Muthukrishnan (10): examples/fips_validation: fix MCT output for SHA examples/fips_validation: add SHA3 validation examples/fips_validation: fix integer parse in test case examples/fips_validation: add SHAKE validation examples/fips_validation: add CCM JSON validation examples/fips_validation: add ECDSA keygen support examples/fips_validation: add SHA3 algorithms in ECDSA test examples/fips_validation: fix AES GCM validation tests examples/fips_validation: fix AES XTS to read seq number examples/fips_validation: add extra space in JSON buffer doc/guides/sample_app_ug/fips_validation.rst | 7 +- examples/fips_validation/fips_validation.c | 31 ++- examples/fips_validation/fips_validation.h | 10 +- .../fips_validation/fips_validation_ccm.c | 132 ++++++++++++ .../fips_validation/fips_validation_ecdsa.c | 56 +++++ .../fips_validation/fips_validation_gcm.c | 12 +- .../fips_validation/fips_validation_hmac.c | 8 + .../fips_validation/fips_validation_sha.c | 91 ++++++-- .../fips_validation/fips_validation_xts.c | 13 +- examples/fips_validation/main.c | 196 +++++++++++++----- 10 files changed, 467 insertions(+), 89 deletions(-)
Comments
Hi Gowrishankar, Looks good to me. > -----Original Message----- > From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph <anoobj@marvell.com>; jerinj@marvell.com; Akhil Goyal > <gakhil@marvell.com>; Dooley, Brian <brian.dooley@intel.com>; > Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> > Subject: [v1, 00/10] fips_validation application improvements > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON test vectors > and fixes existing algorithms to support NIST test vectors. > > Gowrishankar Muthukrishnan (10): > examples/fips_validation: fix MCT output for SHA > examples/fips_validation: add SHA3 validation > examples/fips_validation: fix integer parse in test case > examples/fips_validation: add SHAKE validation > examples/fips_validation: add CCM JSON validation > examples/fips_validation: add ECDSA keygen support > examples/fips_validation: add SHA3 algorithms in ECDSA test > examples/fips_validation: fix AES GCM validation tests > examples/fips_validation: fix AES XTS to read seq number > examples/fips_validation: add extra space in JSON buffer > > doc/guides/sample_app_ug/fips_validation.rst | 7 +- > examples/fips_validation/fips_validation.c | 31 ++- > examples/fips_validation/fips_validation.h | 10 +- > .../fips_validation/fips_validation_ccm.c | 132 ++++++++++++ > .../fips_validation/fips_validation_ecdsa.c | 56 +++++ > .../fips_validation/fips_validation_gcm.c | 12 +- > .../fips_validation/fips_validation_hmac.c | 8 + > .../fips_validation/fips_validation_sha.c | 91 ++++++-- > .../fips_validation/fips_validation_xts.c | 13 +- > examples/fips_validation/main.c | 196 +++++++++++++----- > 10 files changed, 467 insertions(+), 89 deletions(-) > > -- > 2.25.1 Series-acked-by: Brian Dooley <brian.dooley@intel.com>
> Hi Gowrishankar, > > Looks good to me. > > > Subject: [v1, 00/10] fips_validation application improvements > > > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON test vectors > > and fixes existing algorithms to support NIST test vectors. > > > > Gowrishankar Muthukrishnan (10): > > examples/fips_validation: fix MCT output for SHA > > examples/fips_validation: add SHA3 validation > > examples/fips_validation: fix integer parse in test case > > examples/fips_validation: add SHAKE validation > > examples/fips_validation: add CCM JSON validation > > examples/fips_validation: add ECDSA keygen support > > examples/fips_validation: add SHA3 algorithms in ECDSA test > > examples/fips_validation: fix AES GCM validation tests > > examples/fips_validation: fix AES XTS to read seq number > > examples/fips_validation: add extra space in JSON buffer > > > > doc/guides/sample_app_ug/fips_validation.rst | 7 +- > > examples/fips_validation/fips_validation.c | 31 ++- > > examples/fips_validation/fips_validation.h | 10 +- > > .../fips_validation/fips_validation_ccm.c | 132 ++++++++++++ > > .../fips_validation/fips_validation_ecdsa.c | 56 +++++ > > .../fips_validation/fips_validation_gcm.c | 12 +- > > .../fips_validation/fips_validation_hmac.c | 8 + > > .../fips_validation/fips_validation_sha.c | 91 ++++++-- > > .../fips_validation/fips_validation_xts.c | 13 +- > > examples/fips_validation/main.c | 196 +++++++++++++----- > > 10 files changed, 467 insertions(+), 89 deletions(-) > > > > -- > > 2.25.1 > > Series-acked-by: Brian Dooley <brian.dooley@intel.com> Series Applied to dpdk-next-crypto Thanks.
Hi Gowrishankar, > > > > > Subject: [v1, 00/10] fips_validation application improvements > > > > > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON test vectors > > > and fixes existing algorithms to support NIST test vectors. > > > > > > Gowrishankar Muthukrishnan (10): > > > examples/fips_validation: fix MCT output for SHA > > > examples/fips_validation: add SHA3 validation > > > examples/fips_validation: fix integer parse in test case > > > examples/fips_validation: add SHAKE validation > > > examples/fips_validation: add CCM JSON validation > > > examples/fips_validation: add ECDSA keygen support > > > examples/fips_validation: add SHA3 algorithms in ECDSA test > > > examples/fips_validation: fix AES GCM validation tests > > > examples/fips_validation: fix AES XTS to read seq number > > > examples/fips_validation: add extra space in JSON buffer > > > > > > doc/guides/sample_app_ug/fips_validation.rst | 7 +- > > > examples/fips_validation/fips_validation.c | 31 ++- > > > examples/fips_validation/fips_validation.h | 10 +- > > > .../fips_validation/fips_validation_ccm.c | 132 ++++++++++++ > > > .../fips_validation/fips_validation_ecdsa.c | 56 +++++ > > > .../fips_validation/fips_validation_gcm.c | 12 +- > > > .../fips_validation/fips_validation_hmac.c | 8 + > > > .../fips_validation/fips_validation_sha.c | 91 ++++++-- > > > .../fips_validation/fips_validation_xts.c | 13 +- > > > examples/fips_validation/main.c | 196 +++++++++++++----- > > > 10 files changed, 467 insertions(+), 89 deletions(-) > > > > > > -- > > > 2.25.1 > > > > Series-acked-by: Brian Dooley <brian.dooley@intel.com> > > Series Applied to dpdk-next-crypto The series is showing compilation issues, please fix it. The series is removed from the tree.
Hello Akhil and Gowrishankar, We saw the same issue with running the fips sample app under CI testing here at the UNH Community Lab: http://mails.dpdk.org/archives/test-report/2023-February/350635.html. We reported a warn because it failed on the compilation stage (as opposed to a failure of the actual sample app run). On the other hand, we are excited to see this patch again with the compilation part resolved. I sent an email to the dev mailing list a few weeks ago for our fips sample app CI testing regarding where we could and could not provide test vector coverage, and it appears this patch series may resolve our ciphertext issue with AES-GCM test vector and more issues with the sample app. So - looking forward to seeing a patch like this being merged when stable! Best, Patrick Robb On Tue, Feb 28, 2023 at 2:39 AM Akhil Goyal <gakhil@marvell.com> wrote: > Hi Gowrishankar, > > > > > > > Subject: [v1, 00/10] fips_validation application improvements > > > > > > > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON test > vectors > > > > and fixes existing algorithms to support NIST test vectors. > > > > > > > > Gowrishankar Muthukrishnan (10): > > > > examples/fips_validation: fix MCT output for SHA > > > > examples/fips_validation: add SHA3 validation > > > > examples/fips_validation: fix integer parse in test case > > > > examples/fips_validation: add SHAKE validation > > > > examples/fips_validation: add CCM JSON validation > > > > examples/fips_validation: add ECDSA keygen support > > > > examples/fips_validation: add SHA3 algorithms in ECDSA test > > > > examples/fips_validation: fix AES GCM validation tests > > > > examples/fips_validation: fix AES XTS to read seq number > > > > examples/fips_validation: add extra space in JSON buffer > > > > > > > > doc/guides/sample_app_ug/fips_validation.rst | 7 +- > > > > examples/fips_validation/fips_validation.c | 31 ++- > > > > examples/fips_validation/fips_validation.h | 10 +- > > > > .../fips_validation/fips_validation_ccm.c | 132 ++++++++++++ > > > > .../fips_validation/fips_validation_ecdsa.c | 56 +++++ > > > > .../fips_validation/fips_validation_gcm.c | 12 +- > > > > .../fips_validation/fips_validation_hmac.c | 8 + > > > > .../fips_validation/fips_validation_sha.c | 91 ++++++-- > > > > .../fips_validation/fips_validation_xts.c | 13 +- > > > > examples/fips_validation/main.c | 196 > +++++++++++++----- > > > > 10 files changed, 467 insertions(+), 89 deletions(-) > > > > > > > > -- > > > > 2.25.1 > > > > > > Series-acked-by: Brian Dooley <brian.dooley@intel.com> > > > > Series Applied to dpdk-next-crypto > The series is showing compilation issues, please fix it. The series is > removed from the tree. > > >
Hi Patrick, The issue reported by CI in below link is not an issue, as the patchset was dependent on another patch which is already merged. Now we are observing a new issue which is coming only on CentOS I believe. CI reports are not useful in case there are dependent patches. There should be a way maintainer/developer can retrigger the CI as required when other patches are merged. This issue got skipped as I personally do not test on CentOS and CI results are not meaningful when there were dependent patches. Below is the log for the compilation issue observed now on TOT when these patches are applied which is not visible in the below link. > OS: CentOS79-64 > Target: x86_64-native-linuxapp-gcc > FAILED: examples/dpdk-fips_validation.p/fips_validation_main.c.o > gcc -Iexamples/dpdk-fips_validation.p -Iexamples -I../examples - > Iexamples/fips_validation -I../examples/fips_validation -I../examples/common - > I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include - > Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include - > I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal > -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry - > I../lib/telemetry -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/net - > I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/ethdev -I../lib/ethdev -Ilib/meter - > I../lib/meter -Ilib/cmdline -I../lib/cmdline -Ilib/cryptodev -I../lib/cryptodev - > Ilib/rcu -I../lib/rcu -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra - > Werror -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat - > Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing- > prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign- > compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field- > initializers -D_GNU_SOURCE -march=native -DUSE_OPENSSL - > DALLOW_EXPERIMENTAL_API -MD -MQ examples/dpdk- > fips_validation.p/fips_validation_main.c.o -MF examples/dpdk- > fips_validation.p/fips_validation_main.c.o.d -o examples/dpdk- > fips_validation.p/fips_validation_main.c.o -c ../examples/fips_validation/main.c > ../examples/fips_validation/main.c: In function 'fips_mct_shake_test': > ../examples/fips_validation/main.c:2438:5: error: dereferencing type-punned > pointer will break strict-aliasing rules [-Werror=strict-aliasing] > (*(uint16_t *)rightmost % range); > ^ Regards, Akhil
Hi Akhil, One 2023 goal for UNH is implementing an email based retesting framework. Once that work is completed, you will be able to trigger a retest yourself under circumstances where waiting for dependent patches is needed. On Tue, Feb 28, 2023 at 10:02 AM Akhil Goyal <gakhil@marvell.com> wrote: > Hi Patrick, > > > > The issue reported by CI in below link is not an issue, as the patchset > was dependent on another patch which is already merged. Now we are > observing a new issue which is coming only on CentOS I believe. > > CI reports are not useful in case there are dependent patches. There > should be a way maintainer/developer can retrigger the CI as required when > other patches are merged. > > > > This issue got skipped as I personally do not test on CentOS and CI > results are not meaningful when there were dependent patches. > > Below is the log for the compilation issue observed now on TOT when these > patches are applied which is not visible in the below link. > > > > > OS: CentOS79-64 > > > Target: x86_64-native-linuxapp-gcc > > > FAILED: examples/dpdk-fips_validation.p/fips_validation_main.c.o > > > gcc -Iexamples/dpdk-fips_validation.p -Iexamples -I../examples - > > > Iexamples/fips_validation -I../examples/fips_validation > -I../examples/common - > > > I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include - > > > Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include - > > > I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal > -I../lib/eal > > > -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics > -Ilib/telemetry - > > > I../lib/telemetry -Ilib/mempool -I../lib/mempool -Ilib/ring > -I../lib/ring -Ilib/net - > > > I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/ethdev -I../lib/ethdev > -Ilib/meter - > > > I../lib/meter -Ilib/cmdline -I../lib/cmdline -Ilib/cryptodev > -I../lib/cryptodev - > > > Ilib/rcu -I../lib/rcu -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra > - > > > Werror -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat - > > > Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing- > > > prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith > -Wsign- > > > compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field- > > > initializers -D_GNU_SOURCE -march=native -DUSE_OPENSSL - > > > DALLOW_EXPERIMENTAL_API -MD -MQ examples/dpdk- > > > fips_validation.p/fips_validation_main.c.o -MF examples/dpdk- > > > fips_validation.p/fips_validation_main.c.o.d -o examples/dpdk- > > > fips_validation.p/fips_validation_main.c.o -c > ../examples/fips_validation/main.c > > > ../examples/fips_validation/main.c: In function 'fips_mct_shake_test': > > > ../examples/fips_validation/main.c:2438:5: error: dereferencing > type-punned > > > pointer will break strict-aliasing rules [-Werror=strict-aliasing] > > > (*(uint16_t *)rightmost % range); > > > ^ > > > > > > Regards, > > Akhil > > > ------------------------------ > > Hello Akhil and Gowrishankar, > > > > We saw the same issue with running the fips sample app under CI testing > here at the UNH Community Lab: > http://mails.dpdk.org/archives/test-report/2023-February/350635.html > <https://urldefense.proofpoint.com/v2/url?u=http-3A__mails.dpdk.org_archives_test-2Dreport_2023-2DFebruary_350635.html&d=DwMFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=QswegPR1LvDRH4f_2rvo_BvAfrFOBGZPVPGXC7pPlKn2Q99LMoJlfwv4ZZ0QxRu-&s=Ozm6byIlAfWxebW0mSomWcCW-0s59wZNJ7QED4-Tjcs&e=>. > We reported a warn because it failed on the compilation stage (as opposed > to a failure of the actual sample app run). > > > > On the other hand, we are excited to see this patch again with the > compilation part resolved. I sent an email to the dev mailing list a few > weeks ago for our fips sample app CI testing regarding where we could and > could not provide test vector coverage, and it appears this patch series > may resolve our ciphertext issue with AES-GCM test vector and more issues > with the sample app. So - looking forward to seeing a patch like this being > merged when stable! > > > > Best, > > Patrick Robb > > > > > > > > > > On Tue, Feb 28, 2023 at 2:39 AM Akhil Goyal <gakhil@marvell.com> wrote: > > Hi Gowrishankar, > > > > > > > Subject: [v1, 00/10] fips_validation application improvements > > > > > > > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON test > vectors > > > > and fixes existing algorithms to support NIST test vectors. > > > > > > > > Gowrishankar Muthukrishnan (10): > > > > examples/fips_validation: fix MCT output for SHA > > > > examples/fips_validation: add SHA3 validation > > > > examples/fips_validation: fix integer parse in test case > > > > examples/fips_validation: add SHAKE validation > > > > examples/fips_validation: add CCM JSON validation > > > > examples/fips_validation: add ECDSA keygen support > > > > examples/fips_validation: add SHA3 algorithms in ECDSA test > > > > examples/fips_validation: fix AES GCM validation tests > > > > examples/fips_validation: fix AES XTS to read seq number > > > > examples/fips_validation: add extra space in JSON buffer > > > > > > > > doc/guides/sample_app_ug/fips_validation.rst | 7 +- > > > > examples/fips_validation/fips_validation.c | 31 ++- > > > > examples/fips_validation/fips_validation.h | 10 +- > > > > .../fips_validation/fips_validation_ccm.c | 132 ++++++++++++ > > > > .../fips_validation/fips_validation_ecdsa.c | 56 +++++ > > > > .../fips_validation/fips_validation_gcm.c | 12 +- > > > > .../fips_validation/fips_validation_hmac.c | 8 + > > > > .../fips_validation/fips_validation_sha.c | 91 ++++++-- > > > > .../fips_validation/fips_validation_xts.c | 13 +- > > > > examples/fips_validation/main.c | 196 > +++++++++++++----- > > > > 10 files changed, 467 insertions(+), 89 deletions(-) > > > > > > > > -- > > > > 2.25.1 > > > > > > Series-acked-by: Brian Dooley <brian.dooley@intel.com> > > > > Series Applied to dpdk-next-crypto > The series is showing compilation issues, please fix it. The series is > removed from the tree. > > > > > -- > > Patrick Robb > > Technical Service Manager > > UNH InterOperability Laboratory > > 21 Madbury Rd, Suite 100, Durham, NH 03824 > > www.iol.unh.edu > <https://urldefense.proofpoint.com/v2/url?u=http-3A__www.iol.unh.edu_&d=DwMFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=QswegPR1LvDRH4f_2rvo_BvAfrFOBGZPVPGXC7pPlKn2Q99LMoJlfwv4ZZ0QxRu-&s=Gr4qCfskeNAMKr2DcgjPKd30D2zh9SGznw6lTmy1FnA&e=> > > > >
I have fixed it in v2 and CI passed. http://mails.dpdk.org/archives/test-report/2023-February/360464.html Thanks, Gowrishankar > -----Original Message----- > From: Akhil Goyal <gakhil@marvell.com> > Sent: Tuesday, February 28, 2023 1:09 PM > To: Akhil Goyal <gakhil@marvell.com>; Dooley, Brian > <brian.dooley@intel.com>; Gowrishankar Muthukrishnan > <gmuthukrishn@marvell.com>; dev@dpdk.org > Cc: Anoob Joseph <anoobj@marvell.com>; Jerin Jacob Kollanukkaran > <jerinj@marvell.com> > Subject: RE: [v1, 00/10] fips_validation application improvements > > Hi Gowrishankar, > > > > > > > Subject: [v1, 00/10] fips_validation application improvements > > > > > > > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON test > > > > vectors and fixes existing algorithms to support NIST test vectors. > > > > > > > > Gowrishankar Muthukrishnan (10): > > > > examples/fips_validation: fix MCT output for SHA > > > > examples/fips_validation: add SHA3 validation > > > > examples/fips_validation: fix integer parse in test case > > > > examples/fips_validation: add SHAKE validation > > > > examples/fips_validation: add CCM JSON validation > > > > examples/fips_validation: add ECDSA keygen support > > > > examples/fips_validation: add SHA3 algorithms in ECDSA test > > > > examples/fips_validation: fix AES GCM validation tests > > > > examples/fips_validation: fix AES XTS to read seq number > > > > examples/fips_validation: add extra space in JSON buffer > > > > > > > > doc/guides/sample_app_ug/fips_validation.rst | 7 +- > > > > examples/fips_validation/fips_validation.c | 31 ++- > > > > examples/fips_validation/fips_validation.h | 10 +- > > > > .../fips_validation/fips_validation_ccm.c | 132 ++++++++++++ > > > > .../fips_validation/fips_validation_ecdsa.c | 56 +++++ > > > > .../fips_validation/fips_validation_gcm.c | 12 +- > > > > .../fips_validation/fips_validation_hmac.c | 8 + > > > > .../fips_validation/fips_validation_sha.c | 91 ++++++-- > > > > .../fips_validation/fips_validation_xts.c | 13 +- > > > > examples/fips_validation/main.c | 196 +++++++++++++----- > > > > 10 files changed, 467 insertions(+), 89 deletions(-) > > > > > > > > -- > > > > 2.25.1 > > > > > > Series-acked-by: Brian Dooley <brian.dooley@intel.com> > > > > Series Applied to dpdk-next-crypto > The series is showing compilation issues, please fix it. The series is removed > from the tree. >