[V1] tests/shutdown_api: modify the command to adapt to the changes in ethtool
Checks
Context |
Check |
Description |
ci/Intel-dts-format-test |
success
|
Testing OK
|
ci/Intel-dts-pylama-test |
success
|
Testing OK
|
ci/Intel-dts-suite-test |
success
|
Testing OK
|
Commit Message
The ethtool after version 5.4 does not support changing the network card speed
when automatic negotiation is turned off. therefore, rm 'autoneg off' in script.
Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
tests/TestSuite_shutdown_api.py | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
Comments
> -----Original Message-----
> From: Song Jiale <songx.jiale@intel.com>
> Sent: Monday, January 16, 2023 11:00 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/shutdown_api: modify the command to adapt to
> the changes in ethtool
>
> The ethtool after version 5.4 does not support changing the network card speed
> when automatic negotiation is turned off. therefore, rm 'autoneg off' in script.
Compatibility is very important.
On Mon, 16 Jan 2023 15:00:02 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> The ethtool after version 5.4 does not support changing the network card speed
> when automatic negotiation is turned off. therefore, rm 'autoneg off' in script.
>
>
> Signed-off-by: Song Jiale <songx.jiale@intel.com>
Applied, thanks
@@ -320,11 +320,6 @@ class TestShutdownApi(TestCase):
self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
self.used_dut_port = None
- for port in self.ports:
- self.dut.send_expect(
- "ethtool -s %s autoneg on " % self.dut.ports_info[port]["intf"], "#"
- )
-
self.bind_nic_driver(self.dut_ports, driver=self.used_driver or self.drivername)
if not self.vm_env_done:
@@ -629,7 +624,7 @@ class TestShutdownApi(TestCase):
for port in self.ports:
if len(configs) != 1:
self.dut.send_expect(
- "ethtool -s %s autoneg off speed %s duplex %s"
+ "ethtool -s %s speed %s duplex %s"
% (
self.dut.ports_info[port]["intf"],
config[0],