diff mbox series

net/mlx5: fix build with GCC 12 and ASan

Message ID 20230309090317.847742-1-david.marchand@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx5: fix build with GCC 12 and ASan |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing fail Testing issues
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

David Marchand March 9, 2023, 9:03 a.m. UTC 
  Building with gcc 12 and ASan raises this warning:

../drivers/net/mlx5/mlx5_txpp.c: In function ‘mlx5_txpp_xstats_get_names’:
../drivers/net/mlx5/mlx5_txpp.c:1066:25: error: ‘strncpy’ specified bound
	64 equals destination size [-Werror=stringop-truncation]
 1066 |                         strncpy(xstats_names[i + n_used].name,
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1067 |                                 mlx5_txpp_stat_names[i],
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~~
 1068 |                                 RTE_ETH_XSTATS_NAME_SIZE);
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Prefer strlcpy.

Fixes: 3b025c0ca425 ("net/mlx5: provide send scheduling error statistics")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/mlx5/mlx5_txpp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

David Marchand March 14, 2023, 9:02 a.m. UTC | #1 
On Thu, Mar 9, 2023 at 10:03 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> Building with gcc 12 and ASan raises this warning:
>
> ../drivers/net/mlx5/mlx5_txpp.c: In function ‘mlx5_txpp_xstats_get_names’:
> ../drivers/net/mlx5/mlx5_txpp.c:1066:25: error: ‘strncpy’ specified bound
>         64 equals destination size [-Werror=stringop-truncation]
>  1066 |                         strncpy(xstats_names[i + n_used].name,
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  1067 |                                 mlx5_txpp_stat_names[i],
>       |                                 ~~~~~~~~~~~~~~~~~~~~~~~~
>  1068 |                                 RTE_ETH_XSTATS_NAME_SIZE);
>       |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Prefer strlcpy.
>
> Fixes: 3b025c0ca425 ("net/mlx5: provide send scheduling error statistics")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Review please?
Slava Ovsiienko March 14, 2023, 1 p.m. UTC | #2 
Hi, David

Thank you for the fix.
I see the quite similar strncpy() usage in mlx5_xstats_get_names() routine.
Does compiler complain about?

With best regards,
Slava

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: четверг, 9 марта 2023 г. 11:03
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Subject: [PATCH] net/mlx5: fix build with GCC 12 and ASan
> 
> Building with gcc 12 and ASan raises this warning:
> 
> ../drivers/net/mlx5/mlx5_txpp.c: In function ‘mlx5_txpp_xstats_get_names’:
> ../drivers/net/mlx5/mlx5_txpp.c:1066:25: error: ‘strncpy’ specified bound
> 	64 equals destination size [-Werror=stringop-truncation]
>  1066 |                         strncpy(xstats_names[i + n_used].name,
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  1067 |                                 mlx5_txpp_stat_names[i],
>       |                                 ~~~~~~~~~~~~~~~~~~~~~~~~
>  1068 |                                 RTE_ETH_XSTATS_NAME_SIZE);
>       |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Prefer strlcpy.
> 
> Fixes: 3b025c0ca425 ("net/mlx5: provide send scheduling error statistics")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/mlx5/mlx5_txpp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c
> index 63d98dbde9..0e1da1d5f5 100644
> --- a/drivers/net/mlx5/mlx5_txpp.c
> +++ b/drivers/net/mlx5/mlx5_txpp.c
> @@ -1063,11 +1063,9 @@ int mlx5_txpp_xstats_get_names(struct
> rte_eth_dev *dev __rte_unused,
> 
>  	if (n >= n_used + n_txpp && xstats_names) {
>  		for (i = 0; i < n_txpp; ++i) {
> -			strncpy(xstats_names[i + n_used].name,
> +			strlcpy(xstats_names[i + n_used].name,
>  				mlx5_txpp_stat_names[i],
>  				RTE_ETH_XSTATS_NAME_SIZE);
> -			xstats_names[i + n_used].name
> -					[RTE_ETH_XSTATS_NAME_SIZE - 1] =
> 0;
>  		}
>  	}
>  	return n_used + n_txpp;
> --
> 2.39.2
David Marchand March 15, 2023, 10:05 a.m. UTC | #3 
On Tue, Mar 14, 2023 at 2:00 PM Slava Ovsiienko <viacheslavo@nvidia.com> wrote:
>
> Hi, David
>
> Thank you for the fix.
> I see the quite similar strncpy() usage in mlx5_xstats_get_names() routine.
> Does compiler complain about?

Strangely.. no.
But we could switch to strlcpy too.
What is your preferrence?
Slava Ovsiienko March 15, 2023, 12:08 p.m. UTC | #4 
Hi, 

I would prefer to fix both.

With best regards,
Slava

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: среда, 15 марта 2023 г. 12:05
> To: Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Matan Azrad <matan@nvidia.com>
> Subject: Re: [PATCH] net/mlx5: fix build with GCC 12 and ASan
> 
> On Tue, Mar 14, 2023 at 2:00 PM Slava Ovsiienko <viacheslavo@nvidia.com>
> wrote:
> >
> > Hi, David
> >
> > Thank you for the fix.
> > I see the quite similar strncpy() usage in mlx5_xstats_get_names() routine.
> > Does compiler complain about?
> 
> Strangely.. no.
> But we could switch to strlcpy too.
> What is your preferrence?
> 
> 
> --
> David Marchand
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c
index 63d98dbde9..0e1da1d5f5 100644
--- a/drivers/net/mlx5/mlx5_txpp.c
+++ b/drivers/net/mlx5/mlx5_txpp.c
@@ -1063,11 +1063,9 @@  int mlx5_txpp_xstats_get_names(struct rte_eth_dev *dev __rte_unused,
 
 	if (n >= n_used + n_txpp && xstats_names) {
 		for (i = 0; i < n_txpp; ++i) {
-			strncpy(xstats_names[i + n_used].name,
+			strlcpy(xstats_names[i + n_used].name,
 				mlx5_txpp_stat_names[i],
 				RTE_ETH_XSTATS_NAME_SIZE);
-			xstats_names[i + n_used].name
-					[RTE_ETH_XSTATS_NAME_SIZE - 1] = 0;
 		}
 	}
 	return n_used + n_txpp;