[v2] net/iavf: fix Tx offloading flags check
Checks
Commit Message
Relax the check in the previous fix to allow packets
with security offload flag set.
Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading")
Cc: stable@dpdk.org
Cc: david.marchand@redhat.com
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
v2: extend the check for only TX_SEC_OFFLOAD
drivers/net/iavf/iavf_rxtx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Wed, Oct 25, 2023 at 11:13 AM Radu Nicolau <radu.nicolau@intel.com> wrote:
>
> Relax the check in the previous fix to allow packets
> with security offload flag set.
>
> Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading")
> Cc: stable@dpdk.org
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Thursday, October 26, 2023 4:08 PM
> To: Nicolau, Radu <radu.nicolau@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> dev@dpdk.org; stable@dpdk.org
> Subject: Re: [PATCH v2] net/iavf: fix Tx offloading flags check
>
> On Wed, Oct 25, 2023 at 11:13 AM Radu Nicolau <radu.nicolau@intel.com>
> wrote:
> >
> > Relax the check in the previous fix to allow packets with security
> > offload flag set.
> >
> > Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>
> Acked-by: David Marchand <david.marchand@redhat.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
>
>
> --
> David Marchand
@@ -2664,7 +2664,8 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,
l2tag1 |= m->vlan_tci;
}
- if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) == 0)
+ if ((m->ol_flags &
+ (IAVF_TX_CKSUM_OFFLOAD_MASK | RTE_MBUF_F_TX_SEC_OFFLOAD)) == 0)
goto skip_cksum;
/* Set MACLEN */