test/dma: fix api testuite teardown
Checks
Commit Message
The API testsuite previously only used the dmadev skeleton. Now that real
devices are being used for the API tests, the DMA stats need to be reset
during testsuite teardown to ensure a known, clean state before continuing.
Fixes: 14b477ed1740 ("test/dma: use unit test framework")
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
app/test/test_dmadev_api.c | 1 +
1 file changed, 1 insertion(+)
Comments
It's not a bugfix, but a best practice for test (clean state before continuing).
The other is LGTM,
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2024/3/11 23:25, Kevin Laatz wrote:
> The API testsuite previously only used the dmadev skeleton. Now that real
> devices are being used for the API tests, the DMA stats need to be reset
> during testsuite teardown to ensure a known, clean state before continuing.
>
> Fixes: 14b477ed1740 ("test/dma: use unit test framework")
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
> app/test/test_dmadev_api.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test/test_dmadev_api.c b/app/test/test_dmadev_api.c
> index a130e74b51..d40c05cfbf 100644
> --- a/app/test/test_dmadev_api.c
> +++ b/app/test/test_dmadev_api.c
> @@ -82,6 +82,7 @@ testsuite_teardown(void)
> dst = NULL;
> /* Ensure the dmadev is stopped. */
> rte_dma_stop(test_dev_id);
> + rte_dma_stats_reset(test_dev_id, RTE_DMA_ALL_VCHAN);
>
> rte_log_set_level_pattern("lib.dmadev", RTE_LOG_INFO);
> }
>
12/03/2024 02:29, fengchengwen:
> It's not a bugfix, but a best practice for test (clean state before continuing).
>
> The other is LGTM,
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
>
>
> On 2024/3/11 23:25, Kevin Laatz wrote:
> > The API testsuite previously only used the dmadev skeleton. Now that real
> > devices are being used for the API tests, the DMA stats need to be reset
> > during testsuite teardown to ensure a known, clean state before continuing.
> >
> > Fixes: 14b477ed1740 ("test/dma: use unit test framework")
> >
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Applied, thanks.
@@ -82,6 +82,7 @@ testsuite_teardown(void)
dst = NULL;
/* Ensure the dmadev is stopped. */
rte_dma_stop(test_dev_id);
+ rte_dma_stats_reset(test_dev_id, RTE_DMA_ALL_VCHAN);
rte_log_set_level_pattern("lib.dmadev", RTE_LOG_INFO);
}