Message ID | 1470311406-38841-1-git-send-email-iryzhov@nfware.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id C65B037A4; Thu, 4 Aug 2016 13:50:15 +0200 (CEST) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id 6186F1DB1 for <dev@dpdk.org>; Thu, 4 Aug 2016 13:50:14 +0200 (CEST) Received: by mail-lf0-f65.google.com with SMTP id l89so14651389lfi.2 for <dev@dpdk.org>; Thu, 04 Aug 2016 04:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=4fa5kozFhAWvpEhaCrvRKQuYsCLs7sENBvQ72Jk3bHI=; b=Y/93hoPGo2/3glA3FWuoBIg8t7gUS6FqVXhWNRrT94WcUy7TXNfgwkyCu2t2frrV/+ MGwpNdkLVt36ee38935ekiiJQuTgN4yXE8z8Eg+WIap59ws4MCNA3Z+SqfF1tQAaxySW 5A5oUJ4aTrKEPYt/exG3wS0aUxSxg/0L9D9LrKNB3Dez0kmy3j6wfzPB+QIa0umvSK8S LCab+pM5ctLsTiSBSBDVRjrb2ySUpBifPXRbhXdeWss/arDwUEJy4aOfN/l50m5FOPvn K+Z+4c5inTWGKsNpX08fhd4KqUHHvwIfj8bwWpvoMv0MqomWUw3DsTc/No27eUQGtLAW vMLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=4fa5kozFhAWvpEhaCrvRKQuYsCLs7sENBvQ72Jk3bHI=; b=BbAmDs0DzapT06ROmI+2pwgXyvFpItzZTXPzdXrJLx/UJx53Hsn2whbi4MoSSEiNLS BoK57IKx7a6tk5mtsYivBJfizhnP4CEfBYIUtE1qLkoTtDQzxlwLdzjdEEVCYOmBuxCO XxEx0QMyParRZaGXea7txxzkjJWMviu2R+OxtpK4Ov/xm/itYxCBce3Vp5K+mv06Lb1Z F87bTDKUppUOx+LqTeYhcs9o2m0CAutDGAk+8eITghBSrUoXx3rurnwe+edvUok8/J7d s2086tSkSixB906vC+hud800zgu2zwgeb5ZO8Lig58pJE7NdtpDfQPrZfI7BpqFbTLOH QTHg== X-Gm-Message-State: AEkoousInIrUREF2PKDVJ+5pu+Iuu5GInwPikEw/aa88pQSKFisd02Zg7+3Kd97E++3G3g== X-Received: by 10.25.33.130 with SMTP id h124mr12836766lfh.47.1470311413540; Thu, 04 Aug 2016 04:50:13 -0700 (PDT) Received: from localhost.localdomain (vpn.arccn.ru. [95.182.74.2]) by smtp.gmail.com with ESMTPSA id 21sm2388005ljf.7.2016.08.04.04.50.12 for <dev@dpdk.org> (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 04 Aug 2016 04:50:12 -0700 (PDT) From: Igor Ryzhov <iryzhov@nfware.com> To: dev@dpdk.org Date: Thu, 4 Aug 2016 14:50:06 +0300 Message-Id: <1470311406-38841-1-git-send-email-iryzhov@nfware.com> X-Mailer: git-send-email 2.6.4 Subject: [dpdk-dev] [PATCH] pci: fix one device probing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Igor Ryzhov
Aug. 4, 2016, 11:50 a.m. UTC
The rte_eal_pci_probe_one function could return false positive result if
no driver is found for the device.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
---
lib/librte_eal/common/eal_common_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
2016-08-04 14:50, Igor Ryzhov: > The rte_eal_pci_probe_one function could return false positive result if > no driver is found for the device. > > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com> [...] > --- a/lib/librte_eal/common/eal_common_pci.c > +++ b/lib/librte_eal/common/eal_common_pci.c > @@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr) > continue; > > ret = pci_probe_all_drivers(dev); > - if (ret < 0) > + if (ret) > goto err_return; > return 0; > } This patch was discussed in another thread: http://dpdk.org/ml/archives/dev/2016-August/045127.html Is there anyone thinking this patch is not a step forward?
On Thu, Aug 4, 2016 at 1:50 PM, Igor Ryzhov <iryzhov@nfware.com> wrote: > The rte_eal_pci_probe_one function could return false positive result if > no driver is found for the device. > > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com> > --- > lib/librte_eal/common/eal_common_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c > index 7248c38..bfb6fd2 100644 > --- a/lib/librte_eal/common/eal_common_pci.c > +++ b/lib/librte_eal/common/eal_common_pci.c > @@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr) > continue; > > ret = pci_probe_all_drivers(dev); > - if (ret < 0) > + if (ret) > goto err_return; > return 0; > } Acked-by: David Marchand <david.marchand@6wind.com>
2016-11-07 14:26, David Marchand: > On Thu, Aug 4, 2016 at 1:50 PM, Igor Ryzhov <iryzhov@nfware.com> wrote: > > The rte_eal_pci_probe_one function could return false positive result if > > no driver is found for the device. > > > > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com> > > Acked-by: David Marchand <david.marchand@6wind.com> Applied, thanks
diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 7248c38..bfb6fd2 100644 --- a/lib/librte_eal/common/eal_common_pci.c +++ b/lib/librte_eal/common/eal_common_pci.c @@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr) continue; ret = pci_probe_all_drivers(dev); - if (ret < 0) + if (ret) goto err_return; return 0; }