[dpdk-dev] ethtool: disable promiscuous mode by default
Checks
Commit Message
Disable promiscuous mode by default since VLAN filter
does not work when promiscuous mode is enabled.
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
examples/ethtool/ethtool-app/main.c | 1 -
1 file changed, 1 deletion(-)
Comments
Probably ought to also add a new command so that promiscuous mode can be
enabled if needed.
On 12/04/2017 20:58, Qi Zhang wrote:
> Disable promiscuous mode by default since VLAN filter
> does not work when promiscuous mode is enabled.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> examples/ethtool/ethtool-app/main.c | 1 -
> 1 file changed, 1 deletion(-)
Acked-by: Remy Horton <remy.horton@intel.com>
18/04/2017 16:26, Remy Horton:
> Probably ought to also add a new command so that promiscuous mode can be
> enabled if needed.
>
> On 12/04/2017 20:58, Qi Zhang wrote:
> > Disable promiscuous mode by default since VLAN filter
> > does not work when promiscuous mode is enabled.
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> >
> > examples/ethtool/ethtool-app/main.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Acked-by: Remy Horton <remy.horton@intel.com>
Applied, thanks
@@ -172,7 +172,6 @@ static void setup_ports(struct app_config *app_cfg, int cnt_ports)
"%s:%i: rte_eth_dev_start failed",
__FILE__, __LINE__
);
- rte_eth_promiscuous_enable(idx_port);
rte_eth_macaddr_get(idx_port, &ptr_port->mac_addr);
rte_spinlock_init(&ptr_port->lock);
}