[dpdk-dev] net/bnxt: fix compilation
Checks
Commit Message
As of 5ef3b79fdfe6f, compilation of DPDK fails with the following
error message:
"bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
function [-Werror=maybe-uninitialized]".
Resolve this by initializing 'vnic' to NULL;
Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")
CC: stable@dpdk.org
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
---
drivers/net/bnxt/bnxt_filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Mark
> Kavanagh
> Sent: Monday, October 9, 2017 3:00 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
> ajit.khaparde@broadcom.com; Kavanagh, Mark B
> <mark.b.kavanagh@intel.com>
> Subject: [dpdk-stable] [PATCH] net/bnxt: fix compilation
>
> As of 5ef3b79fdfe6f, compilation of DPDK fails with the following error
> message:
> "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]".
>
> Resolve this by initializing 'vnic' to NULL;
>
> Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")
> CC: stable@dpdk.org
Hi Mark,
You don't need to cc stable, since you are fixing code that was sent in this release.
Only fixes for patches sent in previous DPDK versions need to be applied to the stable repo.
Regards,
Pablo
>From: De Lara Guarch, Pablo
>Sent: Monday, October 9, 2017 3:15 PM
>To: Kavanagh, Mark B <mark.b.kavanagh@intel.com>; dev@dpdk.org
>Cc: stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
>ajit.khaparde@broadcom.com; Kavanagh, Mark B <mark.b.kavanagh@intel.com>
>Subject: RE: [dpdk-stable] [PATCH] net/bnxt: fix compilation
>
>
>
>> -----Original Message-----
>> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Mark
>> Kavanagh
>> Sent: Monday, October 9, 2017 3:00 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> ajit.khaparde@broadcom.com; Kavanagh, Mark B
>> <mark.b.kavanagh@intel.com>
>> Subject: [dpdk-stable] [PATCH] net/bnxt: fix compilation
>>
>> As of 5ef3b79fdfe6f, compilation of DPDK fails with the following error
>> message:
>> "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
>> function [-Werror=maybe-uninitialized]".
>>
>> Resolve this by initializing 'vnic' to NULL;
>>
>> Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")
>> CC: stable@dpdk.org
>
>Hi Mark,
>
>You don't need to cc stable, since you are fixing code that was sent in this
>release.
>Only fixes for patches sent in previous DPDK versions need to be applied to
>the stable repo.
Thanks for the clarification Pablo - makes sense.
Removing stable@dpdk.org from this thread.
Cheers,
Mark
>
>Regards,
>Pablo
On 10/9/2017 2:59 PM, Mark Kavanagh wrote:
> As of 5ef3b79fdfe6f, compilation of DPDK fails with the following
> error message:
> "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]".
>
> Resolve this by initializing 'vnic' to NULL;
>
> Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")
>
> Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
Applied to dpdk-next-net/master, thanks.
Can you please provide compiler and version information?
I get the commit for now and will update it later with that information.
>From: Yigit, Ferruh
>Sent: Monday, October 9, 2017 6:34 PM
>To: Kavanagh, Mark B <mark.b.kavanagh@intel.com>; dev@dpdk.org
>Cc: ajit.khaparde@broadcom.com
>Subject: Re: [PATCH] net/bnxt: fix compilation
>
>On 10/9/2017 2:59 PM, Mark Kavanagh wrote:
>> As of 5ef3b79fdfe6f, compilation of DPDK fails with the following
>> error message:
>> "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
>> function [-Werror=maybe-uninitialized]".
>>
>> Resolve this by initializing 'vnic' to NULL;
>>
>> Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")
>
>>
>> Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
>
>Applied to dpdk-next-net/master, thanks.
>
>Can you please provide compiler and version information?
>I get the commit for now and will update it later with that information.
Thanks Ferruh - compiler info is as follows:
gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
Best,
Mark
On 10/10/2017 8:40 AM, Kavanagh, Mark B wrote:
>> From: Yigit, Ferruh
>> Sent: Monday, October 9, 2017 6:34 PM
>> To: Kavanagh, Mark B <mark.b.kavanagh@intel.com>; dev@dpdk.org
>> Cc: ajit.khaparde@broadcom.com
>> Subject: Re: [PATCH] net/bnxt: fix compilation
>>
>> On 10/9/2017 2:59 PM, Mark Kavanagh wrote:
>>> As of 5ef3b79fdfe6f, compilation of DPDK fails with the following
>>> error message:
>>> "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
>>> function [-Werror=maybe-uninitialized]".
>>>
>>> Resolve this by initializing 'vnic' to NULL;
>>>
>>> Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")
>>
>>>
>>> Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
>>
>> Applied to dpdk-next-net/master, thanks.
>>
>> Can you please provide compiler and version information?
>> I get the commit for now and will update it later with that information.
>
> Thanks Ferruh - compiler info is as follows:
>
> gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
Updated commit log, thanks.
@@ -906,7 +906,7 @@ struct bnxt_filter_info *
{
struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
struct bnxt_filter_info *filter;
- struct bnxt_vnic_info *vnic;
+ struct bnxt_vnic_info *vnic = NULL;
struct rte_flow *flow;
unsigned int i;
int ret = 0;