| Message ID | 20171012130726.4332-3-alok.makhariya@nxp.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Pablo de Lara Guarch |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 45CA31B2F8; Thu, 12 Oct 2017 15:10:40 +0200 (CEST) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0071.outbound.protection.outlook.com [104.47.42.71]) by dpdk.org (Postfix) with ESMTP id 067071B2DC for <dev@dpdk.org>; Thu, 12 Oct 2017 15:10:37 +0200 (CEST) Received: from BN3PR03CA0084.namprd03.prod.outlook.com (10.167.1.172) by BN3PR03MB2356.namprd03.prod.outlook.com (10.166.74.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 12 Oct 2017 13:10:36 +0000 Received: from BY2FFO11OLC014.protection.gbl (2a01:111:f400:7c0c::102) by BN3PR03CA0084.outlook.office365.com (2a01:111:e400:7a4d::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10 via Frontend Transport; Thu, 12 Oct 2017 13:10:36 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; NXP1.onmicrosoft.com; dkim=none (message not signed) header.d=none;NXP1.onmicrosoft.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11OLC014.mail.protection.outlook.com (10.1.15.48) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Thu, 12 Oct 2017 13:10:35 +0000 Received: from netperf2.ap.freescale.net ([10.232.133.164]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9CDAKSM008029; Thu, 12 Oct 2017 06:10:31 -0700 From: <alok.makhariya@nxp.com> To: <dev@dpdk.org> CC: <akhil.goyal@nxp.com>, <pablo.de.lara.guarch@intel.com>, <hemant.agrawal@nxp.com>, Alok Makhariya <alok.makhariya@nxp.com> Date: Thu, 12 Oct 2017 18:37:23 +0530 Message-ID: <20171012130726.4332-3-alok.makhariya@nxp.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20171012130726.4332-1-alok.makhariya@nxp.com> References: <20171012130726.4332-1-alok.makhariya@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131522874352952257; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(346002)(39860400002)(39380400002)(376002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(53936002)(50226002)(86152003)(76176999)(2950100002)(8656003)(6916009)(4326008)(48376002)(33646002)(50466002)(50986999)(16586007)(104016004)(316002)(5003940100001)(54906003)(86362001)(2906002)(47776003)(2876002)(498600001)(69596002)(189998001)(6666003)(36756003)(356003)(68736007)(81156014)(85426001)(81166006)(8936002)(8676002)(105606002)(77096006)(106466001)(305945005)(2351001)(1076002)(97736004)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2356; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC014; 1:FRWegtfSuqoLsLebpIUR4UEyFJf5IGC9J18VaDjba71uMbHDBRvVrO6z4XsU/+HYd8UZx7+k/dO/LuLUjop7k6kCs2c/PRrFMzh1kKTdsxmKclTVifphd6HllTmaOP0Z MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf8b1a07-8cb5-498a-58d1-08d51172a009 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:BN3PR03MB2356; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2356; 3:c5BYdl1ys3Uayo/gnwaqRGq8gcvq8l+lVdN9Vevd4Yf0dgcIov8358BamNLk24y0d2RR+suYPOt6kROYo4PoErpl8QMh42YBc0YcTF4HniaO31c/XnKFWOGrIipJwnhIxNiZhNUEbIJa2an2xbjZPC1KCjY20JXqeotqYlZh7LfW9FuTxMI8r9V+RyWQGVYnsng2HATaL1s7GLWzEJ3qP6Z7IY+mXoe8BJCqd0eTHvehJV9c8wYLtQ9Ds44uh8iDvlF3Rmym69A9dfsD4+KBKN36xgjxfZVMkj/pSrjruPWaegB07aSPuyhgsCg/z6Hs1rLlB/YOkWbjgYQ1n9kuwXpnDN0zMgMFLLokb3R57Ko=; 25:zAtscx/4cf23+Ustn4kZHZNPhhHixBqL9WQrAF7HMWr6Wwy4ARCzoNzWitVKJJZHEf1+RoDOJHT/FywPE8VhYvBBujgkEhXkE5Qf55GvQv2kJGMMnADB17W9RRfa22M0GBW5Qcb3oKJ7DzWvB9m5yr+oHSq1rmua802/w/veGqizBWjA65qJ9D9U6Cvf0mieCNCwguJ3kcMWEMz0WHQ9QJF5wCq6YMW4eW4AxVA/MV6dd5MG0herMVbmw8rNRFsxSuCpnaUsQnMMWaoMFT7Jy4CU9Smjc7CjZhrzmIJOX9KYAxUZtbSlFjS84Tht9ZY/w63XhNrVVSmu6+Pk+9YWbQ== X-MS-TrafficTypeDiagnostic: BN3PR03MB2356: X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2356; 31:3StCbyVY4S+IJlaYJgxJvVxwm6rpf1DIZDosOBiW8gLJtvVIrxKD+toVb52Udlgo3Jc6x5RgogJdyNLQZDbZoy992FCkYDWngr14irQz8YtLylNbZO9RmUXTl9WCheCiLrfd52ldwr3Mntb7gRo7uZ9N5PZJwFezoAH6RjHFhLQslWaI3ugrT7hKbfOv1yAeYkg227pu3wdXjI4gVJBMrunRy5De/CkdRXdoh12UMNM=; 4:J+j9r3Y85+zQHe6fY/yNJyMczqAKi5SPXjkFH5FjJ9ms6emYSAWYVKODEJxuEXWDTXWvdOSDed1Vix5ug9IbRuv9AfKX0qxUREOybZr9OpOiFR/JwoZt+16RYy0+holH4oNcSdI7NsxlogHYL7PWsmfKEVRz8GwrH4rMOAilovZ0iB9j+RvlQg1KfsSgqs2Lxu/bPG4sIHrRD99+iyyjfpRklySDB2tCIwaZNm3GhUKlxGIBbLarT/LDWM7RQn4pUyPF18q1LeqGFcSrZQqMKOQgEOKoFqC08CH9tmfx3X8= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: <BN3PR03MB23566264243A2CDA8CDC64B3994B0@BN3PR03MB2356.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6096035)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123559100)(20161123563025)(20161123561025)(20161123556025)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR03MB2356; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR03MB2356; X-Forefront-PRVS: 04583CED1A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR03MB2356; 23:nQ9ZK2wMdTYX0H/vDqu+V1BhY2UtDcaRJ+j9HGImI?= 1r3zCDPzyrwAF9gT8yIeAdKo0lrTHO7I/xN5SClMnr+HUPADEZ6oJf95mhAFGLmLWxd9KGbhR/VpQy5etGNdfCUrsAWx882o3mnQl25mz5wpPYz16z8Ex4G1+HHMS7U8nkqw0WIf4FadVIqTJhV+3hkg6LUjiA2/2vDHEqsS+28B8ws5/wipFW/kx+jBpEzEJuaC/SmNCFlG/ib/Pn+6iGIdmFJsYFOh+LGalVTqYRVG/0sdBiT9CUwQKoe2lnUIlbeSQjIW3GpSRxMJ29FClC0g+fmKXheMIpUiYq3jUZjea4EHCDQYyawmxPgsv5Rlrw1urUMOVJNSAMBS33+HGNd+dTpUbiOEibYqnxI3G6xQvrnJshlTNHzcaW00E6qj5r4RdJVJFkdAtmtLh4vRwsbltVn850LerF42aVQhAR1Z67boaDWLZRpk+szn0ozwoeKX4veyk8WFCO/w2Jfkzb+TCI13EevxK38+uqtrM+JIGufHfhp2delcUrymwyLPhu2qX6eCLdZfhr/fvnGYe8SWXzzPmwzwpUaL/E5gqD1eL/iA0IYG5yJCwoSEbRPllmnVwflVOhhgahhLA9KUImpw41juKszpp49coDh09vgWmQ9+nW3wWI0xTYF4xCiKNCFUr0LCmwNPE8sm4Up73ccF8K9Mp3iJnEUbb4kSxJ9gHw7VyqZKvI7+lGEWjro3nngxadt2k+n1S421j7nnOXH9Fze5fblwBMe2ldbpeRD1KpbdtopMkBRR41W1pOHsjgsAJu1Rg8JTBTS1lnWTujcOZQCH2UaK0HxaZKBbAQ4Vyh8dPuAvRDbsQOWNdIHS10/rMAq1Q2r0LM+PJqc8j/+caP0khpm1T3H/TNrt55WEkBozMugWe8SDKoVrU96AvkWU7vb4xwv02nyExNRDXpodlRjNct6/dZANZsr5Jkmb8L7p4Fri4sNp933kwi6KKeCxZFK7vORl9L+F3v879a6RH571Cag5J+RBkk2AyLHpPJX44x2SJp1QKcu+PMdsntQfESiO19J26fnFcKK5lCcu5vAvXxet0OBNrQWLshonDGoGv8kTp5qa8k/bzhK909qkIxKuduH9uTeG8uOSGVus5+dz8+fF0mxtX2YbFs20tre2Ry59Ov8Kw7lUEqWAuqyYqh9h469qM3rr4YEv1vb9alrAgr+ThDQDDorOS6LIOh0S7K8hpA3/Chx2rkPiGk= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2356; 6:RFuXyi5M6AZhJJR61Rx/bYtbNFSmc06k3SNsyxiDdfMlS1/z9d7qwBcVxGXaQW8dEx2DfLVsLkjE7UZ83madnqx98EONDALXXo+jVEwRE5lKWUNOjQDzza7lTxw1ubjs55a1WjyuGgwvr6QbroQxlxoNIMs/n3qmfuWiUVKzPrmRS5ihxoh7PHH8J5Ia0IBZChaf/5lKoVKV2Sth99uz/Zmiqr7krf42VMtOHWb1UCFnrTclaJCSPOP+RW6/sMms1kTsP9pqJsE7lInIsheyyxwtktNx09gR/811VkYTXDD7zWSMmjLiQQR10+ek4ts3mOjD+u6lxl3NhBBds8yn3Q==; 5:bUvMzrMUlCzndiAxJ16JKfOYMj28xDmKe6ObHNqefvfXT+fHGKpQQJVXdHmukXBzTYmLggNYe5wjyiaNSlij7qQgtVW4wAcjWtbVPF6c98uLKUxNVJ4KYqInOEr3PzCta9Hi5odJNfDeQ1Il1rRURA==; 24:zaDgqTmhUV3215LCzT/cMbvSFiZWSIzIjLL4RS+5UMr3lM8Y6Bplq2AJJWvP9d0cW/Lkb4/pQC2kMgYT/awPfeU+KIk7atmCO4+AFobigWk=; 7:b4xPNArsG4pF7y545Xx13+/aVqgTX7eaMw6ZQ+5C8bRhsfH2bZFi9viHCYA7s/o00P3tup7ZYg9ey0Lh4i6I1oYEY76CycOigrPNdrw8+qJaviOsum9ju4tjXaKHN3+LFVfiwX0vU6QBUKnIR71AIF4is6CEWxvDHRMfFjd9CERR/g6VLcsppHEk8uIuboWjM5KqHghMH27pPv/E5MlPbbbxgZ+cZYWIzp20VB6njSQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 13:10:35.0456 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2356 Subject: [dpdk-dev] [PATCH] crypto/dpaa_sec: remove memset of icv on decryption side X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
Commit Message
alok.makhariya@nxp.com
Oct. 12, 2017, 1:07 p.m. UTC
From: Alok Makhariya <alok.makhariya@nxp.com> Since the packet lengths are modified. It is not required to explicitly reset the icv. Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com> --- drivers/crypto/dpaa_sec/dpaa_sec.c | 3 --- 1 file changed, 3 deletions(-)
Comments
On 10/12/2017 6:37 PM, alok.makhariya@nxp.com wrote: > From: Alok Makhariya <alok.makhariya@nxp.com> > > Since the packet lengths are modified. It is not required to > explicitly reset the icv. > Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") > > Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com> > --- > drivers/crypto/dpaa_sec/dpaa_sec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c > index 8a57b96..b618b59 100644 > --- a/drivers/crypto/dpaa_sec/dpaa_sec.c > +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c > @@ -598,7 +598,6 @@ build_auth_only(struct rte_crypto_op *op, dpaa_sec_session *ses) > /* hash result or digest, save digest first */ > rte_memcpy(old_digest, sym->auth.digest.data, > ses->digest_length); > - memset(sym->auth.digest.data, 0, ses->digest_length); > qm_sg_entry_set64(sg, start_addr + sym->auth.data.offset); > sg->length = sym->auth.data.length; > cpu_to_hw_sg(sg); > @@ -738,7 +737,6 @@ build_cipher_auth_gcm(struct rte_crypto_op *op, dpaa_sec_session *ses) > > memcpy(ctx->digest, sym->aead.digest.data, > ses->digest_length); > - memset(sym->aead.digest.data, 0, ses->digest_length); > sg++; > > qm_sg_entry_set64(sg, dpaa_mem_vtop(ctx->digest)); > @@ -832,7 +830,6 @@ build_cipher_auth(struct rte_crypto_op *op, dpaa_sec_session *ses) > > memcpy(ctx->digest, sym->auth.digest.data, > ses->digest_length); > - memset(sym->auth.digest.data, 0, ses->digest_length); > sg++; > > qm_sg_entry_set64(sg, dpaa_mem_vtop(ctx->digest)); > Acked-by Akhil Goyal <akhil.goyal@nxp.com>
> -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Friday, October 13, 2017 3:23 PM > To: alok.makhariya@nxp.com; dev@dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; > hemant.agrawal@nxp.com > Subject: Re: [PATCH] crypto/dpaa_sec: remove memset of icv on decryption > side > > On 10/12/2017 6:37 PM, alok.makhariya@nxp.com wrote: > > From: Alok Makhariya <alok.makhariya@nxp.com> > > > > Since the packet lengths are modified. It is not required to > > explicitly reset the icv. > > Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA > > platform") > > > > Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com> ... > Acked-by Akhil Goyal <akhil.goyal@nxp.com> Applied to dpdk-next-crypto. Thanks, Pablo
diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 8a57b96..b618b59 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -598,7 +598,6 @@ build_auth_only(struct rte_crypto_op *op, dpaa_sec_session *ses) /* hash result or digest, save digest first */ rte_memcpy(old_digest, sym->auth.digest.data, ses->digest_length); - memset(sym->auth.digest.data, 0, ses->digest_length); qm_sg_entry_set64(sg, start_addr + sym->auth.data.offset); sg->length = sym->auth.data.length; cpu_to_hw_sg(sg); @@ -738,7 +737,6 @@ build_cipher_auth_gcm(struct rte_crypto_op *op, dpaa_sec_session *ses) memcpy(ctx->digest, sym->aead.digest.data, ses->digest_length); - memset(sym->aead.digest.data, 0, ses->digest_length); sg++; qm_sg_entry_set64(sg, dpaa_mem_vtop(ctx->digest)); @@ -832,7 +830,6 @@ build_cipher_auth(struct rte_crypto_op *op, dpaa_sec_session *ses) memcpy(ctx->digest, sym->auth.digest.data, ses->digest_length); - memset(sym->auth.digest.data, 0, ses->digest_length); sg++; qm_sg_entry_set64(sg, dpaa_mem_vtop(ctx->digest));