| Message ID | 20171013153854.8444-1-alok.makhariya@nxp.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Pablo de Lara Guarch |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E2CB31B778; Fri, 13 Oct 2017 17:41:44 +0200 (CEST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0050.outbound.protection.outlook.com [104.47.37.50]) by dpdk.org (Postfix) with ESMTP id 46AF71B72F; Fri, 13 Oct 2017 17:41:43 +0200 (CEST) Received: from CY4PR03CA0009.namprd03.prod.outlook.com (2603:10b6:903:33::19) by SN2PR03MB2367.namprd03.prod.outlook.com (2603:10b6:804:e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 15:41:41 +0000 Received: from BN1AFFO11OLC004.protection.gbl (2a01:111:f400:7c10::188) by CY4PR03CA0009.outlook.office365.com (2603:10b6:903:33::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Fri, 13 Oct 2017 15:41:41 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; NXP1.onmicrosoft.com; dkim=none (message not signed) header.d=none;NXP1.onmicrosoft.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11OLC004.mail.protection.outlook.com (10.58.53.75) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 13 Oct 2017 15:41:40 +0000 Received: from netperf2.ap.freescale.net ([10.232.133.164]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9DFfaoH031928; Fri, 13 Oct 2017 08:41:37 -0700 From: <alok.makhariya@nxp.com> To: <dev@dpdk.org> CC: <akhil.goyal@nxp.com>, <pablo.de.lara.guarch@intel.com>, <hemant.agrawal@nxp.com>, Alok Makhariya <alok.makhariya@nxp.com>, <stable@dpdk.org> Date: Fri, 13 Oct 2017 21:08:54 +0530 Message-ID: <20171013153854.8444-1-alok.makhariya@nxp.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20171012130726.4332-2-alok.makhariya@nxp.com> References: <20171012130726.4332-2-alok.makhariya@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131523829010619241; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(346002)(376002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(498600001)(77096006)(5660300001)(1076002)(8656003)(2906002)(2876002)(5003940100001)(85426001)(356003)(305945005)(54906003)(316002)(97736004)(16586007)(6666003)(8676002)(81156014)(81166006)(8936002)(6916009)(2950100002)(104016004)(4326008)(53936002)(86152003)(47776003)(76176999)(50986999)(50466002)(50226002)(105606002)(69596002)(48376002)(189998001)(86362001)(2351001)(106466001)(68736007)(33646002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2367; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11OLC004; 1:NQSzSzhOggcjoYCouSgZ8QFzBZplDfuyeFl7JkhKtVG/baaK883DxUXOiGRf43aenttWYQi3+gcA26qDnkxMFGBgmjcVpmQaVUGh639canWmdYEFlQpzTCcFS9Ci0Ssz MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b942d019-170c-4c86-fa0d-08d51250e621 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:SN2PR03MB2367; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2367; 3:NRjns33uWnJ9TuG9Msn7UWTEW3ykb0Whb2FNUASxkFBtpehRE1u2hUICwfCPH3pJWpRf6ORcnLWD4OVDFJO9+gVxt2aYcou8xXk2pL7uOHJMnGrsBuJO8tERWQz7x648j+ppZSqR6je+KSZ19NAp6DSOcR/Trt+AeVaAWec41wgEKa8bi5+9gJ1KSLR9xc87TU57RQrLFgL3gAl542Pg232czUNA4cbwDlGsTl03lCtywJUVj46EAZrQ0uM3lW4TR7ANSCu+ilocQ9KjEALLFYlBzyHnUhZ4MB2LrsLmIVeCBdAevMsSb68csK3VkH8dHsPyLTlKQs5re8/dc/15V20mnW0uP2AFtQ2odB+2gYs=; 25:qM5301HLKg0h0BSUzyr8tWTD1y8G+ikmWJjJEsv6FKC3tYDwKEdFSBKKOsUkSZoJZIwq7npM1m2uxo43m1Bxzn/Nfu6Nl4J5SlFaEELZHUYaYjxWP3YD0fNsEx/Aq5pyvN5/sPsd+MV2QfGG5I/PkcaOL8eI7DMjDjaUELHU1zMZkwpaLiM2/DSFWdAJLqGBS6rDDVVBrttH4/fn1zJwB1DTCsRiL6sFj+ryPPjQHHhW+AMUl+YziG23l23BBUYTUzWAavPEvG2XaU5JCtwlh5smz0w6tFg1xZWTRvgsL5ouSX/SNDylCPTkLZIMdku9eXcY01QhoOlZWAaap1tRQA== X-MS-TrafficTypeDiagnostic: SN2PR03MB2367: X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2367; 31:pceWyZRBXLXb7DvarYwOXPAPBfBbnfcItm1sGgPRaMFsjtyBfctLXCuJ8Qzi2Wq6r8XDJeDgvE7Gh9wGPFtkU4C/b/pTCKgza77a1MdtZpdq8i0yi970oVimxtEUb3hwkn/Hr5G3tOuVjQcRwdZcwWWgXEuV8tLt3dwvVF/xw510pq4jO5Nim+eFO0u5M8C4xf/lULKXewhTWIqQKnYz+sNoZX2ZxU6+cqCR0K5b6dA=; 4:HTAPeDbD7NbYh/qgDl9bv6gDQB9y/cTvWKm4csbhDpYNPpdGezvQKcLN24k6HV/+er1CVA6EC3qz1x9JQZlWZx8s/mYDUAeGFRlm/+wjsSNrj0YHErtUGQCoFT8wi//ZJcPcrKjUnF0hO8jTf/MnQKrNLV6IgsmwPPg/Ap5vCDYitaMuo7GlspTH5DMzJ9hy7E6rH5vGdcBTH0holLAp6UkXx7BBTaeKPjwoeO7oiMlQtjC75Z6SIu4NtnmwyPl4ND3yeHRpfjeh881RH+C6wBgGuKayeSL6KBXNfGJWXx8= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: <SN2PR03MB23677E9972372E284AFF83CD99480@SN2PR03MB2367.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6096035)(20161123563025)(20161123556025)(20161123561025)(20161123559100)(20161123565025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN2PR03MB2367; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN2PR03MB2367; X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR03MB2367; 23:ZHaZidYv7w6CEctQ86W9xFWWRlp/tY/ClHJRSHx/1?= uNd8qcUb9KhtrF+KKHFz1GBUE1l3oQMyfHpZlc764/3Q4TbtVeo5SxQkNCTw04CGuMk6nyyTYDgfTSKLMx+Bj0QTg3gsoGkfobrfoFxiUI/6Xi2BiYP0DFVYqtqrJkbT/BggLxvYA04Doi8HYsGUb0a+3vUl7W+1bV7VGqNPp4E5tSkn2KanMDj1hQMLYj3DGjimFvMfG93M/qRdUqOLwsWr9MS181cz6pRerONlV14lvK/myBxuTt+69A44LFSvvgwALvPqHC+kMgBZ27kq430hd9MCSWSGF4ReHCXMDXQGXe0zUcJZV5RIP0E/lVK5g6masdy+QJah3xLfoK5U9oy3R70Lf6IAcBuNAFQHYBGW6xau/2DBxiajIin0YeAi4hmXC4QDRBW/exu+ghGmz3JSZLXDIfKOsHWbl8B6bszwN4r+Y08ovJ/9itqlWWznETwwKiiTbAgkNm2+5xLs2eEysnIe7aoLy9w7wBmgLaEMFASW1EjH/sdKUjA3dtZMV0ptolkj4JFj8Fd7MllyfFKzV7rtZ1yl9uFsXLE3WiMJikRtdY4wDfnN4CKrV8uOvUWimqZKDWjxXC2yP4dADVyunYDVRTidWaG7dSGIKa294fIDKwLHgXWEFzNUbg7vMfhuc6EDKrIs9ROYW+NQulB3EZslo5wWhxX91HQ3kz28pW4TS9JIjbiMG3e1rqIv+xRWkphWmusOuNlL3SVxkoYqACJSNe0W1opBKgqndG2Op/Ytck3hHCrjhaWqoEp51Hr9Lc8wwe5gcBQ4VvhlZk3+QoGL2Q2Poq2zAInfJ73k2q1f81NGwFLTkFW/yEt2hHzpzmSppuxoClWl+lYX8RIRUMM7n9LbmcnvJkXJK+/rReERuQxmnpPg3CqZGfiwZ0BE6muVjnfKVCY9qHR4NIWmSwE01dEJ76WM6TPG0Z3fofwcveJr+x6fqwhQX27RJxVRvPBmtJNo1hCgLnDBDGf5u6lv16AME1v898T9LtXc7s53n36ILRTG3SVheu7lgPWCdJ9RuB0fckhcJYKtf42zqhgrpI3uOPNPrWdE2V7Kmnpcxy+LGWAzOecQ33MfTYHc5wE3uZ6DMANFJ/rgCFBSeTNKdDsYQ21FojylxS+dixsL4UGuOBQH0Y8KIq43zxq979dcpICFyXv9Oo20dMQTroINDHOoc4nl0TwWXdUDqvdYNZd/FlewexRm1v/32E= X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2367; 6:ZwhV3VLA/MT8U/an111/OrzNg7+mDR5aWmWI1t56zSgzZ4fjlg+beK8k0GOAO4QsWRJpPgHtNM//JA7s0gekIvmSJfUPhQQ/lXzWbYXCyFQzXbVDAzZpSpkGkwKOphDlyWTOwsc+jGKadi1nNien4z/Lu4so6VO9YcMvhxM7BEypPMf1fVJe3CvODPdIGqnDIZInbuZPv7Z9NfnIpvMRudTbaczH9z4I6BpFm3wdL7Ks1N69p1ucWKfRtv5PG9XxMJYQlLX2FBSg85CwMb+kx2m7x6ChZJJIp6/Gvqh+peEqNtAHh2m0KNlzNLHjkJo5SzFmc3Vjq9fFGFiSIpGt+g==; 5:FXvMtFSojNOYjnmko7GIHJQYlFSzgr+acZRG9C78Zdn91SIOCOWk95qD3+fT4wVtSqs2ef0ct+vLGE/2YSso7b62lB9J4vbNbItwuXcCbPRq/2UCCoLhj6Qo7toKz9OuR/kyov6ZPeaLmEeGGOG17w==; 24:Zrwbok10ot0rCB3r+UbPRYh5F7cveyiZkY13qcaSA25JRkxjl7LW8pdwZuuP1x4GmDqpVOjbbkkaeFU1eO+V4erB6BRuwDfdNJFXb9G/Mnc=; 7:ojr7ndZHloYtX1RCijSZsC6ubz1Un9dJE9bjtUzfgrZcsyCl8PyExE0pvVQcgDW8xd96AtAt34JiV08ElitZFkj/bkDOv2IzdxQPXWr4bEPJ7YrjmuIuGWLNwvA86eLfnuFcv6XWRBEY7jhx8o1eS4utRV/aCaueJhZGh/nb+NLTxCVEac95b7NWi9evtttLjIkIfZnPRg9nJYL8F/ckUU8LWHmmH4YcRSQmozA4F84= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 15:41:40.8123 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2367 Subject: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: add check for segmented buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | success | Compilation OK |
Commit Message
alok.makhariya@nxp.com
Oct. 13, 2017, 3:38 p.m. UTC
From: Alok Makhariya <alok.makhariya@nxp.com> The code would crash for segmented buffer if no check. Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") Cc: stable@dpdk.org Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com> --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
Comments
On 10/13/2017 9:08 PM, alok.makhariya@nxp.com wrote: > From: Alok Makhariya <alok.makhariya@nxp.com> > > The code would crash for segmented buffer if no check. > > Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") > Cc: stable@dpdk.org > > Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com> > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 672cacf..b33081c 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -551,7 +551,13 @@ build_sec_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, > int ret = -1; > > PMD_INIT_FUNC_TRACE(); > - > + /* > + * Segmented buffer is not supported. > + */ > + if (!rte_pktmbuf_is_contiguous(op->sym->m_src)) { > + op->status = RTE_CRYPTO_OP_STATUS_ERROR; > + return -ENOTSUP; > + } > switch (sess->ctxt_type) { > case DPAA2_SEC_CIPHER: > ret = build_cipher_fd(sess, op, fd, bpid); > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Friday, October 13, 2017 4:45 PM > To: alok.makhariya@nxp.com; dev@dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; > hemant.agrawal@nxp.com; stable@dpdk.org > Subject: Re: [PATCH v2] crypto/dpaa2_sec: add check for segmented buffer > > On 10/13/2017 9:08 PM, alok.makhariya@nxp.com wrote: > > From: Alok Makhariya <alok.makhariya@nxp.com> > > > > The code would crash for segmented buffer if no check. > > > > Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com> > > --- > > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > > index 672cacf..b33081c 100644 > > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > > @@ -551,7 +551,13 @@ build_sec_fd(dpaa2_sec_session *sess, struct > rte_crypto_op *op, > > int ret = -1; > > > > PMD_INIT_FUNC_TRACE(); > > - > > + /* > > + * Segmented buffer is not supported. > > + */ > > + if (!rte_pktmbuf_is_contiguous(op->sym->m_src)) { > > + op->status = RTE_CRYPTO_OP_STATUS_ERROR; > > + return -ENOTSUP; > > + } > > switch (sess->ctxt_type) { > > case DPAA2_SEC_CIPHER: > > ret = build_cipher_fd(sess, op, fd, bpid); > > > Acked-by: Akhil Goyal <akhil.goyal@nxp.com> Applied to dpdk-next-crypto. Thanks, Pablo
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 672cacf..b33081c 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -551,7 +551,13 @@ build_sec_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, int ret = -1; PMD_INIT_FUNC_TRACE(); - + /* + * Segmented buffer is not supported. + */ + if (!rte_pktmbuf_is_contiguous(op->sym->m_src)) { + op->status = RTE_CRYPTO_OP_STATUS_ERROR; + return -ENOTSUP; + } switch (sess->ctxt_type) { case DPAA2_SEC_CIPHER: ret = build_cipher_fd(sess, op, fd, bpid);