[dpdk-dev,1/2] crypto/qat: fix null auth algo issue
Checks
Commit Message
If auth algorithm is RTE_CRYPTO_AUTH_NULL and digest_length is 0
in the xform and digest pointer is set in the op, then
the PMD may overwrite memory at the digest pointer.
With this patch the memory is not overwritten.
Fixes: db0e952a5c01 ("crypto/qat: add NULL capability")
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
drivers/crypto/qat/qat_crypto.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Thursday, January 25, 2018 5:19 PM
> To: dev@dpdk.org
> Cc: Nicolau, Radu <radu.nicolau@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: [PATCH 1/2] crypto/qat: fix null auth algo issue
>
> If auth algorithm is RTE_CRYPTO_AUTH_NULL and digest_length is 0 in the
> xform and digest pointer is set in the op, then the PMD may overwrite
> memory at the digest pointer.
> With this patch the memory is not overwritten.
>
> Fixes: db0e952a5c01 ("crypto/qat: add NULL capability")
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
Tested and
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
> -----Original Message-----
> From: Nicolau, Radu
> Sent: Thursday, January 25, 2018 5:37 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: RE: [PATCH 1/2] crypto/qat: fix null auth algo issue
>
>
> > -----Original Message-----
> > From: Trahe, Fiona
> > Sent: Thursday, January 25, 2018 5:19 PM
> > To: dev@dpdk.org
> > Cc: Nicolau, Radu <radu.nicolau@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>
> > Subject: [PATCH 1/2] crypto/qat: fix null auth algo issue
> >
> > If auth algorithm is RTE_CRYPTO_AUTH_NULL and digest_length is 0 in
> > the xform and digest pointer is set in the op, then the PMD may
> > overwrite memory at the digest pointer.
> > With this patch the memory is not overwritten.
> >
> > Fixes: db0e952a5c01 ("crypto/qat: add NULL capability")
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> > ---
>
> Tested and
> Acked-by: Radu Nicolau <radu.nicolau@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
@@ -1338,7 +1338,9 @@ qat_write_hw_desc_entry(struct rte_crypto_op *op, uint8_t *out_msg,
}
min_ofs = auth_ofs;
- auth_param->auth_res_addr = op->sym->auth.digest.phys_addr;
+ if (likely(ctx->qat_hash_alg != ICP_QAT_HW_AUTH_ALGO_NULL))
+ auth_param->auth_res_addr =
+ op->sym->auth.digest.phys_addr;
}