[dpdk-dev,4/4] ether: add packet modification aciton in flow API
Checks
Commit Message
Add new actions that be used to modify packet content with
generic semantic:
RTE_FLOW_ACTION_TYPE_FIELD_UPDATE:
- update specific field of packet
RTE_FLWO_ACTION_TYPE_FIELD_INCREMENT:
- increament specific field of packet
RTE_FLWO_ACTION_TYPE_FIELD_DECREMENT:
- decreament specific field of packet
RTE_FLWO_ACTION_TYPE_FIELD_COPY:
- copy data from one field to another in packet.
All action use struct rte_flow_item parameter to match the pattern
that going to be modified, if no pattern match, the action just be
skipped. These action are non-terminating action. they will not
impact the fate of the packets.
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
doc/guides/prog_guide/rte_flow.rst | 89 ++++++++++++++++++++++++++++++++++++++
lib/librte_ether/rte_flow.h | 79 +++++++++++++++++++++++++++++++++
2 files changed, 168 insertions(+)
Comments
Hi,
> Subject: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in flow
Typo in the commit message header "action"
> +/** RTE_FLOW_ACTION_TYPE_FIELD_INCREMENT
> + *
> + * Increment 1 on specific field of the packet.
> + *
> + * Typical usage: increase TTL
> + */
> +struct rte_flow_action_field_increment {
> + const struct rte_flow_item *item; /**< specify the data to modify. */
> + uint8_t layer;
> + /**< 0 means outermost matched pattern, 1 means next-to-
> outermost...
> +*/ };
> +
> +/** RTE_FLOW_ACTION_TYPE_FIELD_DECREMENT
> + *
> + * Decrement 1 on specific field of the packet.
> + *
> + * Typical usage: Decrease TTL
> + */
> +struct rte_flow_action_field_decrement {
> + const struct rte_flow_item *item; /**< Specify the data to modify. */
> + uint8_t layer;
> + /**< 0 means outermost matched pattern, 1 means next-to-
> outermost...
> +*/ };
> +
Can you have only one struct to represent both increment/decrements operations instead of two structs? As I see both use same data types .
Thanks,
Reshma
Hi Reshma:
Thanks for your review and I accepted most of your comments except:
1. doc and code will still be merged in one patch to follow the usual way when we add a new API.
2. code re-org for "ifndef _cpluscplus", is not the scope of the patch, it could be done separately.
For others I will fix in v2.
Thanks.
Qi
> -----Original Message-----
> From: Pattan, Reshma
> Sent: Thursday, March 29, 2018 11:23 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; adrien.mazarguil@6wind.com
> Cc: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>; Chandran,
> Sugesh <sugesh.chandran@intel.com>; Glynn, Michael J
> <michael.j.glynn@intel.com>; Liu, Yu Y <yu.y.liu@intel.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in
> flow API
>
> Hi,
>
> > Subject: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in
> flow
>
> Typo in the commit message header "action"
>
> > +/** RTE_FLOW_ACTION_TYPE_FIELD_INCREMENT
> > + *
> > + * Increment 1 on specific field of the packet.
> > + *
> > + * Typical usage: increase TTL
> > + */
> > +struct rte_flow_action_field_increment {
> > + const struct rte_flow_item *item; /**< specify the data to modify. */
> > + uint8_t layer;
> > + /**< 0 means outermost matched pattern, 1 means next-to-
> > outermost...
> > +*/ };
> > +
> > +/** RTE_FLOW_ACTION_TYPE_FIELD_DECREMENT
> > + *
> > + * Decrement 1 on specific field of the packet.
> > + *
> > + * Typical usage: Decrease TTL
> > + */
> > +struct rte_flow_action_field_decrement {
> > + const struct rte_flow_item *item; /**< Specify the data to modify. */
> > + uint8_t layer;
> > + /**< 0 means outermost matched pattern, 1 means next-to-
> > outermost...
> > +*/ };
> > +
>
> Can you have only one struct to represent both increment/decrements
> operations instead of two structs? As I see both use same data types .
>
> Thanks,
> Reshma
@@ -1508,6 +1508,95 @@ Representor.
| ``port_id`` | identification of the destination |
+--------------+-----------------------------------+
+Action: ``FILED_UPDATE``
+^^^^^^^^^^^^^^^^^^^^^^^
+
+Update specific field of the packet.
+
+- Non-terminating by default.
+
+.. _table_rte_flow_action_field_update:
+
+.. table:: FIELD_UPDATE
+
+ +-----------+---------------------------------------------------------+
+ | Field | Value |
+ +===========+=========================================================+
+ | ``item`` | item->type: specify the pattern to modify |
+ | | item->spec: specify the new value to update |
+ | | item->mask: specify which part of the pattern to update |
+ | | item->last: ignored |
+ +-----------+---------------------------------------------------------+
+ | ``layer`` | 0 means outermost matched pattern, |
+ | | 1 means next-to-outermost and so on ... |
+ +-----------+---------------------------------------------------------+
+
+Action: ``FILED_INCREMENT``
+^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+Increment 1 on specific field of the packet.
+
+- Non-terminating by default.
+
+.. _table_rte_flow_action_field_increment:
+
+.. table:: FIELD_INCREMENT
+
+ +-----------+---------------------------------------------------------+
+ | Field | Value |
+ +===========+=========================================================+
+ | ``item`` | item->type: specify the pattern to modify |
+ | | item->spec: ignored |
+ | | item->mask: specify which part of the pattern to update |
+ | | item->last: ignored |
+ +-----------+---------------------------------------------------------+
+ | ``layer`` | 0 means outermost matched pattern, |
+ | | 1 means next-to-outermost and so on ... |
+ +-----------+---------------------------------------------------------+
+
+Action: ``FIELD_DECREMENT``
+^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+Decrement 1 on specific field of the packet.
+
+Paramenter is same is FIELD_INCREMENT.
+
+-Non-terminating by default.
+
+ACTION: ``FIELD_COPY``
+^^^^^^^^^^^^^^^^^^^^^^
+
+Copy data of one field to another of the packet.
+
+-Non-terminating by default.
+
+.. _table_rte_flow_action_field_increment:
+
+.. table:: FIELD_COPY
+
+ +-----------------+-----------------------------------------------------------------+
+ | Field | Value |
+ +=================+=================================================================+
+ | ``src_item`` | src_item->type: match the pattern that data will be copy from |
+ | | src_item->spec: ignored |
+ | | src_item->mask: specify which part of the pattern to copy |
+ | | src_item->last: ignored |
+ +-----------------+-----------------------------------------------------------------+
+ | ``src_layer`` | layer of src_item |
+ | | 0 means outermost matched pattern, |
+ | | 1 means next-to-outermost and so on ... |
+ +-----------------+-----------------------------------------------------------------+
+ | ``dst_item`` | dst_item->type: match the pattern that data will be copy to |
+ | | dst_item->spec: ignored |
+ | | dst_item->mask: specify which part of the pattern to be update |
+ | | it must match src_item->mask. |
+ | | dst_item->last: ignored |
+ +-----------------+-----------------------------------------------------------------+
+ | ``dst_layer`` | layer of dst_item |
+ | | 0 means outermost matched pattern, |
+ | | 1 means next-to-outermost and so on ... |
+ +-----------------+-----------------------------------------------------------------+
+
Negative types
~~~~~~~~~~~~~~
@@ -1176,6 +1176,34 @@ enum rte_flow_action_type {
* See struct rte_flow_action_port.
*/
RTE_FLOW_ACTION_TYPE_PORT,
+
+ /**
+ * Update specific field of the packet.
+ *
+ * See struct rte_flow_item_type_field_update.
+ */
+ RTE_FLOW_ACTION_TYPE_FILED_UPDATE,
+
+ /**
+ * Increment specific field of the packet.
+ *
+ * See struct rte_flow_item_type_field_increment.
+ */
+ RTE_FLOW_ACTION_TYPE_FIELD_INCREMENT,
+
+ /**
+ * Decrement specific field of the packet.
+ *
+ * See struct rte_flow_item_type_field_decrement.
+ */
+ RTE_FLOW_ACTION_TYPE_FIELD_DECREMENT,
+
+ /**
+ * Copy data of one field to another of the packet.
+ *
+ * See struct rte_flow_item_type_field_copy.
+ */
+ RTE_FLOW_ACTION_TYPE_FIELD_COPY,
};
/**
@@ -1325,6 +1353,57 @@ struct rte_flow_action_port {
uint16_t port_id; /**< identification of the forward destination. */
};
+/** RTE_FLOW_ACTION_TYPE_FIELD_UPDATE
+ *
+ * Update specific field of the packet.
+ *
+ * Typical usage: update mac/ip address.
+ */
+struct rte_flow_action_field_update {
+ const struct rte_flow_item *item; /**< specify the data to modify. */
+ uint8_t layer;
+ /**< 0 means outermost matched pattern, 1 means next-to-outermost... */
+};
+
+/** RTE_FLOW_ACTION_TYPE_FIELD_INCREMENT
+ *
+ * Increment 1 on specific field of the packet.
+ *
+ * Typical usage: increase TTL
+ */
+struct rte_flow_action_field_increment {
+ const struct rte_flow_item *item; /**< specify the data to modify. */
+ uint8_t layer;
+ /**< 0 means outermost matched pattern, 1 means next-to-outermost... */
+};
+
+/** RTE_FLOW_ACTION_TYPE_FIELD_DECREMENT
+ *
+ * Decrement 1 on specific field of the packet.
+ *
+ * Typical usage: Decrease TTL
+ */
+struct rte_flow_action_field_decrement {
+ const struct rte_flow_item *item; /**< Specify the data to modify. */
+ uint8_t layer;
+ /**< 0 means outermost matched pattern, 1 means next-to-outermost... */
+};
+
+/** RTE_FLOW_ACTION_TYPE_FIELD_COPY
+ *
+ * Copy data from one field to another of the packet.
+ *
+ * Typical usage: TTL copy-in / copy-out
+ */
+struct rte_flow_action_field_copy {
+ const struct rte_flow_item *src_item; /**< Specify the data copy from */
+ uint8_t src_layer;
+ /**< 0 means outermost matched pattern, 1 means next-to-outermost... */
+ const struct rte_flow_item *dst_item; /**< Specify the data copy to */
+ uint8_t dst_layer;
+ /**< 0 means outermost matched pattern, 1 means next-to-outermost... */
+};
+
/**
* Definition of a single action.
*