[dpdk-dev,v3,2/2] rte_metrics: fix strncpy truncation warning
Checks
Commit Message
Fixes:
librte_metrics/rte_metrics.c:218:4: error: ‘strncpy’ specified
bound 64 equals destination size [-Werror=stringop-truncation]
strncpy(names[idx_name].name,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
stats->metadata[idx_name].name,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
RTE_METRICS_MAX_NAME_LEN);
~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_metrics/rte_metrics.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Comments
29/03/2018 19:05, Stephen Hemminger:
> Fixes:
> librte_metrics/rte_metrics.c:218:4: error: ‘strncpy’ specified
> bound 64 equals destination size [-Werror=stringop-truncation]
> strncpy(names[idx_name].name,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> stats->metadata[idx_name].name,
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> RTE_METRICS_MAX_NAME_LEN);
> ~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This one is fixed with strlcpy now.
@@ -214,10 +214,13 @@ rte_metrics_get_names(struct rte_metric_name *names,
rte_spinlock_unlock(&stats->lock);
return return_value;
}
- for (idx_name = 0; idx_name < stats->cnt_stats; idx_name++)
+
+ for (idx_name = 0; idx_name < stats->cnt_stats; idx_name++) {
strncpy(names[idx_name].name,
stats->metadata[idx_name].name,
- RTE_METRICS_MAX_NAME_LEN);
+ RTE_METRICS_MAX_NAME_LEN - 1);
+ names[idx_name].name[RTE_METRICS_MAX_NAME_LEN - 1] = '\0';
+ }
}
return_value = stats->cnt_stats;
rte_spinlock_unlock(&stats->lock);