[v3] test/event: fix RSS config in eth Rx adapter test
Checks
Commit Message
Remove RSS config as it is not required. The hardcoded RSS
configuration also generates an error on NICs that don't support
it.
Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
CC: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
v2:
- use ETH_MQ_RX_NONE to disable RSS (Jerin Jacob)
v3:
- fix typo in commit message (checkpatch warning)
test/test/test_event_eth_rx_adapter.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
Comments
-----Original Message-----
> Date: Mon, 24 Sep 2018 14:23:47 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [PATCH v3] test/event: fix RSS config in eth Rx adapter test
> X-Mailer: git-send-email 1.8.3.1
>
>
> Remove RSS config as it is not required. The hardcoded RSS
> configuration also generates an error on NICs that don't support
> it.
>
> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> CC: stable@dpdk.org
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Please use --in-reply-to for new version.
Search --in-reply-to in the below link for more details.
http://doc.dpdk.org/guides/contributing/patches.html
-----Original Message-----
> Date: Tue, 25 Sep 2018 08:45:49 +0530
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> To: Nikhil Rao <nikhil.rao@intel.com>
> CC: dev@dpdk.org, stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] test/event: fix RSS config in eth Rx
> adapter test
> User-Agent: Mutt/1.10.1 (2018-07-13)
>
>
> -----Original Message-----
> > Date: Mon, 24 Sep 2018 14:23:47 +0530
> > From: Nikhil Rao <nikhil.rao@intel.com>
> > To: jerin.jacob@caviumnetworks.com
> > CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> > Subject: [PATCH v3] test/event: fix RSS config in eth Rx adapter test
> > X-Mailer: git-send-email 1.8.3.1
> >
> >
> > Remove RSS config as it is not required. The hardcoded RSS
> > configuration also generates an error on NICs that don't support
> > it.
> >
> > Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
Applied to dpdk-next-eventdev/master. Thanks.
>
@@ -98,8 +98,7 @@ struct event_eth_rx_adapter_test_params {
{
static const struct rte_eth_conf port_conf_default = {
.rxmode = {
- .mq_mode = ETH_MQ_RX_RSS,
- .max_rx_pkt_len = ETHER_MAX_LEN
+ .mq_mode = ETH_MQ_RX_NONE,
},
.intr_conf = {
.rxq = 1,
@@ -114,16 +113,8 @@ struct event_eth_rx_adapter_test_params {
{
static const struct rte_eth_conf port_conf_default = {
.rxmode = {
- .mq_mode = ETH_MQ_RX_RSS,
- .max_rx_pkt_len = ETHER_MAX_LEN
+ .mq_mode = ETH_MQ_RX_NONE,
},
- .rx_adv_conf = {
- .rss_conf = {
- .rss_hf = ETH_RSS_IP |
- ETH_RSS_TCP |
- ETH_RSS_UDP,
- }
- }
};
return port_init_common(port, &port_conf_default, mp);