net: fix definition of ipv6 traffic class mask

Message ID 1561988285-12677-1-git-send-email-mb@smartsharesystems.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net: fix definition of ipv6 traffic class mask |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Morten Brørup July 1, 2019, 1:38 p.m. UTC
  IPv6 header TC field is 8 bits, not 4.

Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
---
 lib/librte_net/rte_ip.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
  

Comments

Olivier Matz July 1, 2019, 2 p.m. UTC | #1
On Mon, Jul 01, 2019 at 03:38:05PM +0200, Morten Brørup wrote:
> IPv6 header TC field is 8 bits, not 4.
> 
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks
  
Olivier Matz July 2, 2019, 9:38 a.m. UTC | #2
On Mon, Jul 01, 2019 at 04:00:44PM +0200, Olivier Matz wrote:
> On Mon, Jul 01, 2019 at 03:38:05PM +0200, Morten Brørup wrote:
> > IPv6 header TC field is 8 bits, not 4.
> > 
> > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Thanks

CC: stable@dpdk.org
  
Ferruh Yigit July 2, 2019, 7 p.m. UTC | #3
On 7/2/2019 10:38 AM, Olivier Matz wrote:
> On Mon, Jul 01, 2019 at 04:00:44PM +0200, Olivier Matz wrote:
>> On Mon, Jul 01, 2019 at 03:38:05PM +0200, Morten Brørup wrote:
>>> IPv6 header TC field is 8 bits, not 4.
>>>
>>> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
>>
>> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>>
>> Thanks
> 
> CC: stable@dpdk.org
> 

    Fixes: 9b20c6e9028e ("net: add IPv6 header fields macros")

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index ae3b7e7..059ec80 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -355,7 +355,7 @@  struct rte_ipv6_hdr {
 #define RTE_IPV6_HDR_FL_SHIFT 0
 #define RTE_IPV6_HDR_TC_SHIFT 20
 #define RTE_IPV6_HDR_FL_MASK ((1u << RTE_IPV6_HDR_TC_SHIFT) - 1)
-#define RTE_IPV6_HDR_TC_MASK (0xf << RTE_IPV6_HDR_TC_SHIFT)
+#define RTE_IPV6_HDR_TC_MASK (0xff << RTE_IPV6_HDR_TC_SHIFT)
 
 /**
  * Process the pseudo-header checksum of an IPv6 header.