Message ID | 20210118161825.31516-1-akozyrev@nvidia.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACDD2A0A03; Mon, 18 Jan 2021 17:18:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1DAD140D49; Mon, 18 Jan 2021 17:18:30 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by mails.dpdk.org (Postfix) with ESMTP id 0D889140CE6 for <dev@dpdk.org>; Mon, 18 Jan 2021 17:18:28 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from akozyrev@nvidia.com) with SMTP; 18 Jan 2021 18:18:28 +0200 Received: from nvidia.com (pegasus02.mtr.labs.mlnx [10.210.16.122]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 10IGISM9009836; Mon, 18 Jan 2021 18:18:28 +0200 From: Alexander Kozyrev <akozyrev@nvidia.com> To: dev@dpdk.org Cc: viacheslavo@nvidia.com, orika@nvidia.com, thomas@monjalon.net, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, jerinjacobk@gmail.com Date: Mon, 18 Jan 2021 16:18:23 +0000 Message-Id: <20210118161825.31516-1-akozyrev@nvidia.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20210116045054.14539-1-akozyrev@nvidia.com> References: <20210116045054.14539-1-akozyrev@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v8 0/2] generic modify rte flow action support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
generic modify rte flow action support
|
|
Message
Alexander Kozyrev
Jan. 18, 2021, 4:18 p.m. UTC
Implement a generic modify rte flow API as described in RFC: http://patches.dpdk.org/patch/85384/ This API allows modifying a destination header field with data from a source header field. Number of bits to use from the source is specified. Tag, Mark or Metadata can also be used as a source/destination to allow saving/overwriting an arbitrary header field with a user-specified value. Alternatively, an immediate value can be provided by a user as a source. Outermost/innermost packet fields (and Tag array elements) are accessible via the level parameter to facilitate the modification of encapsulated packet header fields. The offset parameter provides the flexibility to copy/set any part of a packet starting the specified packet header field. Example of RTE_FLOW_ACTION_TYPE_MODIFY_FIELD implementation for MLX5: https://patchwork.dpdk.org/patch/86736/ --- v1: https://patchwork.dpdk.org/patch/86173/ Initial design. v2: https://patchwork.dpdk.org/cover/86369/ Added testpmd support. v3: https://patchwork.dpdk.org/cover/86442/ Made dst_type, src_type and width only mandatory parameters. v4: https://patchwork.dpdk.org/cover/86488/ Renamed action to RTE_FLOW_ACTION_TYPE_COPY_FIELD. v5: https://patchwork.dpdk.org/cover/86705/ Redesigned as RTE_FLOW_ACTION_TYPE_MODIFY_FIELD. v6: https://patchwork.dpdk.org/cover/86715/ Fixed typos in documentation. v7: https://patchwork.dpdk.org/cover/86718/ Fixed warnings. v8: Added doxygen comments. Alexander Kozyrev (2): ethdev: introduce generic modify rte flow action app/testpmd: add support for modify field flow action app/test-pmd/cmdline_flow.c | 246 +++++++++++++++++++++++++ doc/guides/prog_guide/rte_flow.rst | 66 +++++++ doc/guides/rel_notes/release_21_02.rst | 8 + lib/librte_ethdev/rte_flow.c | 2 + lib/librte_ethdev/rte_flow.h | 87 ++++++++- 5 files changed, 408 insertions(+), 1 deletion(-)
Comments
On Mon, Jan 18, 2021 at 8:18 AM Alexander Kozyrev <akozyrev@nvidia.com> wrote: > > Implement a generic modify rte flow API as described in RFC: > http://patches.dpdk.org/patch/85384/ > > This API allows modifying a destination header field with data from > a source header field. Number of bits to use from the source is specified. > Tag, Mark or Metadata can also be used as a source/destination to allow > saving/overwriting an arbitrary header field with a user-specified value. > Alternatively, an immediate value can be provided by a user as a source. > > Outermost/innermost packet fields (and Tag array elements) are > accessible via the level parameter to facilitate the modification > of encapsulated packet header fields. The offset parameter provides > the flexibility to copy/set any part of a packet starting the > specified packet header field. > > Example of RTE_FLOW_ACTION_TYPE_MODIFY_FIELD implementation for MLX5: > https://patchwork.dpdk.org/patch/86736/ > > --- > v1: https://patchwork.dpdk.org/patch/86173/ > Initial design. > v2: https://patchwork.dpdk.org/cover/86369/ > Added testpmd support. > v3: https://patchwork.dpdk.org/cover/86442/ > Made dst_type, src_type and width only mandatory parameters. > v4: https://patchwork.dpdk.org/cover/86488/ > Renamed action to RTE_FLOW_ACTION_TYPE_COPY_FIELD. > v5: https://patchwork.dpdk.org/cover/86705/ > Redesigned as RTE_FLOW_ACTION_TYPE_MODIFY_FIELD. > v6: https://patchwork.dpdk.org/cover/86715/ > Fixed typos in documentation. > v7: https://patchwork.dpdk.org/cover/86718/ > Fixed warnings. > v8: > Added doxygen comments. > > Alexander Kozyrev (2): > ethdev: introduce generic modify rte flow action > app/testpmd: add support for modify field flow action I see Thomas has some comments on one of the patches. Please address that. Otherwise ack for the series. Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > > app/test-pmd/cmdline_flow.c | 246 +++++++++++++++++++++++++ > doc/guides/prog_guide/rte_flow.rst | 66 +++++++ > doc/guides/rel_notes/release_21_02.rst | 8 + > lib/librte_ethdev/rte_flow.c | 2 + > lib/librte_ethdev/rte_flow.h | 87 ++++++++- > 5 files changed, 408 insertions(+), 1 deletion(-) > > -- > 2.24.1 >