From patchwork Wed Jun 19 18:22:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 55086 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 947E61D0D6; Wed, 19 Jun 2019 20:22:24 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 1912C1D0AD for ; Wed, 19 Jun 2019 20:22:21 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id v9so106302pgr.13 for ; Wed, 19 Jun 2019 11:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jjPRK2NYDox+IehvZWqTpjOE/xenDzoJuLE7M2lHc4o=; b=0V/MHDg8KH80zlpNtjY8NBRhrKXABkCWjpch1WUcP+h+Rjc8kCVxYGkmGlMOAIOnRu zNKzRWYGHc5X06Cg0DjVE4zbHyr8hxhpp2IEkkgYzJ7ULAlV+DxJIyxO9s8KGnXCEDly xQvfpBJs8WxgtQr81mAAnjOIRQIpXieEVn5fFIA7ivDW5FypNsjOG6I4kO+tRNDHikz5 XEa9Wm/S6Fv6jlLjzKXGTgB6+LHUWmol1qfGvIOhjW8GMhMtjP7rcemPnf/z5aXC5GLC AqDuQy2ON1gevV6SjGIWrbmm3CV8uHNdtQJVIm0lkOAtC5ZR7sZufKppDRwlL8EgSHAt 3IZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jjPRK2NYDox+IehvZWqTpjOE/xenDzoJuLE7M2lHc4o=; b=lh97FMEiDWE7UCX5Gbla/C+0tJfdFLMOQjxVEmQnVKiWqU8KYk+8WEDFhtcPbgamz4 sor9l6uBgelOTuRJ9Ok4wmMOIZPrM9J2W7rPvijfLofm2Krdc0UZXekA5CL0T2BMX6nM wCtYhDkdlV5p9l6rsDZfZKvPt3YpGLpl4pzLgF33zM5efN9hO5b5Yhv/xGU6Za5mzLam QZ35SbazpUkbDXuZMu4yFJTR5wjCXzM5S/hc0QSZ31efJIYqPnQUcV0PndstIze3t0Pr wsl0ElrQlzt8dW20JEjKx9J4Rmm73vF4SxxSCuUyRmBazKdWDhbJR35Zt4jGM1jkOpGa VC6Q== X-Gm-Message-State: APjAAAUNHOYzw74auNJFqA351NmpX3XInrPou35Gls8Qdwmjhs5UcitF 0McHh0LiAX3wK5OkSx399qVBH6e9a+g= X-Google-Smtp-Source: APXvYqweX2ZaPiarryfDtZ6Yo38DWSBm4UWaBH3ER5DEtrbWED3z3Jw8S7Hu6wctM6XDYGe8Lf6yfw== X-Received: by 2002:a17:90a:5d0a:: with SMTP id s10mr12434347pji.94.1560968539925; Wed, 19 Jun 2019 11:22:19 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t11sm16212016pgp.1.2019.06.19.11.22.19 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 19 Jun 2019 11:22:19 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Wed, 19 Jun 2019 11:22:17 -0700 Message-Id: <20190619182217.8482-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190619182217.8482-1-stephen@networkplumber.org> References: <20190619182217.8482-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/2] net/qede: fix warnings from invalid assert X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This driver had a bogus assert which could never happen. This triggers "expression is always false warnings" with some compilers which causes build failure. Just remove it. Fixes: 2af14ca79c0a ("net/qede: support 100G") Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Morten Brørup --- drivers/net/qede/qede_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 84d898421bd4..82363e6eba93 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1426,7 +1426,6 @@ static void qede_poll_sp_sb_cb(void *param) if (rc != 0) { DP_ERR(edev, "Unable to start periodic" " timer rc %d\n", rc); - assert(false && "Unable to start periodic timer"); } }