diff mbox series

[09/28] net/ice/base: refactor a function

Message ID	20200309114357.31800-10-qi.z.zhang@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	xiaolong ye
Headers	From: Qi Zhang <qi.z.zhang@intel.com> To: qiming.yang@intel.com, beilei.xing@intel.com Cc: xiaolong.ye@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>, Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com> Date: Mon, 9 Mar 2020 19:43:38 +0800 Message-Id: <20200309114357.31800-10-qi.z.zhang@intel.com> In-Reply-To: <20200309114357.31800-1-qi.z.zhang@intel.com> References: <20200309114357.31800-1-qi.z.zhang@intel.com> Subject: [dpdk-dev] [PATCH 09/28] net/ice/base: refactor a function Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	update ice base code \| [00/28] update ice base code [01/28] net/ice/base: fix uninitialized stack variables [02/28] net/ice/base: add and update E822 device IDs [03/28] net/ice/base: fix removing MAC rule [04/28] net/ice/base: read PSM clock frequency from register [05/28] net/ice/base: allow VLAN and ethertype filter for port [06/28] net/ice/base: replace u16 with enum [07/28] net/ice/base: use struct size helper [08/28] net/ice/base: use descriptive vairiable name than type [09/28] net/ice/base: refactor a function [10/28] net/ice/base: add NVM netlist macros [11/28] net/ice/base: minor fixes [12/28] net/ice/base: support GTPU uplink and downlink [13/28] net/ice/base: add link default override support [14/28] net/ice/base: add dedicate MAC type for E810 [15/28] net/ice/base: capitalize abbreviations [16/28] net/ice/base: add PHY number definition values [17/28] net/ice/base: add shared driver parameter command [18/28] net/ice/bse: add AN masks to Get PHY Caps [19/28] net/ice/base: xtract logic of flat NVM read to function [20/28] net/ice/base: add macro specifying max NVM offset [21/28] net/ice/base: implement new sr read functions [22/28] net/ice/base: couple casting issue fixes [23/28] net/ice/base: support PHY persistent feature [24/28] net/ice/base: store NVM version info in extracted format [25/28] net/ice/base: add ACL module [26/28] net/ice/base: update copyright date [27/28] net/ice/base: add the hook to send AdminQ command [28/28] net/ice/base: don't access some hardware registers in DCF

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	success	Compilation OK

Commit Message

Qi Zhang March 9, 2020, 11:43 a.m. UTC

  Refactor function ice_prof_bld_xlt2, a switch statement is better suited
for this situation and eliminates the need for the "found" variable.

Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/ice/base/ice_flex_pipe.c | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c
index c18ccea48..5dd7a0d38 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -4051,19 +4051,13 @@  ice_prof_bld_xlt2(enum ice_block blk, struct ice_buf_build *bld,
 	struct ice_chs_chg *tmp;
 
 	LIST_FOR_EACH_ENTRY(tmp, chgs, ice_chs_chg, list_entry) {
-		bool found = false;
-
-		if (tmp->type == ICE_VSIG_ADD)
-			found = true;
-		else if (tmp->type == ICE_VSI_MOVE)
-			found = true;
-		else if (tmp->type == ICE_VSIG_REM)
-			found = true;
-
-		if (found) {
-			struct ice_xlt2_section *p;
-			u32 id;
+		struct ice_xlt2_section *p;
+		u32 id;
 
+		switch (tmp->type) {
+		case ICE_VSIG_ADD:
+		case ICE_VSI_MOVE:
+		case ICE_VSIG_REM:
 			id = ice_sect_id(blk, ICE_XLT2);
 			p = (struct ice_xlt2_section *)
 				ice_pkg_buf_alloc_section(bld, id, sizeof(*p));
@@ -4074,6 +4068,9 @@  ice_prof_bld_xlt2(enum ice_block blk, struct ice_buf_build *bld,
 			p->count = CPU_TO_LE16(1);
 			p->offset = CPU_TO_LE16(tmp->vsi);
 			p->value[0] = CPU_TO_LE16(tmp->vsig);
+			break;
+		default:
+			break;
 		}
 	}