[v2] common/iavf: mark internal symbols
diff mbox series

Message ID 20200814163055.326072-1-haiyue.wang@intel.com
State Accepted, archived
Delegated to: Qi Zhang
Headers show
Series
  • [v2] common/iavf: mark internal symbols
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Haiyue Wang Aug. 14, 2020, 4:30 p.m. UTC
According to ABI policy, the internal functions should have the new tag
__rte_internal and linked into INTERNAL sessions.

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
v2: update the commit title
---
 drivers/common/iavf/iavf_prototype.h            | 6 ++++++
 drivers/common/iavf/rte_common_iavf_version.map | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

Comments

Xing, Beilei Aug. 17, 2020, 3:08 a.m. UTC | #1
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Saturday, August 15, 2020 12:31 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Ray
> Kinsella <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>
> Subject: [PATCH v2] common/iavf: mark internal symbols
> 
> According to ABI policy, the internal functions should have the new tag
> __rte_internal and linked into INTERNAL sessions.
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> v2: update the commit title
> ---
>  drivers/common/iavf/iavf_prototype.h            | 6 ++++++
>  drivers/common/iavf/rte_common_iavf_version.map | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/common/iavf/iavf_prototype.h
> b/drivers/common/iavf/iavf_prototype.h
> index 31ce2af49..f34e77db0 100644
> --- a/drivers/common/iavf/iavf_prototype.h
> +++ b/drivers/common/iavf/iavf_prototype.h
> @@ -17,7 +17,9 @@
>   */
> 
>  /* adminq functions */
> +__rte_internal
>  enum iavf_status iavf_init_adminq(struct iavf_hw *hw);
> +__rte_internal
>  enum iavf_status iavf_shutdown_adminq(struct iavf_hw *hw);  enum
> iavf_status iavf_init_asq(struct iavf_hw *hw);  enum iavf_status
> iavf_init_arq(struct iavf_hw *hw); @@ -30,6 +32,7 @@ void
> iavf_free_adminq_asq(struct iavf_hw *hw);  void iavf_free_adminq_arq(struct
> iavf_hw *hw);  enum iavf_status iavf_validate_mac_addr(u8 *mac_addr);
> void iavf_adminq_init_ring_data(struct iavf_hw *hw);
> +__rte_internal
>  enum iavf_status iavf_clean_arq_element(struct iavf_hw *hw,
>  					struct iavf_arq_event_info *e,
>  					u16 *events_pending);
> @@ -61,6 +64,7 @@ enum iavf_status iavf_aq_set_rss_key(struct iavf_hw *hw,
> const char *iavf_aq_str(struct iavf_hw *hw, enum iavf_admin_queue_err
> aq_err);  const char *iavf_stat_str(struct iavf_hw *hw, enum iavf_status
> stat_err);
> 
> +__rte_internal
>  enum iavf_status iavf_set_mac_type(struct iavf_hw *hw);
> 
>  extern struct iavf_rx_ptype_decoded iavf_ptype_lookup[]; @@ -76,9 +80,11
> @@ void iavf_acquire_spinlock(struct iavf_spinlock *sp);  void
> iavf_release_spinlock(struct iavf_spinlock *sp);  void
> iavf_destroy_spinlock(struct iavf_spinlock *sp);
> 
> +__rte_internal
>  void iavf_vf_parse_hw_config(struct iavf_hw *hw,
>  			     struct virtchnl_vf_resource *msg);  enum iavf_status
> iavf_vf_reset(struct iavf_hw *hw);
> +__rte_internal
>  enum iavf_status iavf_aq_send_msg_to_pf(struct iavf_hw *hw,
>  				enum virtchnl_ops v_opcode,
>  				enum iavf_status v_retval,
> diff --git a/drivers/common/iavf/rte_common_iavf_version.map
> b/drivers/common/iavf/rte_common_iavf_version.map
> index 44142499e..e0f117197 100644
> --- a/drivers/common/iavf/rte_common_iavf_version.map
> +++ b/drivers/common/iavf/rte_common_iavf_version.map
> @@ -1,4 +1,4 @@
> -DPDK_21 {
> +INTERNAL {
>  	global:
> 
>  	iavf_aq_send_msg_to_pf;
> --
> 2.28.0

Acked-by: Beilei Xing <beilei.xing@intel.com>
Ferruh Yigit Aug. 18, 2020, 3:48 p.m. UTC | #2
On 8/17/2020 4:08 AM, Xing, Beilei wrote:
> 
> 
>> -----Original Message-----
>> From: Wang, Haiyue <haiyue.wang@intel.com>
>> Sent: Saturday, August 15, 2020 12:31 AM
>> To: dev@dpdk.org
>> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Wu,
>> Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Ray
>> Kinsella <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>
>> Subject: [PATCH v2] common/iavf: mark internal symbols
>>
>> According to ABI policy, the internal functions should have the new tag
>> __rte_internal and linked into INTERNAL sessions.
>>
>> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> 
> Acked-by: Beilei Xing <beilei.xing@intel.com>
> 

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Zhang, Qi Z Aug. 31, 2020, 4:14 a.m. UTC | #3
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, August 18, 2020 11:48 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Ray Kinsella
> <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>
> Subject: Re: [dpdk-dev] [PATCH v2] common/iavf: mark internal symbols
> 
> On 8/17/2020 4:08 AM, Xing, Beilei wrote:
> >
> >
> >> -----Original Message-----
> >> From: Wang, Haiyue <haiyue.wang@intel.com>
> >> Sent: Saturday, August 15, 2020 12:31 AM
> >> To: dev@dpdk.org
> >> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> >> <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Wu,
> >> Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> >> <beilei.xing@intel.com>; Ray Kinsella <mdr@ashroe.eu>; Neil Horman
> >> <nhorman@tuxdriver.com>
> >> Subject: [PATCH v2] common/iavf: mark internal symbols
> >>
> >> According to ABI policy, the internal functions should have the new
> >> tag __rte_internal and linked into INTERNAL sessions.
> >>
> >> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> >
> > Acked-by: Beilei Xing <beilei.xing@intel.com>
> >
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

Patch
diff mbox series

diff --git a/drivers/common/iavf/iavf_prototype.h b/drivers/common/iavf/iavf_prototype.h
index 31ce2af49..f34e77db0 100644
--- a/drivers/common/iavf/iavf_prototype.h
+++ b/drivers/common/iavf/iavf_prototype.h
@@ -17,7 +17,9 @@ 
  */
 
 /* adminq functions */
+__rte_internal
 enum iavf_status iavf_init_adminq(struct iavf_hw *hw);
+__rte_internal
 enum iavf_status iavf_shutdown_adminq(struct iavf_hw *hw);
 enum iavf_status iavf_init_asq(struct iavf_hw *hw);
 enum iavf_status iavf_init_arq(struct iavf_hw *hw);
@@ -30,6 +32,7 @@  void iavf_free_adminq_asq(struct iavf_hw *hw);
 void iavf_free_adminq_arq(struct iavf_hw *hw);
 enum iavf_status iavf_validate_mac_addr(u8 *mac_addr);
 void iavf_adminq_init_ring_data(struct iavf_hw *hw);
+__rte_internal
 enum iavf_status iavf_clean_arq_element(struct iavf_hw *hw,
 					struct iavf_arq_event_info *e,
 					u16 *events_pending);
@@ -61,6 +64,7 @@  enum iavf_status iavf_aq_set_rss_key(struct iavf_hw *hw,
 const char *iavf_aq_str(struct iavf_hw *hw, enum iavf_admin_queue_err aq_err);
 const char *iavf_stat_str(struct iavf_hw *hw, enum iavf_status stat_err);
 
+__rte_internal
 enum iavf_status iavf_set_mac_type(struct iavf_hw *hw);
 
 extern struct iavf_rx_ptype_decoded iavf_ptype_lookup[];
@@ -76,9 +80,11 @@  void iavf_acquire_spinlock(struct iavf_spinlock *sp);
 void iavf_release_spinlock(struct iavf_spinlock *sp);
 void iavf_destroy_spinlock(struct iavf_spinlock *sp);
 
+__rte_internal
 void iavf_vf_parse_hw_config(struct iavf_hw *hw,
 			     struct virtchnl_vf_resource *msg);
 enum iavf_status iavf_vf_reset(struct iavf_hw *hw);
+__rte_internal
 enum iavf_status iavf_aq_send_msg_to_pf(struct iavf_hw *hw,
 				enum virtchnl_ops v_opcode,
 				enum iavf_status v_retval,
diff --git a/drivers/common/iavf/rte_common_iavf_version.map b/drivers/common/iavf/rte_common_iavf_version.map
index 44142499e..e0f117197 100644
--- a/drivers/common/iavf/rte_common_iavf_version.map
+++ b/drivers/common/iavf/rte_common_iavf_version.map
@@ -1,4 +1,4 @@ 
-DPDK_21 {
+INTERNAL {
 	global:
 
 	iavf_aq_send_msg_to_pf;