[v2,0/8] net/bonding: fixes and LACP short timeout

  This patchset makes the following changes to net/bonding:
- Clean up minor errors in spelling, whitespace, C++ wrappers, and
  comments.
- Replace directly overwriting of slave port's rte_eth_conf by copying
  it, but only updating it via rte_eth_dev_configure().
- Make minor changes to allocation of mbuf pool and rx/tx rings.
- Add support for enabling LACP short timeout, i.e., link partner can
  use fast periodic time interval between transmits.
- Include bond_8023ad and bond_alb in doxygen.
- Remove self from Timers maintainers.
- Add API stubs to net/ring PMD.
- Add LACP short timeout to tests.

V2 changes:
- Additional typo and whitespace corrections.
- Minor changes to LACP private rings creation.
- Add net/ring API stubs patch.
- Insert extra "bond_handshake" to LACP short timeout autotest.

Robert Sanford (8):
  net/bonding: fix typos and whitespace
  net/bonding: fix bonded dev configuring slave dev
  net/bonding: change mbuf pool and ring creation
  net/bonding: support enabling LACP short timeout
  net/bonding: add bond_8023ad and bond_alb to doc
  Remove self from Timers maintainers.
  net/ring: add promiscuous and allmulticast API stubs
  net/bonding: add LACP short timeout to tests

 MAINTAINERS                                   |  1 -
 app/test-pmd/cmdline.c                        | 81 +++++++++++++++++++++-
 app/test/test_link_bonding_mode4.c            | 98 ++++++++++++++++++++++-----
 doc/api/doxy-api-index.md                     |  2 +
 drivers/net/bonding/eth_bond_8023ad_private.h | 15 ++--
 drivers/net/bonding/rte_eth_bond_8023ad.c     | 58 ++++++++++------
 drivers/net/bonding/rte_eth_bond_8023ad.h     | 18 +++--
 drivers/net/bonding/rte_eth_bond_pmd.c        | 43 ++++++------
 drivers/net/ring/rte_eth_ring.c               | 28 ++++++++
 9 files changed, 272 insertions(+), 72 deletions(-)
  

Acked-by: Min Hu (Connor) <humin29@huawei.com>

在 2021/12/22 3:57, Robert Sanford 写道:
> This patchset makes the following changes to net/bonding:
> - Clean up minor errors in spelling, whitespace, C++ wrappers, and
>    comments.
> - Replace directly overwriting of slave port's rte_eth_conf by copying
>    it, but only updating it via rte_eth_dev_configure().
> - Make minor changes to allocation of mbuf pool and rx/tx rings.
> - Add support for enabling LACP short timeout, i.e., link partner can
>    use fast periodic time interval between transmits.
> - Include bond_8023ad and bond_alb in doxygen.
> - Remove self from Timers maintainers.
> - Add API stubs to net/ring PMD.
> - Add LACP short timeout to tests.
> 
> V2 changes:
> - Additional typo and whitespace corrections.
> - Minor changes to LACP private rings creation.
> - Add net/ring API stubs patch.
> - Insert extra "bond_handshake" to LACP short timeout autotest.
> 
> Robert Sanford (8):
>    net/bonding: fix typos and whitespace
>    net/bonding: fix bonded dev configuring slave dev
>    net/bonding: change mbuf pool and ring creation
>    net/bonding: support enabling LACP short timeout
>    net/bonding: add bond_8023ad and bond_alb to doc
>    Remove self from Timers maintainers.
>    net/ring: add promiscuous and allmulticast API stubs
>    net/bonding: add LACP short timeout to tests
> 
>   MAINTAINERS                                   |  1 -
>   app/test-pmd/cmdline.c                        | 81 +++++++++++++++++++++-
>   app/test/test_link_bonding_mode4.c            | 98 ++++++++++++++++++++++-----
>   doc/api/doxy-api-index.md                     |  2 +
>   drivers/net/bonding/eth_bond_8023ad_private.h | 15 ++--
>   drivers/net/bonding/rte_eth_bond_8023ad.c     | 58 ++++++++++------
>   drivers/net/bonding/rte_eth_bond_8023ad.h     | 18 +++--
>   drivers/net/bonding/rte_eth_bond_pmd.c        | 43 ++++++------
>   drivers/net/ring/rte_eth_ring.c               | 28 ++++++++
>   9 files changed, 272 insertions(+), 72 deletions(-)
>
  

On 21/12/2021 19:57, Robert Sanford wrote:
> This patchset makes the following changes to net/bonding:
> - Clean up minor errors in spelling, whitespace, C++ wrappers, and
>    comments.
> - Replace directly overwriting of slave port's rte_eth_conf by copying
>    it, but only updating it via rte_eth_dev_configure().
> - Make minor changes to allocation of mbuf pool and rx/tx rings.
> - Add support for enabling LACP short timeout, i.e., link partner can
>    use fast periodic time interval between transmits.
> - Include bond_8023ad and bond_alb in doxygen.
> - Remove self from Timers maintainers.
> - Add API stubs to net/ring PMD.
> - Add LACP short timeout to tests.
> 
> V2 changes:
> - Additional typo and whitespace corrections.
> - Minor changes to LACP private rings creation.
> - Add net/ring API stubs patch.
> - Insert extra "bond_handshake" to LACP short timeout autotest.
> 
> Robert Sanford (8):
>    net/bonding: fix typos and whitespace
>    net/bonding: fix bonded dev configuring slave dev
>    net/bonding: change mbuf pool and ring creation
>    net/bonding: support enabling LACP short timeout
>    net/bonding: add bond_8023ad and bond_alb to doc
>    Remove self from Timers maintainers.
>    net/ring: add promiscuous and allmulticast API stubs
>    net/bonding: add LACP short timeout to tests
> 

You might want to consider patches that are fixes for backport to stable 
branches. Patches 1,2,3,5 look to be the ones most suited.

>   MAINTAINERS                                   |  1 -
>   app/test-pmd/cmdline.c                        | 81 +++++++++++++++++++++-
>   app/test/test_link_bonding_mode4.c            | 98 ++++++++++++++++++++++-----
>   doc/api/doxy-api-index.md                     |  2 +
>   drivers/net/bonding/eth_bond_8023ad_private.h | 15 ++--
>   drivers/net/bonding/rte_eth_bond_8023ad.c     | 58 ++++++++++------
>   drivers/net/bonding/rte_eth_bond_8023ad.h     | 18 +++--
>   drivers/net/bonding/rte_eth_bond_pmd.c        | 43 ++++++------
>   drivers/net/ring/rte_eth_ring.c               | 28 ++++++++
>   9 files changed, 272 insertions(+), 72 deletions(-)
>
  

On 12/21/2021 7:57 PM, Robert Sanford wrote:
> This patchset makes the following changes to net/bonding:
> - Clean up minor errors in spelling, whitespace, C++ wrappers, and
>    comments.
> - Replace directly overwriting of slave port's rte_eth_conf by copying
>    it, but only updating it via rte_eth_dev_configure().
> - Make minor changes to allocation of mbuf pool and rx/tx rings.
> - Add support for enabling LACP short timeout, i.e., link partner can
>    use fast periodic time interval between transmits.
> - Include bond_8023ad and bond_alb in doxygen.
> - Remove self from Timers maintainers.
> - Add API stubs to net/ring PMD.
> - Add LACP short timeout to tests.
> 
> V2 changes:
> - Additional typo and whitespace corrections.
> - Minor changes to LACP private rings creation.
> - Add net/ring API stubs patch.
> - Insert extra "bond_handshake" to LACP short timeout autotest.
> 
> Robert Sanford (8):
>    net/bonding: fix typos and whitespace
>    net/bonding: fix bonded dev configuring slave dev
>    net/bonding: change mbuf pool and ring creation
>    net/bonding: support enabling LACP short timeout
>    net/bonding: add bond_8023ad and bond_alb to doc
>    Remove self from Timers maintainers.
>    net/ring: add promiscuous and allmulticast API stubs
>    net/bonding: add LACP short timeout to tests
> 

Hi Robert,

There are some unrelated (and independent) patches in the set,
can you please make new version as multiple sets to help to manage them?

- 4/8 & 8/8 can be a separate set, since they have ABI concern they can
   be managed separately

- 6/8 can be separate

- rest can be various bonding fix set

Thanks,
ferruh