Message ID | 1648819793-18948-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 826DCA0507; Fri, 1 Apr 2022 15:30:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3109E42933; Fri, 1 Apr 2022 15:30:09 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 6F1D942938 for <dev@dpdk.org>; Fri, 1 Apr 2022 15:30:07 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id AB5AC2058399; Fri, 1 Apr 2022 06:30:01 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AB5AC2058399 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1648819801; bh=zphIZs5HgBVyN/H5lcoIz7ezYaKFQ0vNohpoKf/Fyz0=; h=From:To:Cc:Subject:Date:From; b=Wre1N2/IlK9szZWXE4TPm4/6rfuy3TrAVSqh4v7jyl5g3FLx5Uk2uJGGSTlNe7/jJ AD7NxQ4LOtdGhMegnpbpf70BSs/x9xLr4OL3ZmfwQSBHjwYy6gvtD9g7wxRN5qSDfD 4eKG5Y0kICLkIg5PB9tP5njsu2ThxKi8/zoVrAi0= From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: dev@dpdk.org Cc: thomas@monjalon.net, dmitry.kozliuk@gmail.com, anatoly.burakov@intel.com, Tyler Retzlaff <roretzla@linux.microsoft.com> Subject: [PATCH 0/3] add eal functions for thread affinity Date: Fri, 1 Apr 2022 06:29:50 -0700 Message-Id: <1648819793-18948-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
add eal functions for thread affinity
|
|
Message
Tyler Retzlaff
April 1, 2022, 1:29 p.m. UTC
this series provides basic dependencies for additional eal thread api additions. series includes basic error handling, initial get/set thread affinity functions and minimal unit test. Tyler Retzlaff (3): eal/windows: translate Windows errors to errno-style errors eal: implement functions for get/set thread affinity test/threads: add unit test for thread API app/test/meson.build | 2 + app/test/test_threads.c | 86 +++++++++++++++++++ lib/eal/include/rte_thread.h | 45 ++++++++++ lib/eal/unix/rte_thread.c | 16 ++++ lib/eal/version.map | 4 + lib/eal/windows/eal_lcore.c | 173 +++++++++++++++++++++++++++---------- lib/eal/windows/eal_windows.h | 10 +++ lib/eal/windows/include/rte_os.h | 2 + lib/eal/windows/rte_thread.c | 179 ++++++++++++++++++++++++++++++++++++++- 9 files changed, 472 insertions(+), 45 deletions(-) create mode 100644 app/test/test_threads.c
Comments
Hello Tyler, On Fri, Apr 1, 2022 at 3:30 PM Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > this series provides basic dependencies for additional eal thread api > additions. series includes basic error handling, initial get/set thread > affinity functions and minimal unit test. > > Tyler Retzlaff (3): > eal/windows: translate Windows errors to errno-style errors > eal: implement functions for get/set thread affinity > test/threads: add unit test for thread API > > app/test/meson.build | 2 + > app/test/test_threads.c | 86 +++++++++++++++++++ > lib/eal/include/rte_thread.h | 45 ++++++++++ > lib/eal/unix/rte_thread.c | 16 ++++ > lib/eal/version.map | 4 + > lib/eal/windows/eal_lcore.c | 173 +++++++++++++++++++++++++++---------- > lib/eal/windows/eal_windows.h | 10 +++ > lib/eal/windows/include/rte_os.h | 2 + > lib/eal/windows/rte_thread.c | 179 ++++++++++++++++++++++++++++++++++++++- > 9 files changed, 472 insertions(+), 45 deletions(-) > create mode 100644 app/test/test_threads.c We have two concurrent series, can you clarify what are the intentions on this work? Is this series superseding Narcisa series? Thanks!
On Fri, Apr 08, 2022 at 10:57:55AM +0200, David Marchand wrote: > Hello Tyler, > > On Fri, Apr 1, 2022 at 3:30 PM Tyler Retzlaff > <roretzla@linux.microsoft.com> wrote: > > > > this series provides basic dependencies for additional eal thread api > > additions. series includes basic error handling, initial get/set thread > > affinity functions and minimal unit test. > > > > Tyler Retzlaff (3): > > eal/windows: translate Windows errors to errno-style errors > > eal: implement functions for get/set thread affinity > > test/threads: add unit test for thread API > > > > app/test/meson.build | 2 + > > app/test/test_threads.c | 86 +++++++++++++++++++ > > lib/eal/include/rte_thread.h | 45 ++++++++++ > > lib/eal/unix/rte_thread.c | 16 ++++ > > lib/eal/version.map | 4 + > > lib/eal/windows/eal_lcore.c | 173 +++++++++++++++++++++++++++---------- > > lib/eal/windows/eal_windows.h | 10 +++ > > lib/eal/windows/include/rte_os.h | 2 + > > lib/eal/windows/rte_thread.c | 179 ++++++++++++++++++++++++++++++++++++++- > > 9 files changed, 472 insertions(+), 45 deletions(-) > > create mode 100644 app/test/test_threads.c > > We have two concurrent series, can you clarify what are the intentions > on this work? yes, i should have clarified this up front sorry. > Is this series superseding Narcisa series? this series supersedes the series from Narcisa. it was resolved through discussion that the current series should be abandoned as it is too large and not making progress. we've elected to submit a series of smaller patchsets that incorporate the feedback received to date and build up the api surface for threading. the patches are still the work of Narcisa but she is overscheduled so i will assist in upstreaming and addressing feedback. additionally, rather than port the tree to the new __experimental api as they are added we will prefer to add unit tests that provide validation of the api and example usage. our hope is the smaller scoped series will attract more attention and have better acknowledgement velocity. i will have Narcisa mark the monolithic series as superseded on patchwork. ty
On Fri, Apr 8, 2022 at 3:46 PM Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > On Fri, Apr 08, 2022 at 10:57:55AM +0200, David Marchand wrote: > > Hello Tyler, > > > > On Fri, Apr 1, 2022 at 3:30 PM Tyler Retzlaff > > <roretzla@linux.microsoft.com> wrote: > > > > > > this series provides basic dependencies for additional eal thread api > > > additions. series includes basic error handling, initial get/set thread > > > affinity functions and minimal unit test. > > > > > > Tyler Retzlaff (3): > > > eal/windows: translate Windows errors to errno-style errors > > > eal: implement functions for get/set thread affinity > > > test/threads: add unit test for thread API > > > > > > app/test/meson.build | 2 + > > > app/test/test_threads.c | 86 +++++++++++++++++++ > > > lib/eal/include/rte_thread.h | 45 ++++++++++ > > > lib/eal/unix/rte_thread.c | 16 ++++ > > > lib/eal/version.map | 4 + > > > lib/eal/windows/eal_lcore.c | 173 +++++++++++++++++++++++++++---------- > > > lib/eal/windows/eal_windows.h | 10 +++ > > > lib/eal/windows/include/rte_os.h | 2 + > > > lib/eal/windows/rte_thread.c | 179 ++++++++++++++++++++++++++++++++++++++- > > > 9 files changed, 472 insertions(+), 45 deletions(-) > > > create mode 100644 app/test/test_threads.c > > > > We have two concurrent series, can you clarify what are the intentions > > on this work? > > yes, i should have clarified this up front sorry. > > > Is this series superseding Narcisa series? > > this series supersedes the series from Narcisa. it was resolved through > discussion that the current series should be abandoned as it is too > large and not making progress. > > we've elected to submit a series of smaller patchsets that incorporate > the feedback received to date and build up the api surface for > threading. the patches are still the work of Narcisa but she is > overscheduled so i will assist in upstreaming and addressing feedback. > > additionally, rather than port the tree to the new __experimental api as > they are added we will prefer to add unit tests that provide validation > of the api and example usage. > > our hope is the smaller scoped series will attract more attention and > have better acknowledgement velocity. > > i will have Narcisa mark the monolithic series as superseded on > patchwork. Ok, thanks Tyler.