mbox series

[v3,0/4] drivers/baseband: PMD to support ACC101 device

Message ID 1652734113-124047-1-git-send-email-nicolas.chautru@intel.com (mailing list archive)
Headers show
Series drivers/baseband: PMD to support ACC101 device | expand

Message

Nicolas Chautru May 16, 2022, 8:48 p.m. UTC
v3: Feedback from Tom Rix: missing copyright, refactor bbdev-test section calling
the configure companion function for ACC100/101, taking the Pmon commit out 
which is not directly required.

v2: Based on good feedback from Thomas and David,
now implementing the ACC101 PMD as a close derivative from
existing ACC100 PMD with hooks to have different behaviour based on variant.
This prevents code duplication and only rely on different functions and behaviour
when hardware requires or support differences.
Note that these are pending changes for ACC100 which would be specific to
that device and not ACC101 but these can be managed based on the new
implementation, ie. is_acc100() etc... (such incremental changes for ACC100
trending 22.11 but confirming this is future proof).
The serie also includes commits which were meant for ACC101 but are also
valuable for ACC100. 

v1: This serie introduces the PMD for the new bbdev device ACC101 (aka Mount Cirrus).
This is a derivative from previous Mount Bryce ACC100 which includes silicon
improvement, bug fixes, capacity improvement for 5GNR and feature improvement.

Nicolas Chautru (4):
  baseband/acc100: introduce PMD for ACC101
  baseband/acc100: modify validation code for ACC101
  baseband/acc100: configuration of ACC101 from PF
  baseband/acc100: add protection for some negative scenario

 app/test-bbdev/test_bbdev_perf.c         |  22 +-
 doc/guides/bbdevs/acc101.rst             | 237 ++++++++++++++
 doc/guides/bbdevs/features/acc101.ini    |  13 +
 doc/guides/bbdevs/index.rst              |   1 +
 doc/guides/rel_notes/release_22_07.rst   |   4 +
 drivers/baseband/acc100/rte_acc100_cfg.h |  17 +
 drivers/baseband/acc100/rte_acc100_pmd.c | 542 ++++++++++++++++++++++++++++++-
 drivers/baseband/acc100/rte_acc100_pmd.h |   6 +
 drivers/baseband/acc100/rte_acc101_pmd.h |  65 ++++
 drivers/baseband/acc100/version.map      |   2 +-
 10 files changed, 885 insertions(+), 24 deletions(-)
 create mode 100644 doc/guides/bbdevs/acc101.rst
 create mode 100644 doc/guides/bbdevs/features/acc101.ini
 create mode 100644 drivers/baseband/acc100/rte_acc101_pmd.h

Comments

Tom Rix May 19, 2022, 7:51 p.m. UTC | #1
On 5/16/22 1:48 PM, Nicolas Chautru wrote:
> v3: Feedback from Tom Rix: missing copyright, refactor bbdev-test section calling
> the configure companion function for ACC100/101, taking the Pmon commit out
> which is not directly required.

These address some of my comments.

The others, mostly around the treating accXXX as a family of devices and 
refactoring the common parts out have not been.

Tom

>
> v2: Based on good feedback from Thomas and David,
> now implementing the ACC101 PMD as a close derivative from
> existing ACC100 PMD with hooks to have different behaviour based on variant.
> This prevents code duplication and only rely on different functions and behaviour
> when hardware requires or support differences.
> Note that these are pending changes for ACC100 which would be specific to
> that device and not ACC101 but these can be managed based on the new
> implementation, ie. is_acc100() etc... (such incremental changes for ACC100
> trending 22.11 but confirming this is future proof).
> The serie also includes commits which were meant for ACC101 but are also
> valuable for ACC100.
>
> v1: This serie introduces the PMD for the new bbdev device ACC101 (aka Mount Cirrus).
> This is a derivative from previous Mount Bryce ACC100 which includes silicon
> improvement, bug fixes, capacity improvement for 5GNR and feature improvement.
>
> Nicolas Chautru (4):
>    baseband/acc100: introduce PMD for ACC101
>    baseband/acc100: modify validation code for ACC101
>    baseband/acc100: configuration of ACC101 from PF
>    baseband/acc100: add protection for some negative scenario
>
>   app/test-bbdev/test_bbdev_perf.c         |  22 +-
>   doc/guides/bbdevs/acc101.rst             | 237 ++++++++++++++
>   doc/guides/bbdevs/features/acc101.ini    |  13 +
>   doc/guides/bbdevs/index.rst              |   1 +
>   doc/guides/rel_notes/release_22_07.rst   |   4 +
>   drivers/baseband/acc100/rte_acc100_cfg.h |  17 +
>   drivers/baseband/acc100/rte_acc100_pmd.c | 542 ++++++++++++++++++++++++++++++-
>   drivers/baseband/acc100/rte_acc100_pmd.h |   6 +
>   drivers/baseband/acc100/rte_acc101_pmd.h |  65 ++++
>   drivers/baseband/acc100/version.map      |   2 +-
>   10 files changed, 885 insertions(+), 24 deletions(-)
>   create mode 100644 doc/guides/bbdevs/acc101.rst
>   create mode 100644 doc/guides/bbdevs/features/acc101.ini
>   create mode 100644 drivers/baseband/acc100/rte_acc101_pmd.h
>