From patchwork Thu Dec 8 23:19:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 120681 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05526A00C2; Fri, 9 Dec 2022 00:19:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7465842D2F; Fri, 9 Dec 2022 00:19:42 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id DDC9940E03 for ; Fri, 9 Dec 2022 00:19:38 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 5F3D920B83C2; Thu, 8 Dec 2022 15:19:37 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5F3D920B83C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1670541577; bh=UfhSOkSwJxMYqC+sajFqFV0idrCZIxJdLVsyanDXlGo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hIfyzlXHIEq3ipMFEB5gUY4sZyW6k7V4ruTGHoa1YLzxKrx5tUH+HH1dzcZgAM4W3 d/oj7PL8an4I2seV7S5m60xhmEU1UtYi8lliZb0NtwBJJmqHvdYePTSpqK8IdpHfmX 3YL9odnkGFxnnAmVuHkHKYRyk4MHbpoBoamPIbdE= From: Tyler Retzlaff To: dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com, stephen@networkplumber.org, olivier.matz@6wind.com, hofors@lysator.liu.se, Tyler Retzlaff Subject: [PATCH v4 0/3] eal: rte_ctrl_thread_create API replacement Date: Thu, 8 Dec 2022 15:19:33 -0800 Message-Id: <1670541576-18008-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1670271868-11364-1-git-send-email-roretzla@linux.microsoft.com> References: <1670271868-11364-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove rte_ctrl_thread_create API which exposes pthread_t and provide new rte_control_thread_create API based on EALs rte_thread_t. To limit compatibility regression risk and ease of removal of the existing rte_ctrl_thread_create in the future duplicate most of the existing implementation. The duplication will be removed when rte_ctrl_thread_create is finally duplicated/removed. The unit test for rte_ctrl_thread_create has been duplicated to exercise both the old and the new API during transition, as with the API the duplicate test will be removed when the rte_ctrl_thread_create API is removed. v4: * fix missing whitespace in deprecation notice text * remove comment in rte_control_thread_create implementation referring to sched_yield as requested by community feedback * add missing parameter name to function pointer declaration v3: * use {ctrl,control}_start_routine for start_routine field names * fix conditional evaluation style p == NULL instead of !p * tweak documentation comment for rte_control_thread_create - "the EAL threads are then excluded" - note RTE_MAX_THREAD_NAME_LEN preprocessor definition is the name size (including terminating NUL) limit * add missing cast to uintptr_t v2: * correct style error void * (*foo) -> void *(*foo) * place retval on lhs of comparison 0 != foo() -> foo() != 0 * add missing commit description on patch 3/3 * add cast uintptr_t to pthread_t where appropriate * fix doxygen @param names to match parameter names Tyler Retzlaff (3): eal: add rte control thread create API test: add rte control thread create API test eal: deprecate pthread control thread create API app/test/test_lcores.c | 42 +++++++++++++++++ doc/guides/rel_notes/deprecation.rst | 4 ++ lib/eal/common/eal_common_thread.c | 89 ++++++++++++++++++++++++++++++++---- lib/eal/include/rte_thread.h | 30 ++++++++++++ lib/eal/version.map | 3 ++ 5 files changed, 160 insertions(+), 8 deletions(-) Reviewed-by: Mattias Rönnblom