| Message ID | 20210323110749.2306452-1-qi.z.zhang@intel.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4AE6A0562; Tue, 23 Mar 2021 12:04:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88B5F140D48; Tue, 23 Mar 2021 12:04:31 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id C246C40143 for <dev@dpdk.org>; Tue, 23 Mar 2021 12:04:27 +0100 (CET) IronPort-SDR: xGTgBArplUsYxYgodApuOxtg023q+zs212Y/jHJUtb4cFLP3w3IZr7M4LlkF2ugTLuG9+DJSU8 SXKdgDwNzxJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="170419103" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="170419103" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 04:04:04 -0700 IronPort-SDR: e99U/BR/1Mah9rYey+HEqYqs6mYTao/Z2W/QIN0C9gbmJDfmlyq3JrNkvEPNY0trCMvD2CQ/gT YHIj/N41zZFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="414938393" Received: from dpdk51.sh.intel.com ([10.67.111.142]) by orsmga008.jf.intel.com with ESMTP; 23 Mar 2021 04:04:01 -0700 From: Qi Zhang <qi.z.zhang@intel.com> To: ferruh.yigit@intel.com Cc: dev@dpdk.org, thomas@monjalon.net, bruce.richardson@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com, Qi Zhang <qi.z.zhang@intel.com> Date: Tue, 23 Mar 2021 19:07:41 +0800 Message-Id: <20210323110749.2306452-1-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210310121626.2019863-1-qi.z.zhang@intel.com> References: <20210310121626.2019863-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v5 0/8] ether: refine debug build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
ether: refine debug build option
|
|
Message
Qi Zhang
March 23, 2021, 11:07 a.m. UTC
PMDs use RTE_LIBRTE_<PMD_NAME>_DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. Patch 1/8: introduces new compile options for data path debug in ether layer, PMD can choose to reuse them to avoid maintain their own. - RTE_ETHDEV_DEBUG_RX - RTE_ETHDEV_DEBUG_TX The undocumented RTE_LIBRTE_ETHDEV_DEBUG will a alias to both RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX for backward compatibility. Patch 2/8 - 8/8: refine the build option for Intel PMDs by using the new build options Qi Zhang (8): ether: refine debug build option net/fm10k: refine debug build option net/e1000: refine debug build option net/i40e: refine debug build option net/iavf: refine debug build option net/ice: refine debug build option net/ixgbe: refine debug build option net/igc: refine debug build option doc/guides/nics/build_and_test.rst | 16 ++++++++ drivers/net/e1000/e1000_logs.c | 17 ++------ drivers/net/e1000/e1000_logs.h | 13 +----- drivers/net/e1000/em_rxtx.c | 38 +++++++++--------- drivers/net/e1000/igb_rxtx.c | 2 +- drivers/net/fm10k/fm10k_ethdev.c | 7 +--- drivers/net/fm10k/fm10k_logs.h | 13 +----- drivers/net/fm10k/fm10k_rxtx.c | 8 ++-- drivers/net/i40e/i40e_ethdev.c | 7 +--- drivers/net/i40e/i40e_logs.h | 13 +----- drivers/net/i40e/i40e_rxtx.c | 16 ++++---- drivers/net/iavf/iavf_ethdev.c | 7 +--- drivers/net/iavf/iavf_log.h | 13 +----- drivers/net/iavf/iavf_rxtx.c | 8 ++-- drivers/net/ice/ice_ethdev.c | 7 +--- drivers/net/ice/ice_logs.h | 13 +----- drivers/net/ice/ice_rxtx.c | 20 +++++----- drivers/net/igc/igc_logs.h | 4 +- drivers/net/igc/igc_txrx.c | 2 +- drivers/net/ixgbe/ixgbe_ethdev.c | 7 +--- drivers/net/ixgbe/ixgbe_logs.h | 13 +----- drivers/net/ixgbe/ixgbe_rxtx.c | 64 +++++++++++++++--------------- lib/librte_ethdev/rte_ethdev.h | 22 ++++++---- 23 files changed, 137 insertions(+), 193 deletions(-)
Comments
Sorry, forgot adding change log.... v5: - Remove RTE_ETHDEV_DEBUG - Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG_RX|TX for backward compatibility. v4: - Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG in ethdev library for backward compatibility. - Not replace RTE_LIBRTE_ETHDEV_DEBUG in all PMDs. v3: - rename "RTE_LIBRTE_ETHDEV_xxx" to "RTE_ETHDEV_xxx" - move document from "overview.rst" page to "build_and_test.rst" - fix grammar issues. v2: - fix some coding style issues. > -----Original Message----- > From: Zhang, Qi Z <qi.z.zhang@intel.com> > Sent: Tuesday, March 23, 2021 7:08 PM > To: Yigit, Ferruh <ferruh.yigit@intel.com> > Cc: dev@dpdk.org; thomas@monjalon.net; Richardson, Bruce > <bruce.richardson@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>; Wu, > Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Guo, Jia > <jia.guo@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue > <haiyue.wang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com> > Subject: [PATCH v5 0/8] ether: refine debug build option > > PMDs use RTE_LIBRTE_<PMD_NAME>_DEBUG_RX|TX as build option to wrap > data path debug code. As .config has been removed since the meson build, It is > not friendly for new DPDK users to notice those debug options. > > Patch 1/8: introduces new compile options for data path debug in ether layer, > PMD can choose to reuse them to avoid maintain their own. > > - RTE_ETHDEV_DEBUG_RX > - RTE_ETHDEV_DEBUG_TX > > The undocumented RTE_LIBRTE_ETHDEV_DEBUG will a alias to both > RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX for backward > compatibility. > > Patch 2/8 - 8/8: refine the build option for Intel PMDs by using the new build > options > > Qi Zhang (8): > ether: refine debug build option > net/fm10k: refine debug build option > net/e1000: refine debug build option > net/i40e: refine debug build option > net/iavf: refine debug build option > net/ice: refine debug build option > net/ixgbe: refine debug build option > net/igc: refine debug build option > > doc/guides/nics/build_and_test.rst | 16 ++++++++ > drivers/net/e1000/e1000_logs.c | 17 ++------ > drivers/net/e1000/e1000_logs.h | 13 +----- > drivers/net/e1000/em_rxtx.c | 38 +++++++++--------- > drivers/net/e1000/igb_rxtx.c | 2 +- > drivers/net/fm10k/fm10k_ethdev.c | 7 +--- > drivers/net/fm10k/fm10k_logs.h | 13 +----- > drivers/net/fm10k/fm10k_rxtx.c | 8 ++-- > drivers/net/i40e/i40e_ethdev.c | 7 +--- > drivers/net/i40e/i40e_logs.h | 13 +----- > drivers/net/i40e/i40e_rxtx.c | 16 ++++---- > drivers/net/iavf/iavf_ethdev.c | 7 +--- > drivers/net/iavf/iavf_log.h | 13 +----- > drivers/net/iavf/iavf_rxtx.c | 8 ++-- > drivers/net/ice/ice_ethdev.c | 7 +--- > drivers/net/ice/ice_logs.h | 13 +----- > drivers/net/ice/ice_rxtx.c | 20 +++++----- > drivers/net/igc/igc_logs.h | 4 +- > drivers/net/igc/igc_txrx.c | 2 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 7 +--- > drivers/net/ixgbe/ixgbe_logs.h | 13 +----- > drivers/net/ixgbe/ixgbe_rxtx.c | 64 +++++++++++++++--------------- > lib/librte_ethdev/rte_ethdev.h | 22 ++++++---- > 23 files changed, 137 insertions(+), 193 deletions(-) > > -- > 2.26.2
On 3/23/2021 11:07 AM, Qi Zhang wrote: > PMDs use RTE_LIBRTE_<PMD_NAME>_DEBUG_RX|TX as build option to wrap > data path debug code. As .config has been removed since the meson build, > It is not friendly for new DPDK users to notice those debug options. > > Patch 1/8: introduces new compile options for data path debug in ether > layer, PMD can choose to reuse them to avoid maintain their own. > > - RTE_ETHDEV_DEBUG_RX > - RTE_ETHDEV_DEBUG_TX > > The undocumented RTE_LIBRTE_ETHDEV_DEBUG will a alias to > both RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX for backward > compatibility. > > Patch 2/8 - 8/8: refine the build option for Intel PMDs by using the > new build options > > Qi Zhang (8): > ether: refine debug build option > net/fm10k: refine debug build option > net/e1000: refine debug build option > net/i40e: refine debug build option > net/iavf: refine debug build option > net/ice: refine debug build option > net/ixgbe: refine debug build option > net/igc: refine debug build option > For series, Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Thomas, Andrew, if there is no objection I am planning to merge it soon.