mbox series

[v2,0/7] Refactor the NFP PMD

Message ID 20210716083545.34444-1-heinrich.kuhn@netronome.com (mailing list archive)
Headers show
Series Refactor the NFP PMD | expand

Message

Heinrich Kuhn July 16, 2021, 8:35 a.m. UTC
This patch set restructures the NFP PMD, aligning it more with the
common layout adopted by most other PMD's. Although the changes look
fairly large, functionally nothing is added or removed from the driver
and the existing code is mostly just reorganized into the familiar
structure seen in other PMD's. Apart form adopting the common PMD layout
this change should also aid in future feature development to the NFP
PMD. The previous layout where most of the logic resided in a single
file (nfp_net.c) would have become tedious to support going forward.

v2:
* Added missing sign-off's

Heinrich Kuhn (7):
  net/nfp: split rxtx headers into separate file
  net/nfp: move rxtx functions to their own file
  net/nfp: move CPP bridge to a separate file
  net/nfp: prototype common functions in header file
  net/nfp: move VF functions into new file
  net/nfp: move PF functions into new file
  net/nfp: batch file rename for consistency

 drivers/net/nfp/meson.build                   |    6 +-
 drivers/net/nfp/nfp_common.c                  | 1322 ++++++
 drivers/net/nfp/nfp_common.h                  |  413 ++
 drivers/net/nfp/nfp_cpp_bridge.c              |  392 ++
 drivers/net/nfp/nfp_cpp_bridge.h              |   36 +
 .../net/nfp/{nfp_net_ctrl.h => nfp_ctrl.h}    |    6 +-
 drivers/net/nfp/nfp_ethdev.c                  | 1099 +++++
 drivers/net/nfp/nfp_ethdev_vf.c               |  504 +++
 .../net/nfp/{nfp_net_logs.h => nfp_logs.h}    |    6 +-
 drivers/net/nfp/nfp_net.c                     | 3921 -----------------
 drivers/net/nfp/nfp_rxtx.c                    | 1002 +++++
 drivers/net/nfp/{nfp_net_pmd.h => nfp_rxtx.h} |  279 +-
 12 files changed, 4815 insertions(+), 4171 deletions(-)
 create mode 100644 drivers/net/nfp/nfp_common.c
 create mode 100644 drivers/net/nfp/nfp_common.h
 create mode 100644 drivers/net/nfp/nfp_cpp_bridge.c
 create mode 100644 drivers/net/nfp/nfp_cpp_bridge.h
 rename drivers/net/nfp/{nfp_net_ctrl.h => nfp_ctrl.h} (99%)
 create mode 100644 drivers/net/nfp/nfp_ethdev.c
 create mode 100644 drivers/net/nfp/nfp_ethdev_vf.c
 rename drivers/net/nfp/{nfp_net_logs.h => nfp_logs.h} (94%)
 delete mode 100644 drivers/net/nfp/nfp_net.c
 create mode 100644 drivers/net/nfp/nfp_rxtx.c
 rename drivers/net/nfp/{nfp_net_pmd.h => nfp_rxtx.h} (54%)

Comments

Thomas Monjalon July 23, 2021, 9:18 a.m. UTC | #1
16/07/2021 10:35, Heinrich Kuhn:
> This patch set restructures the NFP PMD, aligning it more with the
> common layout adopted by most other PMD's. Although the changes look
> fairly large, functionally nothing is added or removed from the driver
> and the existing code is mostly just reorganized into the familiar
> structure seen in other PMD's.

It seems this refactoring is destroying this firmware improvement:
	https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781

Please rebase carefully, keeping the behaviour really intact.

> Apart form adopting the common PMD layout
> this change should also aid in future feature development to the NFP
> PMD. The previous layout where most of the logic resided in a single
> file (nfp_net.c) would have become tedious to support going forward.
Heinrich Kuhn July 29, 2021, 1:48 p.m. UTC | #2
On 2021/07/23 11:18, Thomas Monjalon wrote:
> 16/07/2021 10:35, Heinrich Kuhn:
>> This patch set restructures the NFP PMD, aligning it more with the
>> common layout adopted by most other PMD's. Although the changes look
>> fairly large, functionally nothing is added or removed from the driver
>> and the existing code is mostly just reorganized into the familiar
>> structure seen in other PMD's.
> 
> It seems this refactoring is destroying this firmware improvement:
> 	https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781
> 
> Please rebase carefully, keeping the behaviour really intact.
> 
>> Apart form adopting the common PMD layout
>> this change should also aid in future feature development to the NFP
>> PMD. The previous layout where most of the logic resided in a single
>> file (nfp_net.c) would have become tedious to support going forward.
> 
> Thanks Thomas, I actually finished this work earlier in the month and
just missed your firmware helper addition. I posted v3 of this rework