mbox series

[0/2] eal/windows: restore mistakenly hidden API

Message ID 20210829021602.290466-1-dmitry.kozliuk@gmail.com (mailing list archive)
Headers show
Series eal/windows: restore mistakenly hidden API | expand

Message

Dmitry Kozlyuk Aug. 29, 2021, 2:16 a.m. UTC
Some functions were not exported, and UUID API not even built on Windows
for no compelling reason. This hasn't been an issue so far, because only
static build is currently available on Windows, however:
1) it's better to have fewer differences between platforms;
2) enabling shared build is planned for the near future.

I don't believe this patchset should be backported
because it doesn't fix any actual issue for 20.11.

Dmitry Kozlyuk (2):
  eal: remove Windows-specific list of common files
  eal/windows: fix export list

 lib/eal/common/meson.build | 63 +++++++++-----------------------------
 lib/eal/version.map        | 32 +++++++++----------
 2 files changed, 31 insertions(+), 64 deletions(-)

Comments

Menon, Ranjit Sept. 1, 2021, 7:35 p.m. UTC | #1
On 8/28/2021 7:16 PM, Dmitry Kozlyuk wrote:
> Some functions were not exported, and UUID API not even built on Windows
> for no compelling reason. This hasn't been an issue so far, because only
> static build is currently available on Windows, however:
> 1) it's better to have fewer differences between platforms;
> 2) enabling shared build is planned for the near future.
>
> I don't believe this patchset should be backported
> because it doesn't fix any actual issue for 20.11.
>
> Dmitry Kozlyuk (2):
>    eal: remove Windows-specific list of common files
>    eal/windows: fix export list
>
>   lib/eal/common/meson.build | 63 +++++++++-----------------------------
>   lib/eal/version.map        | 32 +++++++++----------
>   2 files changed, 31 insertions(+), 64 deletions(-)
Acked-by: Ranjit Menon <ranjit.menon@intel.com 
<mailto:ranjit.menon@intel.com>>
Thomas Monjalon Sept. 30, 2021, 8:48 p.m. UTC | #2
01/09/2021 21:35, Menon, Ranjit:
> On 8/28/2021 7:16 PM, Dmitry Kozlyuk wrote:
> > Some functions were not exported, and UUID API not even built on Windows
> > for no compelling reason. This hasn't been an issue so far, because only
> > static build is currently available on Windows, however:
> > 1) it's better to have fewer differences between platforms;
> > 2) enabling shared build is planned for the near future.
> >
> > I don't believe this patchset should be backported
> > because it doesn't fix any actual issue for 20.11.
> >
> > Dmitry Kozlyuk (2):
> >    eal: remove Windows-specific list of common files
> >    eal/windows: fix export list
> >
> Acked-by: Ranjit Menon <ranjit.menon@intel.com>

Applied, thanks.