mbox series

[v2,0/5] kvargs: promote or remove experimental api

Message ID 20210929213943.17817-1-olivier.matz@6wind.com (mailing list archive)
Headers
Series kvargs: promote or remove experimental api |

Message

Olivier Matz Sept. 29, 2021, 9:39 p.m. UTC 
  This patchset promotes 2 functions rte_kvargs_parse_delim() and
rte_kvargs_get() as stable.

It also replaces rte_kvargs_strcmp() by a new one
rte_kvargs_get_with_value(), which is easier to use.

v2
* remove rte_kvargs_strcmp from version.map

Olivier Matz (5):
  kvargs: promote delimited parsing as stable
  kvargs: promote get from key as stable
  kvargs: new function to get from key and value
  kvargs: remove experimental function to compare string
  kvargs: fix comments style

 drivers/bus/auxiliary/auxiliary_params.c |  9 ++--
 drivers/bus/vdev/vdev_params.c           | 13 +-----
 lib/kvargs/rte_kvargs.c                  | 32 +++++++------
 lib/kvargs/rte_kvargs.h                  | 59 ++++++++++++------------
 lib/kvargs/version.map                   |  9 ++--
 5 files changed, 57 insertions(+), 65 deletions(-)

Comments

David Marchand Sept. 30, 2021, 8:25 a.m. UTC | #1 
On Wed, Sep 29, 2021 at 11:40 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> This patchset promotes 2 functions rte_kvargs_parse_delim() and
> rte_kvargs_get() as stable.
>
> It also replaces rte_kvargs_strcmp() by a new one
> rte_kvargs_get_with_value(), which is easier to use.
>
> v2
> * remove rte_kvargs_strcmp from version.map
>
> Olivier Matz (5):
>   kvargs: promote delimited parsing as stable
>   kvargs: promote get from key as stable
>   kvargs: new function to get from key and value
>   kvargs: remove experimental function to compare string
>   kvargs: fix comments style

Thanks, for the series,
Reviewed-by: David Marchand <david.marchand@redhat.com>
Ray Kinsella Sept. 30, 2021, 9:57 a.m. UTC | #2 
On 30/09/2021 09:25, David Marchand wrote:
> On Wed, Sep 29, 2021 at 11:40 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>>
>> This patchset promotes 2 functions rte_kvargs_parse_delim() and
>> rte_kvargs_get() as stable.
>>
>> It also replaces rte_kvargs_strcmp() by a new one
>> rte_kvargs_get_with_value(), which is easier to use.
>>
>> v2
>> * remove rte_kvargs_strcmp from version.map
>>
>> Olivier Matz (5):
>>   kvargs: promote delimited parsing as stable
>>   kvargs: promote get from key as stable
>>   kvargs: new function to get from key and value
>>   kvargs: remove experimental function to compare string
>>   kvargs: fix comments style
> 
> Thanks, for the series,
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
Acked-by: Ray Kinsella <mdr@ashroe.eu>
David Marchand Sept. 30, 2021, 4:19 p.m. UTC | #3 
On Thu, Sep 30, 2021 at 11:57 AM Kinsella, Ray <mdr@ashroe.eu> wrote:
> On 30/09/2021 09:25, David Marchand wrote:
> > On Wed, Sep 29, 2021 at 11:40 PM Olivier Matz <olivier.matz@6wind.com> wrote:
> >>
> >> This patchset promotes 2 functions rte_kvargs_parse_delim() and
> >> rte_kvargs_get() as stable.
> >>
> >> It also replaces rte_kvargs_strcmp() by a new one
> >> rte_kvargs_get_with_value(), which is easier to use.
> >>
> >> v2
> >> * remove rte_kvargs_strcmp from version.map
> >>
> >> Olivier Matz (5):
> >>   kvargs: promote delimited parsing as stable
> >>   kvargs: promote get from key as stable
> >>   kvargs: new function to get from key and value
> >>   kvargs: remove experimental function to compare string
> >>   kvargs: fix comments style
> >
> > Thanks, for the series,
> > Reviewed-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
>

Added RN update and applied as discussed.
Thanks.