mbox series

[v7,0/8] new features for ipsec and security libraries

Message ID 20211001095017.3342431-1-radu.nicolau@intel.com (mailing list archive)
Headers
Series new features for ipsec and security libraries |

Message

Radu Nicolau Oct. 1, 2021, 9:50 a.m. UTC 
  Add support for:
TSO, NAT-T/UDP encapsulation, ESN
AES_CCM, CHACHA20_POLY1305 and AES_GMAC
SA telemetry
mbuf offload flags
Initial SQN value

Radu Nicolau (8):
  security: add ESN field to ipsec_xform
  ipsec: add support for AEAD algorithms
  security: add UDP params for IPsec NAT-T
  ipsec: add support for NAT-T
  mbuf: add IPsec ESP tunnel type
  ipsec: add transmit segmentation offload support
  ipsec: add support for SA telemetry
  ipsec: add support for initial SQN value

 lib/ipsec/crypto.h          | 137 +++++++++++++++++++++
 lib/ipsec/esp_inb.c         |  84 +++++++++++--
 lib/ipsec/esp_outb.c        | 210 ++++++++++++++++++++++++++++----
 lib/ipsec/ipsec_telemetry.c | 237 ++++++++++++++++++++++++++++++++++++
 lib/ipsec/meson.build       |   6 +-
 lib/ipsec/rte_ipsec.h       |  23 ++++
 lib/ipsec/rte_ipsec_sa.h    |   9 +-
 lib/ipsec/sa.c              | 117 +++++++++++++++---
 lib/ipsec/sa.h              |  15 +++
 lib/ipsec/version.map       |   9 ++
 lib/mbuf/rte_mbuf_core.h    |   1 +
 lib/security/rte_security.h |  15 +++
 12 files changed, 811 insertions(+), 52 deletions(-)
 create mode 100644 lib/ipsec/ipsec_telemetry.c

Comments

Akhil Goyal Oct. 8, 2021, 6:26 p.m. UTC | #1 
> Add support for:
> TSO, NAT-T/UDP encapsulation, ESN
> AES_CCM, CHACHA20_POLY1305 and AES_GMAC
> SA telemetry
> mbuf offload flags
> Initial SQN value
> 
> Radu Nicolau (8):
>   security: add ESN field to ipsec_xform
>   ipsec: add support for AEAD algorithms
>   security: add UDP params for IPsec NAT-T
>   ipsec: add support for NAT-T
>   mbuf: add IPsec ESP tunnel type
>   ipsec: add transmit segmentation offload support
>   ipsec: add support for SA telemetry
>   ipsec: add support for initial SQN value
> 
>  lib/ipsec/crypto.h          | 137 +++++++++++++++++++++
>  lib/ipsec/esp_inb.c         |  84 +++++++++++--
>  lib/ipsec/esp_outb.c        | 210 ++++++++++++++++++++++++++++----
>  lib/ipsec/ipsec_telemetry.c | 237 ++++++++++++++++++++++++++++++++++++
>  lib/ipsec/meson.build       |   6 +-
>  lib/ipsec/rte_ipsec.h       |  23 ++++
>  lib/ipsec/rte_ipsec_sa.h    |   9 +-
>  lib/ipsec/sa.c              | 117 +++++++++++++++---
>  lib/ipsec/sa.h              |  15 +++
>  lib/ipsec/version.map       |   9 ++
>  lib/mbuf/rte_mbuf_core.h    |   1 +
>  lib/security/rte_security.h |  15 +++
>  12 files changed, 811 insertions(+), 52 deletions(-)
>  create mode 100644 lib/ipsec/ipsec_telemetry.c
> 
> --
> v2: fixed lib/ipsec/version.map updates to show correct version
> v3: fixed build error and corrected misspelled email address
> v4: add doxygen comments for the IPsec telemetry APIs
>     update inline comments refering to the wrong RFC
> v5: update commit messages after feedback
>     update the UDP encapsulation patch to actually use the configured ports
> v6: fix initial SQN value
> v7: reworked the patches after feedback
> 
Release notes missing. At least some of the features deserve update in release notes.
For ipsec lib add a main bullet and then add sub-bullets for subsequent features.
Akhil Goyal Oct. 8, 2021, 8:33 p.m. UTC | #2 
> Subject: RE: [EXT] [PATCH v7 0/8] new features for ipsec and security libraries
> 
> > Add support for:
> > TSO, NAT-T/UDP encapsulation, ESN
> > AES_CCM, CHACHA20_POLY1305 and AES_GMAC
> > SA telemetry
> > mbuf offload flags
> > Initial SQN value
> >
> > Radu Nicolau (8):
> >   security: add ESN field to ipsec_xform
> >   ipsec: add support for AEAD algorithms
> >   security: add UDP params for IPsec NAT-T
> >   ipsec: add support for NAT-T
> >   mbuf: add IPsec ESP tunnel type
> >   ipsec: add transmit segmentation offload support
> >   ipsec: add support for SA telemetry
> >   ipsec: add support for initial SQN value
> >
> >  lib/ipsec/crypto.h          | 137 +++++++++++++++++++++
> >  lib/ipsec/esp_inb.c         |  84 +++++++++++--
> >  lib/ipsec/esp_outb.c        | 210 ++++++++++++++++++++++++++++----
> >  lib/ipsec/ipsec_telemetry.c | 237
> ++++++++++++++++++++++++++++++++++++
> >  lib/ipsec/meson.build       |   6 +-
> >  lib/ipsec/rte_ipsec.h       |  23 ++++
> >  lib/ipsec/rte_ipsec_sa.h    |   9 +-
> >  lib/ipsec/sa.c              | 117 +++++++++++++++---
> >  lib/ipsec/sa.h              |  15 +++
> >  lib/ipsec/version.map       |   9 ++
> >  lib/mbuf/rte_mbuf_core.h    |   1 +
> >  lib/security/rte_security.h |  15 +++
> >  12 files changed, 811 insertions(+), 52 deletions(-)
> >  create mode 100644 lib/ipsec/ipsec_telemetry.c
> >
> > --
> > v2: fixed lib/ipsec/version.map updates to show correct version
> > v3: fixed build error and corrected misspelled email address
> > v4: add doxygen comments for the IPsec telemetry APIs
> >     update inline comments refering to the wrong RFC
> > v5: update commit messages after feedback
> >     update the UDP encapsulation patch to actually use the configured ports
> > v6: fix initial SQN value
> > v7: reworked the patches after feedback
> >
> Release notes missing. At least some of the features deserve update in
> release notes.
> For ipsec lib add a main bullet and then add sub-bullets for subsequent
> features.

Also remove deprecation notices in the patch which added support for that.