mbox series

[v3,0/6] mempool: cleanup namespace

Message ID 20211019174022.2036272-1-andrew.rybchenko@oktetlabs.ru (mailing list archive)
Headers
Series mempool: cleanup namespace |

Message

Andrew Rybchenko Oct. 19, 2021, 5:40 p.m. UTC 
  Add RTE_ prefix to mempool API including internal. Keep old public API
with fallback to new defines. Internal API is just renamed.

v3:
    - fix typo
    - rebase on top of current main
    - add prefix to newly added MEMPOOL_F_NON_IO
    - fix deprecation usage
    - add Fixes tag the patch which deprecates unused macros

v2:
    - do not deprecate MEMPOOL_F_* flags
    - fix unintended usage of internal get/put helpers from bulk get/put

Andrew Rybchenko (6):
  mempool: avoid flags documentation in the next line
  mempool: add namespace prefix to flags
  mempool: add namespace to internal but still visible API
  mempool: make header size calculation internal
  mempool: add namespace to driver register macro
  mempool: deprecate unused defines

 app/proc-info/main.c                          |  17 +-
 app/test-pmd/parameters.c                     |   4 +-
 app/test/test_mempool.c                       |  18 +-
 doc/guides/contributing/documentation.rst     |   4 +-
 doc/guides/nics/mlx5.rst                      |   2 +-
 doc/guides/prog_guide/mempool_lib.rst         |   2 +-
 doc/guides/rel_notes/deprecation.rst          |  11 ++
 doc/guides/rel_notes/release_21_11.rst        |  14 +-
 drivers/common/mlx5/mlx5_common_mr.c          |   4 +-
 drivers/event/cnxk/cnxk_tim_evdev.c           |   2 +-
 drivers/event/octeontx/ssovf_worker.h         |   2 +-
 drivers/event/octeontx/timvf_evdev.c          |   2 +-
 drivers/event/octeontx2/otx2_tim_evdev.c      |   2 +-
 drivers/mempool/bucket/rte_mempool_bucket.c   |  10 +-
 drivers/mempool/cnxk/cn10k_mempool_ops.c      |   2 +-
 drivers/mempool/cnxk/cn9k_mempool_ops.c       |   2 +-
 drivers/mempool/dpaa/dpaa_mempool.c           |   2 +-
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c      |   2 +-
 .../mempool/octeontx/rte_mempool_octeontx.c   |   2 +-
 drivers/mempool/octeontx2/otx2_mempool_ops.c  |   2 +-
 drivers/mempool/ring/rte_mempool_ring.c       |  16 +-
 drivers/mempool/stack/rte_mempool_stack.c     |   4 +-
 drivers/net/cnxk/cn10k_rx.h                   |  12 +-
 drivers/net/cnxk/cn10k_tx.h                   |  30 ++--
 drivers/net/cnxk/cn9k_rx.h                    |  12 +-
 drivers/net/cnxk/cn9k_tx.h                    |  26 +--
 drivers/net/mlx5/mlx5_mr.c                    |   2 +-
 drivers/net/octeontx/octeontx_rxtx.h          |   4 +-
 drivers/net/octeontx2/otx2_ethdev.c           |   4 +-
 drivers/net/octeontx2/otx2_ethdev_sec_tx.h    |   2 +-
 drivers/net/octeontx2/otx2_rx.c               |   8 +-
 drivers/net/octeontx2/otx2_rx.h               |   4 +-
 drivers/net/octeontx2/otx2_tx.c               |  16 +-
 drivers/net/octeontx2/otx2_tx.h               |   4 +-
 drivers/net/thunderx/nicvf_ethdev.c           |   2 +-
 lib/mempool/rte_mempool.c                     |  58 +++----
 lib/mempool/rte_mempool.h                     | 164 +++++++++++-------
 lib/mempool/rte_mempool_ops.c                 |   2 +-
 lib/pdump/rte_pdump.c                         |   3 +-
 lib/vhost/iotlb.c                             |   4 +-
 40 files changed, 275 insertions(+), 208 deletions(-)

Comments

David Marchand Oct. 19, 2021, 8:09 p.m. UTC | #1 
On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> Add RTE_ prefix to mempool API including internal. Keep old public API
> with fallback to new defines. Internal API is just renamed.
>
> v3:
>     - fix typo
>     - rebase on top of current main
>     - add prefix to newly added MEMPOOL_F_NON_IO
>     - fix deprecation usage
>     - add Fixes tag the patch which deprecates unused macros

Thanks for the quick rebase.
I had rebased v2 before Olivier comments.
I spotted a little issue diffing with your v3 (see comment on patch
2), and fixed your v3 in a local branch of mine.
It passes my checks.

I'll wait tomorrow, to see if Olivier wants to send some acks.
David Marchand Oct. 20, 2021, 7:52 a.m. UTC | #2 
On Tue, Oct 19, 2021 at 10:09 PM David Marchand
<david.marchand@redhat.com> wrote:
> On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
> >
> > Add RTE_ prefix to mempool API including internal. Keep old public API
> > with fallback to new defines. Internal API is just renamed.
> >
> > v3:
> >     - fix typo
> >     - rebase on top of current main
> >     - add prefix to newly added MEMPOOL_F_NON_IO
> >     - fix deprecation usage
> >     - add Fixes tag the patch which deprecates unused macros
>
> I spotted a little issue diffing with your v3 (see comment on patch
> 2), and fixed your v3 in a local branch of mine.

Series applied with fix on patch 2.
Thanks.
Andrew Rybchenko Oct. 20, 2021, 7:52 a.m. UTC | #3 
On 10/19/21 11:09 PM, David Marchand wrote:
> On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>>
>> Add RTE_ prefix to mempool API including internal. Keep old public API
>> with fallback to new defines. Internal API is just renamed.
>>
>> v3:
>>     - fix typo
>>     - rebase on top of current main
>>     - add prefix to newly added MEMPOOL_F_NON_IO
>>     - fix deprecation usage
>>     - add Fixes tag the patch which deprecates unused macros
> 
> Thanks for the quick rebase.
> I had rebased v2 before Olivier comments.
> I spotted a little issue diffing with your v3 (see comment on patch
> 2), and fixed your v3 in a local branch of mine.
> It passes my checks.
> 
> I'll wait tomorrow, to see if Olivier wants to send some acks.

Olivier has just added missing Acks. Do you need v4 from me
with patch 2 fixes? Your changes LGTM and I don't mind if you
fix it on apply.
Andrew Rybchenko Oct. 20, 2021, 7:54 a.m. UTC | #4 
On 10/20/21 10:52 AM, David Marchand wrote:
> On Tue, Oct 19, 2021 at 10:09 PM David Marchand
> <david.marchand@redhat.com> wrote:
>> On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko
>> <andrew.rybchenko@oktetlabs.ru> wrote:
>>>
>>> Add RTE_ prefix to mempool API including internal. Keep old public API
>>> with fallback to new defines. Internal API is just renamed.
>>>
>>> v3:
>>>     - fix typo
>>>     - rebase on top of current main
>>>     - add prefix to newly added MEMPOOL_F_NON_IO
>>>     - fix deprecation usage
>>>     - add Fixes tag the patch which deprecates unused macros
>>
>> I spotted a little issue diffing with your v3 (see comment on patch
>> 2), and fixed your v3 in a local branch of mine.
> 
> Series applied with fix on patch 2.
> Thanks.

Sorry, I've not noticed this reply before my question.
Many thanks that you agreed to accept these patches
that late.
David Marchand Oct. 20, 2021, 8:07 a.m. UTC | #5 
On Wed, Oct 20, 2021 at 9:52 AM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
> > Thanks for the quick rebase.
> > I had rebased v2 before Olivier comments.
> > I spotted a little issue diffing with your v3 (see comment on patch
> > 2), and fixed your v3 in a local branch of mine.
> > It passes my checks.
> >
> > I'll wait tomorrow, to see if Olivier wants to send some acks.
>
> Olivier has just added missing Acks. Do you need v4 from me
> with patch 2 fixes? Your changes LGTM and I don't mind if you
> fix it on apply.

I applied Olivier acks.
Patches are pushed if you want to double check, but I think we are good.


Now looking at mbuf offload namespace series... :-)