mbox series

[v2,0/9] ethdev: cosmetic fixes

Message ID 20211020074257.2349486-1-andrew.rybchenko@oktetlabs.ru (mailing list archive)
Headers
Series ethdev: cosmetic fixes |

Message

Andrew Rybchenko Oct. 20, 2021, 7:42 a.m. UTC
  Sicne rte_eth_dev and rte_eth_dev_data structures are just moved
right now is a good chance to make a cleanup. Moreover ethdev is
or will be shuffled a lot in the release, so do cleanup in all
files.

Maybe at least some fixes from below could be accepted.

Spelling is fixed in log messages as well. Hopefully it isn ot a
problem, but let me know if I'm wrong and I'll avoid it in the
next version.

Since changes are cosmetic no Fixes tags and no backporting to
stable.

Andrew Rybchenko (9):
  ethdev: avoid documentation in next lines
  ethdev: fix Rx/Tx spelling
  ethdev: fix Ethernet spelling
  ethdev: fix DCB and VMDq spelling
  ethdev: fix VLAN spelling including VLAN ID case
  ethdev: fix ID spelling in comments and log messages
  ethdev: remove reserved fields from internal structures
  ethdev: make device and data structures readable
  ethdev: remove full stop after short comments and references

 lib/ethdev/ethdev_driver.h   | 380 ++++++++++++-------------
 lib/ethdev/ethdev_pci.h      |   2 +-
 lib/ethdev/ethdev_private.h  |   2 +-
 lib/ethdev/ethdev_profile.c  |   6 +-
 lib/ethdev/ethdev_vdev.h     |   2 +-
 lib/ethdev/rte_class_eth.c   |   2 +-
 lib/ethdev/rte_eth_ctrl.h    |   2 +-
 lib/ethdev/rte_ethdev.c      |  66 ++---
 lib/ethdev/rte_ethdev.h      | 518 ++++++++++++++++++-----------------
 lib/ethdev/rte_ethdev_core.h |  20 +-
 lib/ethdev/rte_flow.h        |  48 ++--
 lib/ethdev/rte_mtr_driver.h  |  30 +-
 lib/ethdev/rte_tm.h          |  14 +-
 13 files changed, 558 insertions(+), 534 deletions(-)
  

Comments

Ferruh Yigit Oct. 20, 2021, 9:31 a.m. UTC | #1
On 10/20/2021 8:42 AM, Andrew Rybchenko wrote:
> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved
> right now is a good chance to make a cleanup. Moreover ethdev is
> or will be shuffled a lot in the release, so do cleanup in all
> files.
> 
> Maybe at least some fixes from below could be accepted.
> 
> Spelling is fixed in log messages as well. Hopefully it isn ot a
> problem, but let me know if I'm wrong and I'll avoid it in the
> next version.
> 
> Since changes are cosmetic no Fixes tags and no backporting to
> stable.
> 
> Andrew Rybchenko (9):
>    ethdev: avoid documentation in next lines
>    ethdev: fix Rx/Tx spelling
>    ethdev: fix Ethernet spelling
>    ethdev: fix DCB and VMDq spelling
>    ethdev: fix VLAN spelling including VLAN ID case
>    ethdev: fix ID spelling in comments and log messages
>    ethdev: remove reserved fields from internal structures
>    ethdev: make device and data structures readable
>    ethdev: remove full stop after short comments and references
> 

I am OK with changes in principal, will look more detailed later.

Only patch 9/9 also can be extended to whole file, instead of just
moved structures.
  
Andrew Rybchenko Oct. 20, 2021, 11:55 a.m. UTC | #2
On 10/20/21 12:31 PM, Ferruh Yigit wrote:
> On 10/20/2021 8:42 AM, Andrew Rybchenko wrote:
>> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved
>> right now is a good chance to make a cleanup. Moreover ethdev is
>> or will be shuffled a lot in the release, so do cleanup in all
>> files.
>>
>> Maybe at least some fixes from below could be accepted.
>>
>> Spelling is fixed in log messages as well. Hopefully it isn ot a
>> problem, but let me know if I'm wrong and I'll avoid it in the
>> next version.
>>
>> Since changes are cosmetic no Fixes tags and no backporting to
>> stable.
>>
>> Andrew Rybchenko (9):
>>    ethdev: avoid documentation in next lines
>>    ethdev: fix Rx/Tx spelling
>>    ethdev: fix Ethernet spelling
>>    ethdev: fix DCB and VMDq spelling
>>    ethdev: fix VLAN spelling including VLAN ID case
>>    ethdev: fix ID spelling in comments and log messages
>>    ethdev: remove reserved fields from internal structures
>>    ethdev: make device and data structures readable
>>    ethdev: remove full stop after short comments and references
>>
> 
> I am OK with changes in principal, will look more detailed later.
> 
> Only patch 9/9 also can be extended to whole file, instead of just
> moved structures.

OK, I'll send v3 in an hour.