Message ID | 20211025144725.115828-1-miao.li@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BFCDA0C47; Mon, 25 Oct 2021 08:43:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1876D407FF; Mon, 25 Oct 2021 08:43:35 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 24EBB4003E for <dev@dpdk.org>; Mon, 25 Oct 2021 08:43:32 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10147"; a="228339922" X-IronPort-AV: E=Sophos;i="5.87,179,1631602800"; d="scan'208";a="228339922" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2021 23:43:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,179,1631602800"; d="scan'208";a="446095484" Received: from limiao-icelake.sh.intel.com ([10.67.115.126]) by orsmga006.jf.intel.com with ESMTP; 24 Oct 2021 23:43:30 -0700 From: Miao Li <miao.li@intel.com> To: dev@dpdk.org Cc: chenbo.xia@intel.com, maxime.coquelin@redhat.com, miao.li@intel.com Date: Mon, 25 Oct 2021 14:47:20 +0000 Message-Id: <20211025144725.115828-1-miao.li@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211018141638.5916-1-miao.li@intel.com> References: <20211018141638.5916-1-miao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v8 0/5] Support power monitor in virtio/vhost PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | Support power monitor in virtio/vhost PMD | |
Message
Li, Miao
Oct. 25, 2021, 2:47 p.m. UTC
This patchset implements rte_power_monitor API in virtio and vhost PMD to reduce power consumption when no packet come in. This API can be called and tested in l3fwd-power after adding vhost and virtio support in l3fwd-power and ignoring the rx queue information check in queue_stopped(). v8: -rebase on lastest repo -update the release note -modify some titles -update commit log -add the fixes and stable tags v7: -fix coding style issues -rebase on lastest repo v6: -modify comment -remove extra space -fix IPv4 CKSUM check v5: -rebase on lastest repo v4: -modify comment -update the release note -add IPv4 CKSUM check v3: -fix some code format issues -fix spelling mistake v2: -remove flag and add match and size in rte_vhost_power_monitor_cond -modify power callback function -add dev and queue id check and remove unnecessary check -fix the assignment of pmc->size -update port configuration according to the device information and remove adding command line arguments -modify some titles Miao Li (5): net/virtio: support power monitor vhost: add power monitor support API net/vhost: support power monitor power: modify return of queue_stopped examples/l3fwd-power: support virtio/vhost doc/guides/rel_notes/release_21_11.rst | 12 ++++++ drivers/net/vhost/rte_eth_vhost.c | 40 ++++++++++++++++++ drivers/net/virtio/virtio_ethdev.c | 56 ++++++++++++++++++++++++++ examples/l3fwd-power/main.c | 15 ++++++- lib/power/rte_power_pmd_mgmt.c | 9 ++++- lib/vhost/rte_vhost.h | 42 +++++++++++++++++++ lib/vhost/version.map | 3 ++ lib/vhost/vhost.c | 38 +++++++++++++++++ 8 files changed, 212 insertions(+), 3 deletions(-)
Comments
Hi Ferruh, > -----Original Message----- > From: Li, Miao <miao.li@intel.com> > Sent: Monday, October 25, 2021 10:47 PM > To: dev@dpdk.org > Cc: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com; Li, Miao > <miao.li@intel.com> > Subject: [PATCH v8 0/5] Support power monitor in virtio/vhost PMD > > This patchset implements rte_power_monitor API in virtio and vhost PMD > to reduce power consumption when no packet come in. This API can be > called and tested in l3fwd-power after adding vhost and virtio support > in l3fwd-power and ignoring the rx queue information check in > queue_stopped(). > > v8: > -rebase on lastest repo > -update the release note > -modify some titles > -update commit log > -add the fixes and stable tags The new version LGTM. Will you pick up directly to next-net if you also think it's good? Thanks, Chenbo > -- > 2.25.1
Hi Chenbo, On 10/25/21 09:06, Xia, Chenbo wrote: > Hi Ferruh, > >> -----Original Message----- >> From: Li, Miao <miao.li@intel.com> >> Sent: Monday, October 25, 2021 10:47 PM >> To: dev@dpdk.org >> Cc: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com; Li, Miao >> <miao.li@intel.com> >> Subject: [PATCH v8 0/5] Support power monitor in virtio/vhost PMD >> >> This patchset implements rte_power_monitor API in virtio and vhost PMD >> to reduce power consumption when no packet come in. This API can be >> called and tested in l3fwd-power after adding vhost and virtio support >> in l3fwd-power and ignoring the rx queue information check in >> queue_stopped(). >> >> v8: >> -rebase on lastest repo >> -update the release note >> -modify some titles >> -update commit log >> -add the fixes and stable tags > > The new version LGTM. Will you pick up directly to next-net if you also think > it's good? I will pick it in my next pull request for -rc2. Thanks, Maxime > Thanks, > Chenbo > >> -- >> 2.25.1 >
On 10/25/21 16:47, Miao Li wrote: > This patchset implements rte_power_monitor API in virtio and vhost PMD > to reduce power consumption when no packet come in. This API can be > called and tested in l3fwd-power after adding vhost and virtio support > in l3fwd-power and ignoring the rx queue information check in > queue_stopped(). > > v8: > -rebase on lastest repo > -update the release note > -modify some titles > -update commit log > -add the fixes and stable tags > > v7: > -fix coding style issues > -rebase on lastest repo > > v6: > -modify comment > -remove extra space > -fix IPv4 CKSUM check > > v5: > -rebase on lastest repo > > v4: > -modify comment > -update the release note > -add IPv4 CKSUM check > > v3: > -fix some code format issues > -fix spelling mistake > > v2: > -remove flag and add match and size in rte_vhost_power_monitor_cond > -modify power callback function > -add dev and queue id check and remove unnecessary check > -fix the assignment of pmc->size > -update port configuration according to the device information and > remove adding command line arguments > -modify some titles > > Miao Li (5): > net/virtio: support power monitor > vhost: add power monitor support API > net/vhost: support power monitor > power: modify return of queue_stopped > examples/l3fwd-power: support virtio/vhost > > doc/guides/rel_notes/release_21_11.rst | 12 ++++++ > drivers/net/vhost/rte_eth_vhost.c | 40 ++++++++++++++++++ > drivers/net/virtio/virtio_ethdev.c | 56 ++++++++++++++++++++++++++ > examples/l3fwd-power/main.c | 15 ++++++- > lib/power/rte_power_pmd_mgmt.c | 9 ++++- > lib/vhost/rte_vhost.h | 42 +++++++++++++++++++ > lib/vhost/version.map | 3 ++ > lib/vhost/vhost.c | 38 +++++++++++++++++ > 8 files changed, 212 insertions(+), 3 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime