mbox series

[v8,0/5] Support power monitor in virtio/vhost PMD

Message ID 20211025144725.115828-1-miao.li@intel.com (mailing list archive)
Headers
Series Support power monitor in virtio/vhost PMD |

Message

Li, Miao Oct. 25, 2021, 2:47 p.m. UTC
  This patchset implements rte_power_monitor API in virtio and vhost PMD
to reduce power consumption when no packet come in. This API can be
called and tested in l3fwd-power after adding vhost and virtio support
in l3fwd-power and ignoring the rx queue information check in
queue_stopped().

v8:
-rebase on lastest repo
-update the release note
-modify some titles
-update commit log
-add the fixes and stable tags

v7:
-fix coding style issues
-rebase on lastest repo

v6:
-modify comment
-remove extra space
-fix IPv4 CKSUM check

v5:
-rebase on lastest repo

v4:
-modify comment
-update the release note
-add IPv4 CKSUM check

v3:
-fix some code format issues
-fix spelling mistake

v2:
-remove flag and add match and size in rte_vhost_power_monitor_cond
-modify power callback function
-add dev and queue id check and remove unnecessary check
-fix the assignment of pmc->size
-update port configuration according to the device information and
remove adding command line arguments
-modify some titles

Miao Li (5):
  net/virtio: support power monitor
  vhost: add power monitor support API
  net/vhost: support power monitor
  power: modify return of queue_stopped
  examples/l3fwd-power: support virtio/vhost

 doc/guides/rel_notes/release_21_11.rst | 12 ++++++
 drivers/net/vhost/rte_eth_vhost.c      | 40 ++++++++++++++++++
 drivers/net/virtio/virtio_ethdev.c     | 56 ++++++++++++++++++++++++++
 examples/l3fwd-power/main.c            | 15 ++++++-
 lib/power/rte_power_pmd_mgmt.c         |  9 ++++-
 lib/vhost/rte_vhost.h                  | 42 +++++++++++++++++++
 lib/vhost/version.map                  |  3 ++
 lib/vhost/vhost.c                      | 38 +++++++++++++++++
 8 files changed, 212 insertions(+), 3 deletions(-)
  

Comments

Chenbo Xia Oct. 25, 2021, 7:06 a.m. UTC | #1
Hi Ferruh,

> -----Original Message-----
> From: Li, Miao <miao.li@intel.com>
> Sent: Monday, October 25, 2021 10:47 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com; Li, Miao
> <miao.li@intel.com>
> Subject: [PATCH v8 0/5] Support power monitor in virtio/vhost PMD
> 
> This patchset implements rte_power_monitor API in virtio and vhost PMD
> to reduce power consumption when no packet come in. This API can be
> called and tested in l3fwd-power after adding vhost and virtio support
> in l3fwd-power and ignoring the rx queue information check in
> queue_stopped().
> 
> v8:
> -rebase on lastest repo
> -update the release note
> -modify some titles
> -update commit log
> -add the fixes and stable tags

The new version LGTM. Will you pick up directly to next-net if you also think
it's good?

Thanks,
Chenbo

> --
> 2.25.1
  
Maxime Coquelin Oct. 28, 2021, 8:03 a.m. UTC | #2
Hi Chenbo,

On 10/25/21 09:06, Xia, Chenbo wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Li, Miao <miao.li@intel.com>
>> Sent: Monday, October 25, 2021 10:47 PM
>> To: dev@dpdk.org
>> Cc: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com; Li, Miao
>> <miao.li@intel.com>
>> Subject: [PATCH v8 0/5] Support power monitor in virtio/vhost PMD
>>
>> This patchset implements rte_power_monitor API in virtio and vhost PMD
>> to reduce power consumption when no packet come in. This API can be
>> called and tested in l3fwd-power after adding vhost and virtio support
>> in l3fwd-power and ignoring the rx queue information check in
>> queue_stopped().
>>
>> v8:
>> -rebase on lastest repo
>> -update the release note
>> -modify some titles
>> -update commit log
>> -add the fixes and stable tags
> 
> The new version LGTM. Will you pick up directly to next-net if you also think
> it's good?

I will pick it in my next pull request for -rc2.

Thanks,
Maxime

> Thanks,
> Chenbo
> 
>> --
>> 2.25.1
>
  
Maxime Coquelin Oct. 29, 2021, 10:34 a.m. UTC | #3
On 10/25/21 16:47, Miao Li wrote:
> This patchset implements rte_power_monitor API in virtio and vhost PMD
> to reduce power consumption when no packet come in. This API can be
> called and tested in l3fwd-power after adding vhost and virtio support
> in l3fwd-power and ignoring the rx queue information check in
> queue_stopped().
> 
> v8:
> -rebase on lastest repo
> -update the release note
> -modify some titles
> -update commit log
> -add the fixes and stable tags
> 
> v7:
> -fix coding style issues
> -rebase on lastest repo
> 
> v6:
> -modify comment
> -remove extra space
> -fix IPv4 CKSUM check
> 
> v5:
> -rebase on lastest repo
> 
> v4:
> -modify comment
> -update the release note
> -add IPv4 CKSUM check
> 
> v3:
> -fix some code format issues
> -fix spelling mistake
> 
> v2:
> -remove flag and add match and size in rte_vhost_power_monitor_cond
> -modify power callback function
> -add dev and queue id check and remove unnecessary check
> -fix the assignment of pmc->size
> -update port configuration according to the device information and
> remove adding command line arguments
> -modify some titles
> 
> Miao Li (5):
>    net/virtio: support power monitor
>    vhost: add power monitor support API
>    net/vhost: support power monitor
>    power: modify return of queue_stopped
>    examples/l3fwd-power: support virtio/vhost
> 
>   doc/guides/rel_notes/release_21_11.rst | 12 ++++++
>   drivers/net/vhost/rte_eth_vhost.c      | 40 ++++++++++++++++++
>   drivers/net/virtio/virtio_ethdev.c     | 56 ++++++++++++++++++++++++++
>   examples/l3fwd-power/main.c            | 15 ++++++-
>   lib/power/rte_power_pmd_mgmt.c         |  9 ++++-
>   lib/vhost/rte_vhost.h                  | 42 +++++++++++++++++++
>   lib/vhost/version.map                  |  3 ++
>   lib/vhost/vhost.c                      | 38 +++++++++++++++++
>   8 files changed, 212 insertions(+), 3 deletions(-)
> 


Applied to dpdk-next-virtio/main.

Thanks,
Maxime