mbox series

[0/2] fix level configuration in compress

Message ID 20211026015242.21156-1-rzidane@nvidia.com (mailing list archive)
Headers
Series fix level configuration in compress |

Message

Raja Zidane Oct. 26, 2021, 1:52 a.m. UTC 
  The mlx5 compress PMD uses HW acceleration for the compress operations.
The mlx5 HW device has no level style mode, which does a tradeoff between
throughput and compression ratio, unlike SW drivers where the CPU is doing
the compress, and more CPU effort can cause a better compression ratio.
The mlx5 driver wrongly defined the Huffman block size configuration
according to the level that doesn't fill the level API requirement for
the tradeoff.

Remove the effect of the level configuration in compress operation. 
Add "log-block-size" devarg to select compression block size manually.

Raja Zidane (2):
  compress/mlx5: fix level configuration in compress
  compress/mlx5: add block size devarg

 doc/guides/compressdevs/mlx5.rst       | 10 ++++
 doc/guides/rel_notes/release_21_11.rst |  2 +
 drivers/compress/mlx5/mlx5_compress.c  | 79 +++++++++++++++++++++-----
 3 files changed, 76 insertions(+), 15 deletions(-)

Comments

Akhil Goyal Oct. 31, 2021, 7:49 p.m. UTC | #1 
> The mlx5 compress PMD uses HW acceleration for the compress operations.
> The mlx5 HW device has no level style mode, which does a tradeoff between
> throughput and compression ratio, unlike SW drivers where the CPU is doing
> the compress, and more CPU effort can cause a better compression ratio.
> The mlx5 driver wrongly defined the Huffman block size configuration
> according to the level that doesn't fill the level API requirement for
> the tradeoff.
> 
> Remove the effect of the level configuration in compress operation.
> Add "log-block-size" devarg to select compression block size manually.
> 
Applied to dpdk-next-crypto

Thanks.