From patchwork Tue Oct 26 01:52:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raja Zidane X-Patchwork-Id: 102799 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A410A0C47; Tue, 26 Oct 2021 03:53:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECA3240A4B; Tue, 26 Oct 2021 03:53:08 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2068.outbound.protection.outlook.com [40.107.244.68]) by mails.dpdk.org (Postfix) with ESMTP id 4A0AC4003E for ; Tue, 26 Oct 2021 03:53:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hKiJ8capkCz05cbZRuT9dFP5G5GJlx/+GDEPWC4nvdmJRxFtvY2OSaZDHpE+kFRLfEWMIItNqwwJoeLPAiqCWxmue+3SUhZ5im+HZcKupQfHLOou8ojeyMWThESMsCazX46s+g2wobEeDyfxgJEnUSU+/R+SUhkbJWzx1S7ZPDorWLRlYWAC/89fi0m/NnbEOvuEXqyuD0niLWL7fa5bbz5uStrlzIDBVLIQvjtchoIpMhozDHmcMtQLOup93OkAER5TjEr2WR2M734m75aGomoqc9WfOVZPuZkLIcZQzlTyUa+bv09NBmW53Vy2+S43uPAytafFMO2AQ+wl09tI2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TaQhoBkUAkrmB+jV10hFc4HJ7GfaoWKLoebRk4j6IEQ=; b=FpNaBeo5PoQCD7gQoq7Z3gFUWKrKqjDeS71iV8IBU2EvqqxexfLt7LhALLqh5ORbDRlE2YiieAahNql7bChKp9pfByoaLG0ibUSyqI32GhgYNgyR+svbXG3cp3+bx3fVzQX89eq2ldHibUbDBqDdF+f0ZEYw6KJZYex1/+Ywu1sA/yzp4XS5OdDi9W5e/XuVKx8K/tVTOu5ueYeNbFE7CstS5Tn5sSY+w4omPMYCtsxaVVKzQK7B4otSRSxPa8/ASIJCBFZjTt4fLwGdik7k3SqC+n85243KA4htX73PCuytrpzwNKuuxotjcAJwb0DgMMaxg5jJNvjA3Dm/MJIdWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TaQhoBkUAkrmB+jV10hFc4HJ7GfaoWKLoebRk4j6IEQ=; b=nlA+vEsbpT9+NGCL3yT9U8JqkVAIftBWgfh1phPxXIQeGeiSmMQQxlVkR430n5+88O2/EIDQLeP++yWMVaAWKbLKBZx3+C+wW7Ur6gN3AjVijWxMr7CzX0j79NFADgQh7YwrnhrTSAf3sAN6KTZRJN69qbWGxUTE9fSoxCFU3AfjBBuGQOsu1wKQnSMIAINI7RKfjqSrDH0wr0Kt64chOpjSjr4cgjZuP//GamqB/gq9V0h26idRT+7sYNGpXCEWMA45w7mOwaGj+UBtNts3BOcOkknWvkg0VT4qQbFVWkkeI5n4oCkUePPNHOFAJTCzvNLXcWlDSaOSyo/OMEy2pg== Received: from MWHPR12CA0072.namprd12.prod.outlook.com (2603:10b6:300:103::34) by MWHPR12MB1678.namprd12.prod.outlook.com (2603:10b6:301:b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Tue, 26 Oct 2021 01:53:05 +0000 Received: from CO1NAM11FT028.eop-nam11.prod.protection.outlook.com (2603:10b6:300:103:cafe::a0) by MWHPR12CA0072.outlook.office365.com (2603:10b6:300:103::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Tue, 26 Oct 2021 01:53:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT028.mail.protection.outlook.com (10.13.175.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4628.16 via Frontend Transport; Tue, 26 Oct 2021 01:53:04 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 26 Oct 2021 01:53:03 +0000 From: Raja Zidane To: Date: Tue, 26 Oct 2021 01:52:40 +0000 Message-ID: <20211026015242.21156-1-rzidane@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 67a5ab0e-2686-4714-5365-08d9982359ea X-MS-TrafficTypeDiagnostic: MWHPR12MB1678: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oDbSTklhBLbDOp/IpAn5+WjGwtQFGJi6L9UzISzOuumZJRXw4hjXW/5X8GhW5dDnoDkQpYQMOFdDGv6Ddnp1pNYUgWMNj/6rhkXh33GP88qwGD6RgT6BDOD5QnlNyVSJawNh7YZmv9Q6n8avwpeOhWKPoh6of1wlTtXob2JskinpKuGaiiiRv4nOgJ/CFeGVT9R+SbVd6uAAE7vtYLUbL/t65qLEpOLNet/iWac8BmoxrhNceZgYIVgmvdWdDorIhPPiWd4OegcwMMT2DCaRNDRRUlPbcV/3CgF3eR8ejW6FzjribyDjDLSEt1KZZjklTUXp+iuAciefkpn1WsbF6lLF2+An5XvX49wIwTMkQBub0oFvcz5Uc3mtlkDFJmys3piOYtpbJqvGnqFlpgPz53VmX2p8n5oa5Zl+J8SQYcUrpq+1AgUPqY8jffR8oh+t0caaAYoiJqe6WmnuGn/GhToEShkwDUuzpNSV19wVDt2MyoVa4SRtnBS/+hBOVzF5q2v1o14UYW2zcCeNp/LeEC7sU0xK5Tu/0tKcHXBpvO4DMM+WcGb16Xg/Yv5qptm+ldfpzRZsxs+DWpjXXWUEFcYwE2PtSnEVxuffgF4wbPMdS88Xkvsg0sgb31+IMXVKF8TBK11iQ0uD8CP4WDyF21rb5PL6fsHraCPE+U/OVQj9IttEdpeu5YzuzIQEGzqX X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(7636003)(55016002)(7696005)(4743002)(70586007)(70206006)(6286002)(8936002)(2906002)(5660300002)(26005)(426003)(16526019)(6916009)(83380400001)(316002)(356005)(186003)(86362001)(336012)(36860700001)(36756003)(82310400003)(6666004)(1076003)(47076005)(2616005)(508600001)(8676002)(4744005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 01:53:04.8182 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 67a5ab0e-2686-4714-5365-08d9982359ea X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT028.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1678 Subject: [dpdk-dev] [PATCH 0/2] fix level configuration in compress X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The mlx5 compress PMD uses HW acceleration for the compress operations. The mlx5 HW device has no level style mode, which does a tradeoff between throughput and compression ratio, unlike SW drivers where the CPU is doing the compress, and more CPU effort can cause a better compression ratio. The mlx5 driver wrongly defined the Huffman block size configuration according to the level that doesn't fill the level API requirement for the tradeoff. Remove the effect of the level configuration in compress operation. Add "log-block-size" devarg to select compression block size manually. Raja Zidane (2): compress/mlx5: fix level configuration in compress compress/mlx5: add block size devarg doc/guides/compressdevs/mlx5.rst | 10 ++++ doc/guides/rel_notes/release_21_11.rst | 2 + drivers/compress/mlx5/mlx5_compress.c | 79 +++++++++++++++++++++----- 3 files changed, 76 insertions(+), 15 deletions(-)