[v2,00/15] vhost: clean-up and simplify async implementation

  This series aims at cleaning and simplifying the async
enqueue path. I think it makes the code easier to
understand, and is necessary before integrating new
changes.

I may have more reworks to propose in next revisions,
but I wanted to share my current status early so that
you have time to review/test it.

It is only compile-tested, as I don't have HW with IOAT
support to test it.

Changes in v2:
==============
- Print once when max number of iovec is reached (Jiayu)
- Increase number of IOVECs from 512 to 2048 (Jiayu)
- Fix Vhost example build when raw/ioat is disabled

Changes in v1:
==============
- Fix missing iovec index increment (Jiayu)
- Remove unneeded sanity check on IOV iter index (Jiayu)
- Fix async->pkts_info allocation check (Jiayu)
- Prevent NULL pointer dereference on async metadata cleanup (Jiayu)

*** BLURB HERE ***

Maxime Coquelin (15):
  vhost: move async data in a dedicated structure
  vhost: hide inflight async structure
  vhost: simplify async IO vectors
  vhost: simplify async IO vectors iterators
  vhost: remove async batch threshold
  vhost: introduce specific iovec structure
  vhost: remove useless fields in async iterator struct
  vhost: improve IO vector logic
  vhost: remove notion of async descriptor
  vhost: simplify async enqueue completion
  vhost: simplify getting the first in-flight index
  vhost: prepare async for mbuf to desc refactoring
  vhost: prepare sync for mbuf to desc refactoring
  vhost: merge sync and async mbuf to desc filling
  vhost: increase number of async IO vectors

 examples/vhost/ioat.c       |  30 +-
 examples/vhost/ioat.h       |   4 +-
 lib/vhost/rte_vhost_async.h |  42 +--
 lib/vhost/vhost.c           | 130 +++----
 lib/vhost/vhost.h           |  67 ++--
 lib/vhost/vhost_user.c      |   4 +-
 lib/vhost/virtio_net.c      | 697 ++++++++++++++----------------------
 7 files changed, 382 insertions(+), 592 deletions(-)
  

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Wednesday, October 27, 2021 12:29 AM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Hu, Jiayu
> <jiayu.hu@intel.com>; Wang, YuanX <yuanx.wang@intel.com>; Ma,
> WenwuX <wenwux.ma@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH v2 00/15] vhost: clean-up and simplify async implementation
> 
> This series aims at cleaning and simplifying the async enqueue path. I think it
> makes the code easier to understand, and is necessary before integrating
> new changes.
> 
> I may have more reworks to propose in next revisions, but I wanted to share
> my current status early so that you have time to review/test it.
> 
> It is only compile-tested, as I don't have HW with IOAT support to test it.
> 
> Changes in v2:
> ==============
> - Print once when max number of iovec is reached (Jiayu)
> - Increase number of IOVECs from 512 to 2048 (Jiayu)
> - Fix Vhost example build when raw/ioat is disabled
> 
> Changes in v1:
> ==============
> - Fix missing iovec index increment (Jiayu)
> - Remove unneeded sanity check on IOV iter index (Jiayu)
> - Fix async->pkts_info allocation check (Jiayu)
> - Prevent NULL pointer dereference on async metadata cleanup (Jiayu)
> 
> *** BLURB HERE ***
> 
> Maxime Coquelin (15):
>   vhost: move async data in a dedicated structure
>   vhost: hide inflight async structure
>   vhost: simplify async IO vectors
>   vhost: simplify async IO vectors iterators
>   vhost: remove async batch threshold
>   vhost: introduce specific iovec structure
>   vhost: remove useless fields in async iterator struct
>   vhost: improve IO vector logic
>   vhost: remove notion of async descriptor
>   vhost: simplify async enqueue completion
>   vhost: simplify getting the first in-flight index
>   vhost: prepare async for mbuf to desc refactoring
>   vhost: prepare sync for mbuf to desc refactoring
>   vhost: merge sync and async mbuf to desc filling
>   vhost: increase number of async IO vectors
> 
>  examples/vhost/ioat.c       |  30 +-
>  examples/vhost/ioat.h       |   4 +-
>  lib/vhost/rte_vhost_async.h |  42 +--
>  lib/vhost/vhost.c           | 130 +++----
>  lib/vhost/vhost.h           |  67 ++--
>  lib/vhost/vhost_user.c      |   4 +-
>  lib/vhost/virtio_net.c      | 697 ++++++++++++++----------------------
>  7 files changed, 382 insertions(+), 592 deletions(-)
> 
> --
> 2.31.1

Reviewed-by: Jiayu Hu <jiayu.hu@intel.com> for this serial.
  

On 10/26/21 18:28, Maxime Coquelin wrote:
> This series aims at cleaning and simplifying the async
> enqueue path. I think it makes the code easier to
> understand, and is necessary before integrating new
> changes.
> 
> I may have more reworks to propose in next revisions,
> but I wanted to share my current status early so that
> you have time to review/test it.
> 
> It is only compile-tested, as I don't have HW with IOAT
> support to test it.
> 
> Changes in v2:
> ==============
> - Print once when max number of iovec is reached (Jiayu)
> - Increase number of IOVECs from 512 to 2048 (Jiayu)
> - Fix Vhost example build when raw/ioat is disabled
> 
> Changes in v1:
> ==============
> - Fix missing iovec index increment (Jiayu)
> - Remove unneeded sanity check on IOV iter index (Jiayu)
> - Fix async->pkts_info allocation check (Jiayu)
> - Prevent NULL pointer dereference on async metadata cleanup (Jiayu)
> 
> *** BLURB HERE ***
> 
> Maxime Coquelin (15):
>    vhost: move async data in a dedicated structure
>    vhost: hide inflight async structure
>    vhost: simplify async IO vectors
>    vhost: simplify async IO vectors iterators
>    vhost: remove async batch threshold
>    vhost: introduce specific iovec structure
>    vhost: remove useless fields in async iterator struct
>    vhost: improve IO vector logic
>    vhost: remove notion of async descriptor
>    vhost: simplify async enqueue completion
>    vhost: simplify getting the first in-flight index
>    vhost: prepare async for mbuf to desc refactoring
>    vhost: prepare sync for mbuf to desc refactoring
>    vhost: merge sync and async mbuf to desc filling
>    vhost: increase number of async IO vectors
> 
>   examples/vhost/ioat.c       |  30 +-
>   examples/vhost/ioat.h       |   4 +-
>   lib/vhost/rte_vhost_async.h |  42 +--
>   lib/vhost/vhost.c           | 130 +++----
>   lib/vhost/vhost.h           |  67 ++--
>   lib/vhost/vhost_user.c      |   4 +-
>   lib/vhost/virtio_net.c      | 697 ++++++++++++++----------------------
>   7 files changed, 382 insertions(+), 592 deletions(-)
> 


Applied to dpdk-next-virtio/main.

Thanks,
Maxime