mbox series

[0/6] fix unused but set variables

Message ID 20211115175855.1091621-1-conor.walsh@intel.com (mailing list archive)
Headers show
Series fix unused but set variables | expand

Message

Conor Walsh Nov. 15, 2021, 5:58 p.m. UTC
When DPDK is compiled with clang 13, several warnings for unused but set
variables are present.

This patchset fixes these warnings, which were present within:
 - app/test
 - drivers/bus/fslmc
 - drivers/common/qat
 - drivers/event/sw
 - drivers/net
 - examples/performance-thread

This patchset is split into 6 patches grouped broadly by subdir, as this
set touches code from a lot of different authors this should make it
easier to review.

Bugzilla ID: 881

---

v2:
 - Drop lib/power patch as already covered by 0353121c3384 ("power: fix
   build with clang 13").
 - Rework changes to vmxnet3 to ensure vmxnet_unmap_pkt is run.
 - Minor changes to commit logs.
 - Dropped all addresses from CC that bounced back.

Conor Walsh (6):
  app/test: fix unused but set variables
  drivers/bus/fslmc: fix unused but set variables
  drivers/common/qat: fix unused but set variables
  drivers/event/sw: fix unused but set variables
  drivers/net: fix unused but set variables
  examples/performance-thread: fix unused but set variables

 app/test/test_distributor_perf.c              |  3 ---
 app/test/test_thash_perf.c                    |  3 +++
 drivers/bus/fslmc/fslmc_bus.c                 |  2 --
 drivers/common/qat/qat_pf2vf.c                |  2 --
 drivers/event/sw/sw_evdev.c                   |  2 --
 drivers/net/bnxt/bnxt_rxr.c                   | 22 -------------------
 drivers/net/bnxt/tf_ulp/ulp_utils.c           |  3 ---
 drivers/net/hinic/base/hinic_pmd_mgmt.c       |  6 -----
 drivers/net/liquidio/lio_rxtx.c               |  2 --
 drivers/net/nfp/nfp_cpp_bridge.c              |  6 ++---
 drivers/net/octeontx/octeontx_rxtx.h          |  3 +--
 drivers/net/qede/base/ecore_vf.c              |  5 +----
 drivers/net/txgbe/txgbe_ethdev_vf.c           |  3 +++
 drivers/net/vmxnet3/vmxnet3_rxtx.c            |  3 +++
 .../performance-thread/l3fwd-thread/main.c    |  3 ---
 15 files changed, 13 insertions(+), 55 deletions(-)

Comments

David Marchand Nov. 16, 2021, 12:28 p.m. UTC | #1
n Mon, Nov 15, 2021 at 6:59 PM Conor Walsh <conor.walsh@intel.com> wrote:
>
> When DPDK is compiled with clang 13, several warnings for unused but set
> variables are present.
>
> This patchset fixes these warnings, which were present within:
>  - app/test
>  - drivers/bus/fslmc
>  - drivers/common/qat
>  - drivers/event/sw
>  - drivers/net
>  - examples/performance-thread
>
> This patchset is split into 6 patches grouped broadly by subdir, as this
> set touches code from a lot of different authors this should make it
> easier to review.

For the series,
Reviewed-by: David Marchand <david.marchand@redhat.com>

I updated titles and did some patch splitting to simplify backports.

This has been tested with a F35 container in GHA (I'll send the patch for this):
https://github.com/david-marchand/dpdk/runs/4224438074

Series applied, thanks Conor.