mbox series

[v2,00/15] fix and feature for hns3 PMD

Message ID 20220122015142.9516-1-humin29@huawei.com (mailing list archive)
Headers
Series fix and feature for hns3 PMD |

Message

humin (Q) Jan. 22, 2022, 1:51 a.m. UTC
  This patch contains 15 patches, which include fixing codecheck warning
,code refactor and indirect counter action support.

Chengwen Feng (4):
  net/hns3: remove invalid encapsulation function
  net/hns3: delete strerror invoke
  net/hns3: rename function
  net/hns3: support indirect counter action

Huisong Li (10):
  net/hns3: remove unnecessary assignment
  net/hns3: fix a misjudgment expression
  net/hns3: extract a common API to initialize MAC addrs
  net/hns3: remove unnecessary black lines
  net/hns3: extract a function to handle reset fail
  net/hns3: remove unused variables
  net/hns3: remove the number of queue descriptors
  net/hns3: remove the printing of memory addresses
  net/hns3: extract a common interface to obtain revision ID
  net/hns3: extract functions to create RSS and FDIR flow rule

Jie Hai (1):
  net/hns3: remove unnecessary 'inline'

V2:
* fix compiling errors.

 drivers/net/hns3/hns3_cmd.c       |  12 +-
 drivers/net/hns3/hns3_common.c    |  76 ++++++
 drivers/net/hns3/hns3_common.h    |   3 +
 drivers/net/hns3/hns3_dcb.c       |  12 +-
 drivers/net/hns3/hns3_ethdev.c    |  85 ++-----
 drivers/net/hns3/hns3_ethdev.h    |   5 -
 drivers/net/hns3/hns3_ethdev_vf.c |  93 +------
 drivers/net/hns3/hns3_fdir.c      |   3 +-
 drivers/net/hns3/hns3_fdir.h      |   1 +
 drivers/net/hns3/hns3_flow.c      | 399 ++++++++++++++++++++++++------
 drivers/net/hns3/hns3_flow.h      |  11 +-
 drivers/net/hns3/hns3_intr.c      |  54 ++--
 drivers/net/hns3/hns3_rxtx.c      |   6 -
 drivers/net/hns3/hns3_rxtx.h      |   2 -
 14 files changed, 476 insertions(+), 286 deletions(-)
  

Comments

Ferruh Yigit Jan. 27, 2022, 12:49 p.m. UTC | #1
On 1/22/2022 1:51 AM, Min Hu (Connor) wrote:
> This patch contains 15 patches, which include fixing codecheck warning
> ,code refactor and indirect counter action support.
> 
> Chengwen Feng (4):
>    net/hns3: remove invalid encapsulation function
>    net/hns3: delete strerror invoke
>    net/hns3: rename function
>    net/hns3: support indirect counter action
> 
> Huisong Li (10):
>    net/hns3: remove unnecessary assignment
>    net/hns3: fix a misjudgment expression
>    net/hns3: extract a common API to initialize MAC addrs
>    net/hns3: remove unnecessary black lines
>    net/hns3: extract a function to handle reset fail
>    net/hns3: remove unused variables
>    net/hns3: remove the number of queue descriptors
>    net/hns3: remove the printing of memory addresses
>    net/hns3: extract a common interface to obtain revision ID
>    net/hns3: extract functions to create RSS and FDIR flow rule
> 
> Jie Hai (1):
>    net/hns3: remove unnecessary 'inline'
> 

Hi Connor,

There are some patches in the set that are sent by non maintainers,
for them it requires maintainer ack.
Since you are sending the patch, it implies that you are OK with them
but can you please add your explicit review/ack tags to them?
  
Ferruh Yigit Jan. 27, 2022, 1:50 p.m. UTC | #2
On 1/27/2022 12:49 PM, Ferruh Yigit wrote:
> On 1/22/2022 1:51 AM, Min Hu (Connor) wrote:
>> This patch contains 15 patches, which include fixing codecheck warning
>> ,code refactor and indirect counter action support.
>>
>> Chengwen Feng (4):
>>    net/hns3: remove invalid encapsulation function
>>    net/hns3: delete strerror invoke
>>    net/hns3: rename function
>>    net/hns3: support indirect counter action
>>
>> Huisong Li (10):
>>    net/hns3: remove unnecessary assignment
>>    net/hns3: fix a misjudgment expression
>>    net/hns3: extract a common API to initialize MAC addrs
>>    net/hns3: remove unnecessary black lines
>>    net/hns3: extract a function to handle reset fail
>>    net/hns3: remove unused variables
>>    net/hns3: remove the number of queue descriptors
>>    net/hns3: remove the printing of memory addresses
>>    net/hns3: extract a common interface to obtain revision ID
>>    net/hns3: extract functions to create RSS and FDIR flow rule
>>
>> Jie Hai (1):
>>    net/hns3: remove unnecessary 'inline'
>>
> 
> Hi Connor,
> 
> There are some patches in the set that are sent by non maintainers,
> for them it requires maintainer ack.
> Since you are sending the patch, it implies that you are OK with them
> but can you please add your explicit review/ack tags to them?


Implicit ack converted to an explicit one:

For series,
Acked-by: Min Hu (Connor) <humin29@huawei.com>

Series applied to dpdk-next-net/main, thanks.
  
humin (Q) Jan. 28, 2022, 12:40 a.m. UTC | #3
在 2022/1/27 21:50, Ferruh Yigit 写道:
> On 1/27/2022 12:49 PM, Ferruh Yigit wrote:
>> On 1/22/2022 1:51 AM, Min Hu (Connor) wrote:
>>> This patch contains 15 patches, which include fixing codecheck warning
>>> ,code refactor and indirect counter action support.
>>>
>>> Chengwen Feng (4):
>>>    net/hns3: remove invalid encapsulation function
>>>    net/hns3: delete strerror invoke
>>>    net/hns3: rename function
>>>    net/hns3: support indirect counter action
>>>
>>> Huisong Li (10):
>>>    net/hns3: remove unnecessary assignment
>>>    net/hns3: fix a misjudgment expression
>>>    net/hns3: extract a common API to initialize MAC addrs
>>>    net/hns3: remove unnecessary black lines
>>>    net/hns3: extract a function to handle reset fail
>>>    net/hns3: remove unused variables
>>>    net/hns3: remove the number of queue descriptors
>>>    net/hns3: remove the printing of memory addresses
>>>    net/hns3: extract a common interface to obtain revision ID
>>>    net/hns3: extract functions to create RSS and FDIR flow rule
>>>
>>> Jie Hai (1):
>>>    net/hns3: remove unnecessary 'inline'
>>>
>>
>> Hi Connor,
>>
>> There are some patches in the set that are sent by non maintainers,
>> for them it requires maintainer ack.
>> Since you are sending the patch, it implies that you are OK with them
>> but can you please add your explicit review/ack tags to them?
Yes, I am OK with them.
> 
> 
> Implicit ack converted to an explicit one:
Thanks Ferruh.
> 
> For series,
> Acked-by: Min Hu (Connor) <humin29@huawei.com>
> 
> Series applied to dpdk-next-net/main, thanks.
> .